From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 853D32288E3 for ; Sun, 16 Nov 2025 18:00:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763316017; cv=none; b=faqncg8Ad1xZpCu4+bb+SPZDzGr7ANbdAZiigGkQTmoD2QgD4oRsJSKCHANqSIwi1gvPy8fxaeQpdm1D6kYt+ElI/vP0PCOqt7dQvl9gvAhW2upMRMros6kdEW/J8PYJ2qZLH5ZCRq2iMvMUf0za/MoI7rY6ORtRGwDhJvWNf64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763316017; c=relaxed/simple; bh=4bNQSFj5hf/jGkPpYOhkJolC7Cjx+446q/N2hDsuwx8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U0ITpu6n+mJvpbU59zC6Cl0nCWnsz9Lfo81YUeB0bFE94/F54Nj5lV7aPurbB10SatZu4mON+y7SVkK1w+bZkhZZbF9gqDfJp8ln/C5tRG5osCmLrk2irCd5sI+eZNMVLWYhVBoeTtA+JHd14tWYwC4+RhsbsAIpMtlUmKQmfmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Xf5EFD8M; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xf5EFD8M" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-29853ec5b8cso42823545ad.3 for ; Sun, 16 Nov 2025 10:00:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763316016; x=1763920816; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DeuJmAB9iGCoM9KFNRE0tBxG/2yQDs+Ahoor7rwDQqY=; b=Xf5EFD8MJ7Oi0ZN1EDagaqUoCte7qGiAaOsge5sQDH+jNUoOEdK2lq8uBO7Zub8DEP faAPTm20yVYgbZLctxFExtG58bh0fsv2oHnDnZbhhUjinCa8HdC/2YHgjOl6ubhqKJAH UsHaXbqz6xKu6PB/YuzXuPPXlva+s70EP6jFD6RKT5If8x3VVz8UcBvJfCnUEO6WqN/F bS8fngbxHCXAc/F8WBSSW/OKl7smeK/2nWvOHqHU8ccQt8EHnMtaJV/sfjdosyCOwWMS l7xHQDm5oRPYUt+/2n6H4fDlEC+uG8zBO809btnUrKshdADscY3jmJiinvFLOsnc4MGM 14DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763316016; x=1763920816; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DeuJmAB9iGCoM9KFNRE0tBxG/2yQDs+Ahoor7rwDQqY=; b=OWzfcwuzbVa3hEgECZ8/13PrqJAm9uW8YTa3DiXAgm/0DKJjK9mYAgqQh+R99Ru7hX 1V2oT6IqioYdct4UxvbZ22pzIjllf7JG1OsEgeDGClFjDQ20ELkEhL8AHPik97ZKMXq+ eyjwXZl5mQ8hHHPyPeFyDErqE0oT6eZCx7HkXBOdrF+ZmQfoSpktGxNCAmqTlawERAEP dVct3n6fn/OByAlxk/nieVee4+mhENsIRfKwHbykxxLgLiPNI8DGcm5MkqtILf9zMoOY 2KLpj8Y+nEk135oHDmxa1yCLu3d108cg/r+oiCsbG3RkUXm+iXMjj+CkzrOrt9K/M7d9 o3dw== X-Forwarded-Encrypted: i=1; AJvYcCW/4A0TtanKinia7ZjYe+DFJCpJ3xNlSUCSbKJlAI0Z8SCQXqOfTu42vR/fkwiSy2ssrFOJFxny8lOGan0=@vger.kernel.org X-Gm-Message-State: AOJu0Yznp8LV9FSAi9zqiuS/Fe4IRsmtdmc4lSCc0UEeqnJ6nLnT/ZgM DBzEjXWoXrcrJUoosRYP4tKSJjLw5NWL77YLzcfDMSe2Mo8qorDJQtsI X-Gm-Gg: ASbGncsAYAmPCYKs7pppucIygL3TYhJcTHfC4I0nunO+6tVdJHtowLKZ0StDl/rhI03 TyhVfY+MmyNMvXK4XhtDbsCy4BdNUCxL36ruLG/N0gpwhK+hjrs52Qw+nv+pHk31G37u6rDGW76 lLsoF8N8j/FbSy11Y3g7fPl9f9x14Svs9gGcLxMPhecUMqwqqd1LEUu/u5JXlBedKxhO5pPvGa3 fMF8Q9W4Y/Gp2ZAsz1IjSRXTayRzGKA3eSwX/NP01/+7+Pu/nsICnvfGZz+gAmz5LXVx+bd/b+L ukR1IBNxWY0pYM3EmlNHXUZcs67qzTGeKRZry/GA1P3CmQYCt7GftJT7j2tJ81GYo0aWAzf169K FwJsyo0mK5Xf+VEsfC+duozVJgz7JGhZV4F842TFhcfzYMpeDA+Igy9CtleGHTh+bksHqVg1cvu 2TSodHV6PDFvabgYocuac6cHL9gEmNQbFacIk= X-Google-Smtp-Source: AGHT+IH8JlO8h75rEDYJ9Ee4B0RDae6Ov5UJRiX2QDIhpbgy7/yAB5+6i5vuGlFYH4yP8lhUXTQNug== X-Received: by 2002:a17:902:f64b:b0:295:5668:2f2e with SMTP id d9443c01a7336-2986a74186bmr118803845ad.37.1763316015605; Sun, 16 Nov 2025 10:00:15 -0800 (PST) Received: from google.com ([2402:7500:499:ceaa:49c7:4719:2441:afea]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-343eac7fc34sm6838527a91.1.2025.11.16.10.00.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Nov 2025 10:00:15 -0800 (PST) Date: Mon, 17 Nov 2025 02:00:10 +0800 From: Kuan-Wei Chiu To: Eric Dumazet Cc: Andrew Morton , Jakub Kicinski , Paolo Abeni , linux-kernel , netdev@vger.kernel.org, Neal Cardwell , Kuniyuki Iwashima , Eric Dumazet Subject: Re: [PATCH 0/2] rbree: inline rb_first() and rb_last() Message-ID: References: <20251114140646.3817319-1-edumazet@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251114140646.3817319-1-edumazet@google.com> Hi Eric, On Fri, Nov 14, 2025 at 02:06:44PM +0000, Eric Dumazet wrote: > Inline these two small helpers, heavily used in TCP and FQ packet scheduler, > and in many other places. > > This reduces kernel text size, and brings an 1.5 % improvement on network > TCP stress test. Thanks for the patch! Just out of curiosity, do you think rb_first() and rb_last() would be worth marking with __always_inline? Regardless, for the series: Reviewed-by: Kuan-Wei Chiu Regards, Kuan-Wei > > Eric Dumazet (2): > rbtree: inline rb_first() > rbtree: inline rb_last() > > include/linux/rbtree.h | 32 ++++++++++++++++++++++++++++++-- > lib/rbtree.c | 29 ----------------------------- > 2 files changed, 30 insertions(+), 31 deletions(-) > > -- > 2.52.0.rc1.455.g30608eb744-goog > >