From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F90F264619
	for <linux-kernel@vger.kernel.org>; Mon, 17 Nov 2025 02:41:38 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1763347299; cv=none; b=amu1NUDZ7zu7SDnEyzPA4H1VNdej+DemdGvsq65mPT0UAKgvRDgI1HJuRPSd0NBBMQXgHeI7Ip9C2TOGGJc0mUxg2IXBvxWx/SSdqkgKLDIS9fGBgqfZ2ySMv+0Ig86b4ooq6fA9119vhOVfe3JrO6mh/M877bim5duGIJWvuZ4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1763347299; c=relaxed/simple;
	bh=4kQo0l1+wIBe4TnTPsmXnzhMPTDY/tnsLkiO5EcdZR8=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=PI0KAb0W2IolU1bmxTgehytCKH73QEgrxLpsm5h10cRycZfStOyIa54j93nXwBxtIdS0TrTCwd8XAjeZR+IEcJh9CQTrrvShVo5GYVEtUpFtFbo67Hnc0VdA2BoC31PF5hPrrwLCw+s5ivxSwK/AT2cmkJbZZLLNkrDmw7m/p6U=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NREFQaut; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NREFQaut"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 672B8C19423;
	Mon, 17 Nov 2025 02:41:37 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1763347298;
	bh=4kQo0l1+wIBe4TnTPsmXnzhMPTDY/tnsLkiO5EcdZR8=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=NREFQautETZkb7Ltdz6QanIcZ6Mj6BpE4/ozPAIelVhHE2z/J3lmRSaCpp/JOECTT
	 jYzx4PAt/KNw/AAKyoJDq/SMU7QwwDLRTGTf8CAjICIT4F/yI7i2WvpC1Ha3KSTZMD
	 Xhe9qmvOVNh7mcJI+F8tKLNy1SENNF7rqQ8OagEiUUku10QaCB8SYIC4oMlw8PVNyj
	 RVRe4c5FnMIsNr/UI5w4eiViIuxM5xcK3VoF7mlsqC5eKtvpHtd8TMM7mKDRDeQ8G9
	 B3GHE6KXPdynajgZ0F6NDH7MZaKVoBu7hOboR6aVip+oEOV6qNAQ4cp/C2iZ7v/UKv
	 fj+/x88HyH0NA==
Date: Mon, 17 Nov 2025 02:41:35 +0000
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
	Will Deacon <will@kernel.org>, Boqun Feng <boqun.feng@gmail.com>,
	Waiman Long <longman@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lockdep: Add header and footer to surround warning
 reports
Message-ID: <aRqLX2F4ae7hApng@google.com>
References: <20251114062730.1828416-1-tzungbi@kernel.org>
 <CAMuHMdVL=0u0-1GtVyrf_uYadNf3L9Y8a8zemzVwU1SnNV5x8A@mail.gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMuHMdVL=0u0-1GtVyrf_uYadNf3L9Y8a8zemzVwU1SnNV5x8A@mail.gmail.com>

On Sat, Nov 15, 2025 at 05:36:43PM +0100, Geert Uytterhoeven wrote:
> On Fri, 14 Nov 2025 at 07:35, Tzung-Bi Shih <tzungbi@kernel.org> wrote:
> > --- a/kernel/locking/lockdep.c
> > +++ b/kernel/locking/lockdep.c
> > @@ -1958,6 +1964,7 @@ print_circular_bug_header(struct lock_list *entry, unsigned int depth,
> >                 return;
> >
> >         pr_warn("\n");
> > +       pr_warn(CUT_HERE);
> >         pr_warn("======================================================\n");
> 
> I guess you can drop all lines printing a separator made of equal signs,
> as CUT_HERE already contains a graphical separator.

I'm not sure if we'd like to maintain the "backward compatibility".  I.e.,
if there are already some tools rely on the "====" to parse the report,
should we consider to preserve the equal sign separators?

Happy to receive some more feedback.