From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E6B6208D0 for ; Tue, 18 Nov 2025 00:34:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763426049; cv=none; b=CdEdJJKrtNjJccp/qu8uyzCfK/CXwOLnwe581EGDa0I0TEypVO5URChmWNWGbJx/gInRnJSCTmxjJyNaz2fCpDhMrnSk5Z7Muvg2LQnqVx2vV88tnBjngX6uYbE8x70QpTn0r9vrz5f0t7JlkOAYe8PBZMElZFWUY3AqkS3Vw3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763426049; c=relaxed/simple; bh=8vasXkMPmOH9aGjpZc+D44J767M8I3avHSTES4Q1P2Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PD7p63AAK/7UuWVeOB18/B95F95pRfOgPJ1xYmJbgE3x+S2xmNofq5Ne8tdp60r38Wlsx+QVnl48wfO3/xf9is6WWVS9Ja5hIQPNuVjjHs4ElnBAKDFI6bEWpqT0HcByx9uwaXo9d3cFohZXSH6pylKm61RTq8wfebnVoi3FGrw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ga6YUqOa; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ga6YUqOa" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-bc274b8b15bso3773265a12.1 for ; Mon, 17 Nov 2025 16:34:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763426045; x=1764030845; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X9AZpi4rt1ui+XTsMMyozDrxAzlPBqocMCdUZQhvEGY=; b=ga6YUqOagivJEgYCvF00vr8KGiCZlFxVO7y+a0X+/nXpkIKwZ8yrNp4uvqb7r1b95X BEOBAhWrQvXdhWUGtw1ZwQ1x/Q6ewkCjmH0kfoxmk/Czs6nxUNAjDQkC2fzK2dOSOneK o+Lk8/hfru1Rs8pt0M+kgtAlfaMMKGZkm4eY58Q4U1ycxRXZutbzMO8TcP+DKy7eqsP4 rCSEK2Xs/rTIzGcqmzntNxVMBR0hDW5GOK7l2G4891ppz313mLPA0zGBqA0X1ztkdCvu MvkPh4+RpRv6V3IXqL3tddkGVT8XsF9+9WHHV0U6uMLdZo4DWNPPj9n+B/VUo0imC/oY aSvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763426045; x=1764030845; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X9AZpi4rt1ui+XTsMMyozDrxAzlPBqocMCdUZQhvEGY=; b=XZECzVDX6oWIe5OQdF6RG/dVXOQ0ql+LzYV04ENbNBRNPbA4K22jJxnRbQmfE10vON N5t//SGBJ7uup5yDcbHBZWTRGUO7ANoBsRrrouZUGT+fZesafPCGDCD9BzvfXhbkwPKo 0lBIvpFMNneAQ9qDaAlwz87l95vhy/DcoRX75eAfArjJvHiSQuznCKOkHmfakegGLDlb Vv6l4oEtwUE9jXOem5rcVxvT5wyqOHSQsBmYhcDlFPJYV59ybUXCJVk3ILn+/IH4XQK0 aJYAMLSAwrbMJo0D8tVrD+wIkUGtP+zIi5kHc6pOtcBXx1t/puY5hi0r2LAaZS7t9T2u XzIA== X-Forwarded-Encrypted: i=1; AJvYcCVI+7RisEVEP3MnVfY/TdCq5vzFH9Z6VM/AkGVOVigkoUn3zJAtb5BaffagzygGOQYkgRMpluBwtnQqDcs=@vger.kernel.org X-Gm-Message-State: AOJu0Ywnk7i8IybPPnXqbrUFLblTn4r9s5Rz+w2DKBSCvIVA9HJR3XSy Z8/yGEbsP1rQLOF/DCBfFIxEgTQH660m/049Uhyv4RhCb4G1mSsTUAhD X-Gm-Gg: ASbGncvMMq9wpRLRvMB1NAqitTsR8zBZ/g8ad65XkfVy7mSZO8YCn/eoldZSkPCepMP P5GhsRZhE50KpxqibBhkVwxT9I6hltffTwofVw1r6AezcFPnbWtK/OLWEHQgVyLHVasw4VkeLD7 +eGJw4EsCvPDzeWvFs3YaayBwDqft5dAoDTgrS16buNcNTNngFOxODiv1BL+l01C4h00Sn4H5El 9vgcQG/Y5pEliIPC0QM19GYTuTC1FNkhEAqB991woqLG6dWXM5ZMYGMcoBrUDhtieawL4FTs3PM 4hv/y4qkoyOR6hVKfzp0y17N8KabYUWGhxVE6IiTGpvkZMbCy+v0wT1Nc9iHrT290JdUIyy1Nfj lNxrpJWYo+TUlCIjW0IiTR/VHsWaMHre9eIKm/we++YHxjl78XlX9pk4ULIeVf09NiXn/ZkIX9W joDIAs4zVnwN2ojLdnujLMKuUYmXY6IdfTi6RjrK43mvk= X-Google-Smtp-Source: AGHT+IERhdfBGNNDmKwPm4AkzEyQK0Uu9QznZufddn/c8xEntSCPx/v/Mh1bHvhpFcZEPkiU22WElQ== X-Received: by 2002:a05:7301:a28:b0:2a4:4527:1f0 with SMTP id 5a478bee46e88-2a4abb30665mr4073482eec.34.1763426045123; Mon, 17 Nov 2025 16:34:05 -0800 (PST) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a49da0662dsm52726368eec.2.2025.11.17.16.34.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 16:34:04 -0800 (PST) Date: Mon, 17 Nov 2025 16:34:02 -0800 From: "Vishal Moola (Oracle)" To: david@ixit.cz Cc: Andrew Morton , Uladzislau Rezki , linux-mm@kvack.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org Subject: Re: [PATCH] mm/vmalloc: warn only once when vmalloc detect invalid gfp flags Message-ID: References: <20251118-only-one-vmalloc-v1-1-29f8eacb4605@ixit.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251118-only-one-vmalloc-v1-1-29f8eacb4605@ixit.cz> On Tue, Nov 18, 2025 at 01:05:57AM +0100, David Heidelberg via B4 Relay wrote: > From: David Heidelberg > > Without WARN_ONCE, the logs get spammed immediately after the boot, > on devices as OnePlus 6T (Snapdragon 845). Do you have any snippets of the logs? There'll be a particularly helpful section that says "Unexpected gfp:"... > Fixes: 7179b2256315 ("mm/vmalloc: warn on invalid vmalloc gfp flags") For some context, this patch begins enforcing the gfp flags passed into vmalloc(). If the logs are getting spammed, that means the device is calling vmalloc() with some unsupported gfp flag, many many times. > Signed-off-by: David Heidelberg > --- > I'm not 100% sure this is the right solution, but having WARN_ONCE or > rate limited warnings here helps a lot on devices as OnePlus 6 (sdm845). Can you check if it still happens on today's mm-new? I just sent a new version earlier today that also masks off __GFP_ACCOUNT, and had an iteration earlier that added __GFP_HARDWALL.