From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1850D2DE714 for ; Tue, 18 Nov 2025 01:06:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763427971; cv=none; b=rFHZYbVU2wEXp083c2C3OIMRRMEL1zndi3qPrz30dZMXkGzZ2/JXltIE/ofLEsGGFPfd1k1EnyAqC0ktDiaNnv7UphPrsx53JjrzZWHvhOzv5Jz1hD7+2Ui5dJTsZ9ehIsejltNubpUeddvi0kybVt+/7xvM6xjNNGckclqcXD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763427971; c=relaxed/simple; bh=vM3Ya7y05+gmakpd+ar+1VncrmoWyvnGnKStM1gFFXE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ig3eGtKXkyXAk9LGTcjDBBm1Rb17+N+xZqhV1gMvlDmST0aYD63ZuBfjPy7JJfPsZVRZFHpEnAvWQdwIBiZ1IQ/rc1dDo3rk18eHPANQCHMJCIAexSrIF1EgQOssthvaRr2kDGzp4yD9grQUbyEhKp3OqyLThnoDqMjV11Wfif0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jJ/t3f/S; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jJ/t3f/S" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-bc2abdcfc6fso2861699a12.2 for ; Mon, 17 Nov 2025 17:06:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763427969; x=1764032769; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NuT9qaNyEjZfIy16bIhwfj6VRiigeFvL4hxLaIBcqis=; b=jJ/t3f/ShZPNluA9c43rJggWpRcvdFtfTxYRXRENtOKDIKix04nf6VdNtIuZwkZTGU DmOmDGnYKUVdc1dz+yDhBb1UMuZSSLQ1Rf9cd5Jn2zSmlSPExc2fA5hLtEsNnYvpZBKW 81i+1piGju0AlIlDV2NTAPDIR+fGp6GAnkr7tJtBL3Pd3ktrN9ufPS5uIuj0h/0jx85P +Aj+Y+yE/0u4f+NmrzPLRhCsHCgtZGmmV3WiGjqbQRHK7iZ4tFjmW5RhoGXLgRJ1k9EB +xOeQFlow9wE11tFPDW94XmjAGCs83azK567aqMo7f0jNRMBxllNy+zYp5YfL8HoJv8h K4uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763427969; x=1764032769; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NuT9qaNyEjZfIy16bIhwfj6VRiigeFvL4hxLaIBcqis=; b=Bi+RfXC4nyzNUgDMiTkb9yhLoSxg4ucFcXgqvUwhsFveATMvqskFz6Q2oCDwuHn2FL X5Jm+jj/pzEkMIZ9MIWFgjhOCmXtQNCG9T22Hr52mCM/P4rk7itEOxYccvpsZgWN9/0T ZRC53agRzgXPUx/ZP4UM3Mub9dXe+HQNScFkggpuHjIpQWDxCQ0r0yOq5MHRHxFVQ9zS cfExtMkO/ozIHxCXmXmonLpGQ3KOLYmZE2RpDm97/iKzSwFDAi9fqL0vfjZhXaFF0eCp e6A+SCUM/xgceZ9lCGx1rVcNTKYXFCAxx4z9iU9HvCQPssWqGlivDyGTSzN2M+HVIjF7 Wakw== X-Forwarded-Encrypted: i=1; AJvYcCVom+rJgdpQmFMs1fEku1sscSv2tTZafO39A4NCfRiyqkmtcZjYUndT4yOkxFGEWpNDP8asJoTXLdwXyH0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3Q7cT95JKaL/6FNOqQierzOOkne23ZkhI4NoYaT+iB3DEH5JU 7yQPskXxNLeZKCRAyzLG9EUBIhCSok//7lImYnUm2Cm6uQPHNks59YC3 X-Gm-Gg: ASbGnctvObr8sineuvtw8Tt4oIyvx5NmDuzWRCA4DzqQXdr6ziyMXHCVILtWDHddFiN gJS0q5RGsn1dYqMcjU5X2h2bVrBgTJEPvW8UZbuQue6jM3cS8PsLglbJ86bY9LsIlVk5cAcuPhT 1OhIKpiB7Uw0LVN1M8riWlunaKlpI7NP+f9uglPSj+HSfrOkNs3xn7rwSJVBmo4VM5AJLvpimNU gGp71mkWCVQWLmmwPXoFe+6S7glg4Fz6E7vWCOga6o1xdarxcJWzOFjai1/004z+hxECat+afD0 /ix3BmQlqvNmYLyUj9IYOy4EKhbbVBWehRVSBrv4ZklO8LlAAord73YTXSM6YhHwV8KusZAijOh OZfhNTQ3ygydisE0emVDqn6jLHhvnXVw8dLTxBYvKMYXgQsuQVZF1GhnakTGBdvBhxt/yUMO79A XyEMepfg3mYr9WFrsn4h+x9DjgeYSMqduk9sSxB/j1jqC5B2Q2rLpzbw== X-Google-Smtp-Source: AGHT+IFwH0TbW37DQk0Ytd0vjS1rf0XcD6M8DDxMQ9u0ZyqXmO0VVOfpW6HRgHzgDux3Viwk3VROTQ== X-Received: by 2002:a05:7301:420c:b0:2a4:3593:ddd5 with SMTP id 5a478bee46e88-2a4abab97bcmr5228685eec.2.1763427969103; Mon, 17 Nov 2025 17:06:09 -0800 (PST) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a49d695821sm58437307eec.0.2025.11.17.17.06.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 17:06:08 -0800 (PST) Date: Mon, 17 Nov 2025 17:06:06 -0800 From: "Vishal Moola (Oracle)" To: David Heidelberg Cc: Andrew Morton , Uladzislau Rezki , linux-mm@kvack.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org Subject: Re: [PATCH] mm/vmalloc: warn only once when vmalloc detect invalid gfp flags Message-ID: References: <20251118-only-one-vmalloc-v1-1-29f8eacb4605@ixit.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Nov 18, 2025 at 01:51:23AM +0100, David Heidelberg wrote: > On 18/11/2025 01:34, Vishal Moola (Oracle) wrote: > > On Tue, Nov 18, 2025 at 01:05:57AM +0100, David Heidelberg via B4 Relay wrote: > > > From: David Heidelberg > > > > > > Without WARN_ONCE, the logs get spammed immediately after the boot, > > > on devices as OnePlus 6T (Snapdragon 845). > > > > Do you have any snippets of the logs? There'll be a particularly helpful > > section that says "Unexpected gfp:"... > > I didn't save it, thou I'll run the kernel with all logs again tomorrow, > what I remember it was "__GFP_ACCOUNT" in unexpected section. Gotcha. That's particular flag has been added to the whitelist as of today. Hopefully there are no others. > > > > > Fixes: 7179b2256315 ("mm/vmalloc: warn on invalid vmalloc gfp flags") > > > > For some context, this patch begins enforcing the gfp flags passed into > > vmalloc(). If the logs are getting spammed, that means the device is > > calling vmalloc() with some unsupported gfp flag, many many times. > > Yes, it was full dmesg buffer just after the boot and I think ongoing. > > > > > > Signed-off-by: David Heidelberg > > > --- > > > I'm not 100% sure this is the right solution, but having WARN_ONCE or > > > rate limited warnings here helps a lot on devices as OnePlus 6 (sdm845). > > > > Can you check if it still happens on today's mm-new? > > I just sent a new version earlier today that also masks off > > __GFP_ACCOUNT, and had an iteration earlier that added > > __GFP_HARDWALL. > > I can try tomorrow, any chance it'll bubble into next-20251118? I'm not sure, Andrew should know? > Thank you > David > > -- > David Heidelberg >