From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F8F626A1AF for ; Tue, 18 Nov 2025 01:16:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763428610; cv=none; b=pYryAGzOPbkLGFoRnRJ4Btx48hVD0fSsT76REJMkj92lPdBGCt0SvH+EVgH3BUhJJlALkxzkijAZP0xQH5vyWdGuBUGkwR2qei0maTyN/4pgvTs19XYs2FBzqxNf8Y6xr79DXAqz1fflItV5dN+0UzG9HtCvejNx815TxNaL+ng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763428610; c=relaxed/simple; bh=49zUBrMSgpw4Fi+zoc0KoBtSjoHHfquW5LFi6wcJ8wY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XmLIEpBZYpU4DitMwFRvs743GzIB7vw1DNdoUvF4NMFh/8QkLM6l2nyS7I29w3/0Vq+XaS1ToKVbZ6DvlId1yElFjD/WtdV3ynaP5Ag399+D2sVK8eCI5ScBHiQeVaOHQ2PDHyxbu7O99BgmLfenCc14XKxgi1Hct7W7LO7fT38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VHzoLq9h; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VHzoLq9h" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-794e300e20dso4118719b3a.1 for ; Mon, 17 Nov 2025 17:16:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763428608; x=1764033408; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O/zaQaUgcusdFX7nIVvdS4Rs3VOW44H6bNGVPWT30wg=; b=VHzoLq9hIzEQ/6ont32rudmtpXmPpN1ayYKtp8qlAjBs2+yt83X0KL4DMQBfTN/rtv 5Y+3dVHpHC6LBTvf2rjDVFeg55gUz6rp+IVv5RRiBEc0IR1iazUhg0LzkvJ91RuqKg7x LhEKUJHjSSCM37GnICPqGSGvlEs1i3hzDRZpi+NmqpRLvE5ZyHIOXZNjd90R0RVCw93x 2CALfpAOJkww9Lf4/nL9a9kqjmcLlssQNIye6iu2QpgZnL2dW3NJZS8zGTo6rgNco1uq P6XX2iP7tU1WBayShQVEf1StLx0/K4l+WcUjMCppIV75nwAk5F5fDW+EDNDSBgQk7j7S qeGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763428608; x=1764033408; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O/zaQaUgcusdFX7nIVvdS4Rs3VOW44H6bNGVPWT30wg=; b=UpwhhOnqAE01mXJrgOd1FCHUupEuMgkYjvnv8YMA9+E/ro5KgsfV7yBU+stHnurmak NYO/Z3s+BjOa9k69esA8+OqNv36ZshYelb+dqElexrdq/tQW43dy2yT9jr/aX4xR78ts Wex3vdbIabmj1tPXN9lWh5I4LF1lvP0EoA+MRNypdZYhJe208DYxkCrUOZ/2wUpYWDH3 UD8BjnOHa8Nec/miegx9INU4ez6iGoKbqDUUM3ipjuULyAslFXOxFZWhoU4p0U3lDJwP K9mGfR8RE+KtjoJ1dfONv+weYZUxp0pkidIMJ4LCBE6LZo7hQabiBdbqQrSt7WtomMwM x3aQ== X-Forwarded-Encrypted: i=1; AJvYcCU9LkjjK+aqSJ/hxcgoWo2vAQBfc2qgFaEDnUX2TTwXEKqC2ermr48XFd5/IenVcqo9+GZ2POj8BUzyLbI=@vger.kernel.org X-Gm-Message-State: AOJu0YzZdgZW/+QMpsQYbRrwakkxTlWiG89ZUCHM4Lw6D1KvPBN/8Wyi FIyrXvNw5lSyOIX7WQnpGbSFXYQ5sGjS4D6/bVa4D7ZC71Ef7bu5t4Hj X-Gm-Gg: ASbGncu/gj91xQr2ZFwX6ihptWphLXG2SU8k6KMh2WtqgLiOIWKaitvbOrnvsY1dGH9 XyRqzSkmNJIR0tjUiWFbV66/hK5U/g+LIdKiBwyiO9jwW1vCEN6wQpN8FyXqanVKzm0vOy7PyMW g4hxe2iFrdHP2fKT0hPC/uWVPGVzsVDvbS40vaCvJhCNbVbzWSCC7vFhD4evaJRX7zklTgYC3uG hg9GqO/Mk9blAyZpyzJBhWLZqigaflH1iRg3ghp29LY1oIeDk1jDMYrgZaEQT9gO3rxQMNgQJZt a5l1iQG/s2RszXsa0wuLtH818WQ1zwS3rGgs0LwlMWwDWS1/PB13brgBHn7YnpG8REV+W4Eu+UY l7mP2U0IVMFGHYjG2uA6aAlONDxICwgWYS7U7AIqP5rnSuujBkEMbvDToWtUFcKsaARKwyBpnXE JNI1Fel0P6dvBjtIIKt5m/M0LDRJWo8jupvVDEVzUbQNdnL2VKHwsdkA== X-Google-Smtp-Source: AGHT+IG/TBV+A8bmaBoikqNUtCPQowFYhYHjj48TCLGRnn+yJSpzeNPkOqlPll9rNNnNRGEy7v6bsw== X-Received: by 2002:a05:7022:1e05:b0:119:e569:f865 with SMTP id a92af1059eb24-11c74883629mr519011c88.2.1763428608428; Mon, 17 Nov 2025 17:16:48 -0800 (PST) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11b060885d8sm58399516c88.2.2025.11.17.17.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 17:16:47 -0800 (PST) Date: Mon, 17 Nov 2025 17:16:45 -0800 From: "Vishal Moola (Oracle)" To: david@ixit.cz Cc: Andrew Morton , Uladzislau Rezki , linux-mm@kvack.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org Subject: Re: [PATCH] mm/vmalloc: warn only once when vmalloc detect invalid gfp flags Message-ID: References: <20251118-only-one-vmalloc-v1-1-29f8eacb4605@ixit.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251118-only-one-vmalloc-v1-1-29f8eacb4605@ixit.cz> On Tue, Nov 18, 2025 at 01:05:57AM +0100, David Heidelberg via B4 Relay wrote: > From: David Heidelberg > > Without WARN_ONCE, the logs get spammed immediately after the boot, > on devices as OnePlus 6T (Snapdragon 845). > > Fixes: 7179b2256315 ("mm/vmalloc: warn on invalid vmalloc gfp flags") > Signed-off-by: David Heidelberg > --- > I'm not 100% sure this is the right solution, but having WARN_ONCE or > rate limited warnings here helps a lot on devices as OnePlus 6 (sdm845). > > Please let me know what you think. > --- > mm/vmalloc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 49e0b68768d73..2a3ee17093d6e 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3934,8 +3934,8 @@ static gfp_t vmalloc_fix_flags(gfp_t flags) > gfp_t invalid_mask = flags & ~GFP_VMALLOC_SUPPORTED; > > flags &= GFP_VMALLOC_SUPPORTED; > - WARN(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n", > - invalid_mask, &invalid_mask, flags, &flags); > + WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n" You accidentally deleted the comma here. Once we've found all gfp the callers currently use, we should never be hitting this warning, so ratelimiting won't matter. Either way is fine by me though if you still want to fix and resend this. > + invalid_mask, &invalid_mask, flags, &flags); > return flags; > } > > > --- > base-commit: 0c1c7a6a83feaf2cf182c52983ffe330ffb50280 > change-id: 20251118-only-one-vmalloc-b8d997045791 > > Best regards, > -- > David Heidelberg > >