From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BD5B3191A4 for ; Tue, 18 Nov 2025 09:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763458585; cv=none; b=lUCYoE/FoQLOlA5RI5f7v6vu/SC/kL37vsBeY6Tr51SDhost0Cpoqt0QI/SdxOGpmbodc8ofkGrSNXLsTodgqCnJZ4wH84sO964kQPP6us7MZe+CG0eC8VlNF0oa7qK9aFQ8UdNmf/NmRa8z6L3wMWyAtr6HlahAUyiPMNnSofY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763458585; c=relaxed/simple; bh=xFvX7F5+2D2kTi1KTz3rv71Ui19czvixzv8OriHMuTk=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dz3FXIYOrPgKNkwDC0wneewnn33V9GYOtxFxDlYO+nQiYDAfIFQsrJI7B0ve3SG6SRb7wP9IBHa6bfw6T44DuDHQbp/Y5ZoV6d5RntzDcKdH3Ip0+aPZO840lNKBmr4priovILG9jjVX/4r77+EhzjqPfF8bHXNbX37uPxdVh6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ngky8XEj; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ngky8XEj" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5957c929a5eso5991899e87.1 for ; Tue, 18 Nov 2025 01:36:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763458582; x=1764063382; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=6W+PHyYr6Qrds76dKfFFuuKFeLdvDeDYidlI88uaq6Q=; b=Ngky8XEje7RZa4SOO2GnRJV37H18zF6OMqjwHW8PyLTrBsqNXihagqdXGJQkrGgNHq MLYfp7SY04lQwHIrW4PeihmmUb3PnqNS36KHmyndWEWS07TaUvn5c2OKi7rbQg6HbEde LgJImSvRAoRrRt5hEh/DoMQlF8MQtxoSB4uz1wFgHtYPvYBLInXxh4Rl0PsDBpIU6BYb iudbjGr27p7lkscx9afylN79/xOU/0E4ZQX0/rhuObfNtOJpUTQGRVnDerDQQLpA8SIS z4ZY+lEcX1PZW8CuZ7ByoVxbsbWHRxKCViLpqns0Plo8XbfLoOEaPqDNV81/DYdVYdFv VnVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763458582; x=1764063382; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6W+PHyYr6Qrds76dKfFFuuKFeLdvDeDYidlI88uaq6Q=; b=UUf7B0WTHcBgbulNG84kcLySKVRLA4XDjwOWnGnFcLV+qKTHmwxtTr53IBakbNFWG1 nE+3xwMvc/P10YtOpbU2u4X0L2aztS2Olba1NPyVzmkYiMkB4fllbQq0gwnApIN1zKRy XN3rFUvW1Ku9kYfdzcX0qsw4RoY+QkQlGIh0xn5WBVQhpSHl6qUkQpNFElGKZDaLJIvc WjqV8HCD8uI4zpbYr1jEZSWhoRslPTJW/Hl26LWC3UrYzpKmOLOtuRAoINAVy2gChLNW WRldzG5eLT9G4jZ3XqzkpVHl0h0KFayugoEZfJYasmg0QtkYz0XVyzgkr/PqJBm+8InW bMug== X-Gm-Message-State: AOJu0YyVdk1Lhxcol9sYl4NQsbOGDC/MvxghWKJdLYEcBURO+wkU5G8Z iyjrTchFx48sZQHELWllOylIgQpYOtGKXqKIrANrNMG7IRfdvq+UE/kt X-Gm-Gg: ASbGncsqG571Nr2TykLmKnr1ozMGpCQ06mK0wtnW2TjpF2QvEUoFUtYBFCfOPyrOc7Y NZtatcr2JVS/9+7bH9ghIkei1QYS0xyYLWYtm+xk+mjDbWlxNdQItjvYfv/ik0rSnFwwjlbOVkz v9u646+kpXVosDeQxeVIKr+4PGwWPnaJ3xI/Msa4IyQFj1A1N4paWd9KqHvpk7qZqpVismeuRuj 1KGqANY9AzypUd5HzB1rJ5MYJVniTrxYRnymlphpkysq17d1jKImSPNMM1Xy4mmsB2tSt7SssWc NeN+VZyQPbg/A835U0wbB7rsdo3Cn/ErdbW+K9OtdInZZXFAJm6GAWDz1gTkLoNDluZmBxMxKtz QnzFQU8UMCkdQWTQrckaO/vQebQsozH1UQcPp516AdbqCS//H62NTgTruQELgpPdZZIrmEZhMgL tWZMDwuvTSm+3f6fG7kGppdCXLdVi5b9rCfuyY2uTM X-Google-Smtp-Source: AGHT+IHqG1INewWjsbz6C3IMmcBkNzcGqPXPzD0ZPlJWWzQVtsYRHozq94AhuQEBqm2XBSLncqWcCA== X-Received: by 2002:a05:6512:39cf:b0:594:27dd:2701 with SMTP id 2adb3069b0e04-5958426d8aemr5807769e87.49.1763458581523; Tue, 18 Nov 2025 01:36:21 -0800 (PST) Received: from pc636 (host-90-233-212-127.mobileonline.telia.com. [90.233.212.127]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-595803ac955sm3817285e87.14.2025.11.18.01.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 01:36:20 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 18 Nov 2025 10:36:18 +0100 To: "Vishal Moola (Oracle)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, Uladzislau Rezki , Christoph Hellwig , Andrew Morton Subject: Re: [PATCH v3 4/4] mm/vmalloc: cleanup gfp flag use in new_vmap_block() Message-ID: References: <20251117173530.43293-1-vishal.moola@gmail.com> <20251117173530.43293-5-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251117173530.43293-5-vishal.moola@gmail.com> On Mon, Nov 17, 2025 at 09:35:30AM -0800, Vishal Moola (Oracle) wrote: > The only caller, vb_alloc(), passes GFP_KERNEL into new_vmap_block() > which is a subset of GFP_RECLAIM_MASK. Since there's no reason to use > this mask here, remove it. > > Signed-off-by: Vishal Moola (Oracle) > Reviewed-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index d343db806170..d55a77977762 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2699,8 +2699,7 @@ static void *new_vmap_block(unsigned int order, gfp_t gfp_mask) > > node = numa_node_id(); > > - vb = kmalloc_node(sizeof(struct vmap_block), > - gfp_mask & GFP_RECLAIM_MASK, node); > + vb = kmalloc_node(sizeof(struct vmap_block), gfp_mask, node); > if (unlikely(!vb)) > return ERR_PTR(-ENOMEM); > > -- > 2.51.1 > Reviewed-by: "Uladzislau Rezki (Sony)" -- Uladzislau Rezki