From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27CC9314D0B for ; Tue, 18 Nov 2025 09:31:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763458305; cv=none; b=Hx3fg5KdOlNfHtlQo3Luwn075a+eK7dS/wzLfaX5qzp4G0rF37tSuuJRfwHnWOgy/yorDkBd65OvZyJeK9BSPdfNImmtO08ka7nB1fkyu+qjrkie12UFTjOThdFpUsZoSBVO3JyHiOwMMvu4BP97kwTBN+wEV/9DyMs36dTRhEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763458305; c=relaxed/simple; bh=hg7HqJHy/6wXnNtLNKdDSkUJwtD80loCerrYasnmgvM=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MwVR9/8mY6ffOm42TDrz2Z4yHlpbzcJgjcXaDKhZqAJYDBUtygfKyPb4G7C2il7EBcMqfTmKooXSU7XIHFAwLI3wa1E8kZcXUgimKbshVXByaqi7kSAOiXPZhCQldTMIbcIidxLXOdAlE4kNAMMJ7g5kSDQhKvfO0tPxsNEVkHQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ce0dm+1a; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ce0dm+1a" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-37a875e3418so37451971fa.1 for ; Tue, 18 Nov 2025 01:31:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763458302; x=1764063102; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=LfSnUyyR+gHh/pyEYOi6VgVjJci+W/poycFy7JdBT/c=; b=Ce0dm+1aB4axQ9jq8GvIxqbjgydLNxOaQyUEq2CujvaEhJR6SYM0yghXT558aYNjam 9oKzyzKYqyn4p73Wo5qh0pbAWd7vBfBa1XIhzjnc9RG1z+EsR98bHLiaf1tHk7McNIw6 oePbknn1xfFsdLhv7/UGEpDX6W8ynBnuuu0DPUTCFjIGaSb4GadZgA8HWkUPYp+beSi5 tH0rHRerlM52VW4Ee3iUwOzVhFrzOuEMSCmURjC15epPncBEhtsZ000++fWc6Rpu/l8Q Mxqpj8KPgwbCX1u0kyeUV2CD0kiCgVr+uojga1TJpjv6w/iR1FnPhoaK0BhO8Q26CvDa mIeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763458302; x=1764063102; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LfSnUyyR+gHh/pyEYOi6VgVjJci+W/poycFy7JdBT/c=; b=G/1oG5bUwJae0ONS7rkeimH4czCHCXouz+zFt3c15EMdmv2iw/dcuo1mRQPBTwJ7i8 zzIV9B+WaFCcFibB7uZzj+sBJwGuDniTUv57z9RhtkWhEIyCwPe6QP5UCt2hfTygRcKx 1EYy7dHKaonEhvgKILiuAIKjvsNw5380M6wO50H4hjp2yDySFtHLAqDdWa9e0cSK0o/m fusX06zRFV2Qt8shoDAw0XbCreEICLyLVj3Rxi5eosgUx1/go51o9QUiWJ149Eqjgp30 vF1Ni8nL9m8tfvW6NuaL9T2obLEimkEG8jaHIOQT+1tAV0PMjb1c9qdfJPJap9qbT186 S0EA== X-Forwarded-Encrypted: i=1; AJvYcCW+HYUPwBloVpKkFkG6SD2HhDF8AuEjdq2eWhrLbgBA0pUEgHceaxnBmqal7Tb5FiLLIkLcH5MbItclhs4=@vger.kernel.org X-Gm-Message-State: AOJu0YxrraRTBnANvrMy8cp8RySK8uBscQykwt9rcpczBFwupQ9kFSi1 L6ST7x/FL1/uEw3uUd3Sg4QAfDpTGGlOwNVZFt/HHnL8bAdYnWQLvd2E X-Gm-Gg: ASbGncv6gFPuZTVQ4potolvO0v/AXEdFueX7RpFift0Z0ENk5i3cfWN5nHDJ5ZOFvOS wNNl2TsBVf0evDsRVqZ/ANtysIOqGF2ZjeRFPhSBCXCWH3jW0h8Wk1kve4r6AEkkqq7ZFbGlY/U NVBDIOHYMx3GAOKYjSw6gXkAhZbbopoe/wj8jNPDSpFw9WNQlqIYGglfIgcgmMeYggIZi4t3due 4SCJXPUcrLm69jsN25N22N7ydaNSMWGdBXtdKd4RDvNWxLHVnqxqjCI4yCIQ3PVd4p3QLPbYHce SNOluuS9v5QCgHZjMdtBcmb6E2OZn6I67lgFj66PRl79XNabWi10xBcccuuBnwTazodkH03+V1E QYL10SZr1+RG0rovNW8chZ6IOYNH2aPSumrqqvlgffYg= X-Google-Smtp-Source: AGHT+IGnlKspAS2We2FABx815t9bNQvFsXJy6XwUcpIvRdQFlzF9XlXS5jEyZ/AKjBb0WZzRlZkYAg== X-Received: by 2002:a05:6512:3b0d:b0:594:314d:ac53 with SMTP id 2adb3069b0e04-595841ba374mr5520844e87.23.1763458301885; Tue, 18 Nov 2025 01:31:41 -0800 (PST) Received: from milan ([2001:9b1:d5a0:a500::24b]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-37b9cef2bb2sm34960441fa.46.2025.11.18.01.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 01:31:41 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 18 Nov 2025 10:31:39 +0100 To: "Vishal Moola (Oracle)" Cc: david@ixit.cz, Andrew Morton , Uladzislau Rezki , linux-mm@kvack.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org Subject: Re: [PATCH] mm/vmalloc: warn only once when vmalloc detect invalid gfp flags Message-ID: References: <20251118-only-one-vmalloc-v1-1-29f8eacb4605@ixit.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Nov 17, 2025 at 05:16:45PM -0800, Vishal Moola (Oracle) wrote: > On Tue, Nov 18, 2025 at 01:05:57AM +0100, David Heidelberg via B4 Relay wrote: > > From: David Heidelberg > > > > Without WARN_ONCE, the logs get spammed immediately after the boot, > > on devices as OnePlus 6T (Snapdragon 845). > > > > Fixes: 7179b2256315 ("mm/vmalloc: warn on invalid vmalloc gfp flags") > > Signed-off-by: David Heidelberg > > --- > > I'm not 100% sure this is the right solution, but having WARN_ONCE or > > rate limited warnings here helps a lot on devices as OnePlus 6 (sdm845). > > > > Please let me know what you think. > > --- > > mm/vmalloc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 49e0b68768d73..2a3ee17093d6e 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -3934,8 +3934,8 @@ static gfp_t vmalloc_fix_flags(gfp_t flags) > > gfp_t invalid_mask = flags & ~GFP_VMALLOC_SUPPORTED; > > > > flags &= GFP_VMALLOC_SUPPORTED; > > - WARN(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n", > > - invalid_mask, &invalid_mask, flags, &flags); > > + WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n" > > You accidentally deleted the comma here. > > Once we've found all gfp the callers currently use, we should never be > hitting this warning, so ratelimiting won't matter. Either way is fine > by me though if you still want to fix and resend this. > IMO, it is worth to use ONCE variant to suppress spamming. -- Uladzislau Rezki