From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB9E33168F1 for ; Tue, 18 Nov 2025 09:35:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763458516; cv=none; b=cJ5uzlPZr63FIt8knCv49KVzKMzn1K0DRTSUyn6IYgSO5MoIdJbS/5A6Tu3btTb8TN7amur01sAUt5XhT7gscVswCp8CWYTsjncy36s8BE0E3kn4021HbCcni8eCpmQ3SklmuW1eVVBOM4dC9AzKzimRqieMUFspuMFVKycywEA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763458516; c=relaxed/simple; bh=NkZaaxDPId7zFBcud2FRpEytYE8UzEeNgevbakrWZJg=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IynzSnJ6ULytfoERBpZsHebw44Fp0Q+gHqsNsaL+vvAbqw9ux0rqZWzcnFZRpkOMcMSzx5kf56AgK13+BFIxW1fdGv+8N+wVCccoFyL+ZwfpzKdaLRp/zkP5tEQJeIShjwY48OFLHexZwQseZWnPR6rAsvNn44oZPZVYggujPZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DytWVwPT; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DytWVwPT" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5957ac0efc2so5784722e87.1 for ; Tue, 18 Nov 2025 01:35:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763458513; x=1764063313; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=aHMdZCOCGbX2O155/NUOCcK4115xr54Ob6gQNzq7blw=; b=DytWVwPT2Dv87+5En/jeANlIELE4nzZ/wsz/YyiQc2YC8L7iyqliAntaMDGD3bFCiZ 7SZA+OFt9eVr5G5vpkhyWfnB+07EAb9zMUNYTESGQnpfQac+QeO98VylGv7wSNZKjIbB a7arsryV8VlDBCc2nUMtroJ8NTgxUVBFr215YePeiLxtQ4Jjpc5MRB71kHwp27ORiMIY ydQB9LZSRrthXue7LpYadqOEf/t9my3uaJa7XU+M2+4qdQFpeBldfO5Q+pMEYHhO3oC6 5OJ8WlHbbu/UL2GqH1AsWRHzpMeeudekldmyDkwJv6IFrzpnsfi4nnX6Sz4zVmQlfLA4 0ldg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763458513; x=1764063313; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aHMdZCOCGbX2O155/NUOCcK4115xr54Ob6gQNzq7blw=; b=KGV7YJIfa2YjxcZxzj8J1iQ2lNRWMG5RW1iAkZL32pNXB1turgr/ydaqcXOsaEJOgw 7Is2pxDFkVKfrjwj8UWslVrQ+mtvIiIqtdxplzRbIGQrMZjtfGNpblQ1/66a7KE4PJ3g EPAZPiVd06V3T+T/tBazTmBzf0jUWcFWQlenAIjUCA3B0Rhkt403+Gf1NcxitjWmkpcD pJZ7tW/QOHlXYFbAxTjGygYFS9ol00VVeHk4BFv/jAn/Nq4vV4GL7llP0BiyV1X3BT9q RP9wGASj/lgSwGaEwniHS6/WKl4+STcBu88wxM3BoFq1HlM7vwZtKihQY5I/KBsE/S7u zqRw== X-Gm-Message-State: AOJu0Yx6pdGjp7ZBYunp/Pd4P9EJQXU3Avd7zGpvAhnfwdp3FHvJVldq IkFwm5C90pglHisblDRO9mxxIPmdCqMWTsu/tTnsIcKaF4JvtKXwMjbE X-Gm-Gg: ASbGncsl33Is2AAFdoDwK/AfTZJ9dm5X907WetzQDn/qyt8c7r/Md/u29hAthTC6VtI /rP59JZJFNVpsZEQ1JqHIJAeQqpSTCZMjVS3damxtfDYdMXz3mJpz5/uVFy8/zVfnuEFGujrpFt /DjjgXT1B7YSQas4W3jJPhHaRYvMCd1mFYkwRGP4CW6YUOBpdxv8XQJVBuFXUNuji9Oqz/MLqXl a+JyxMg36t2bXI7PJ4aE5DbuELZqz/xUxP3ajV8dTbtvKv0aM2g59XiLOVqBaSsYhYF3rrbCYvb Z6xZk1UD/VJj7KcRXGG7+WAqFn3F6elmTYxhqHfoZn6hi4FqCx8HphztVFUZXtZaAWkEdJvGsDd 4Mpdk1DrsT+QjdKoKVETuWWc5uTdvaqbyKAmqwcKEoHe/O/UeW1o7CarL4CYPLHE6pEakm04fr0 ubDUPtbfhN9b1wjDs+9bmyT3DXWod3BA== X-Google-Smtp-Source: AGHT+IExm5aC89xgarQdyothH+dB9CzoUQ8H+p8Qx06g62Zn9Tjz5qsjq3/+2wKJFAz0pDGkZ+oHrA== X-Received: by 2002:a05:6512:3d21:b0:595:80d2:cfda with SMTP id 2adb3069b0e04-595841b4e1cmr4374691e87.13.1763458512596; Tue, 18 Nov 2025 01:35:12 -0800 (PST) Received: from pc636 (host-90-233-212-127.mobileonline.telia.com. [90.233.212.127]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-595803b3050sm3774175e87.27.2025.11.18.01.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 01:35:11 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 18 Nov 2025 10:35:09 +0100 To: "Vishal Moola (Oracle)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, Uladzislau Rezki , Christoph Hellwig , Andrew Morton Subject: Re: [PATCH v3 2/4] mm/vmalloc: Add a helper to optimize vmalloc allocation gfps Message-ID: References: <20251117173530.43293-1-vishal.moola@gmail.com> <20251117173530.43293-3-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251117173530.43293-3-vishal.moola@gmail.com> On Mon, Nov 17, 2025 at 09:35:28AM -0800, Vishal Moola (Oracle) wrote: > vm_area_alloc_pages() attempts to use different gfp flags as a way > to optimize allocations. This has been done inline which makes things > harder to read. > > Add a helper function to make the code more readable. > > Signed-off-by: Vishal Moola (Oracle) > --- > mm/vmalloc.c | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 5dc467c6cab4..0929f4f53ffe 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3614,6 +3614,17 @@ void *vmap_pfn(unsigned long *pfns, unsigned int count, pgprot_t prot) > EXPORT_SYMBOL_GPL(vmap_pfn); > #endif /* CONFIG_VMAP_PFN */ > > +/* > + * Helper for vmalloc to adjust the gfp flags for certain allocations. > + */ > +static inline gfp_t vmalloc_gfp_adjust(gfp_t flags, const bool large) > +{ > + flags |= __GFP_NOWARN; > + if (large) > + flags &= ~__GFP_NOFAIL; > + return flags; > +} > + > static inline unsigned int > vm_area_alloc_pages(gfp_t gfp, int nid, > unsigned int order, unsigned int nr_pages, struct page **pages) > @@ -3852,9 +3863,9 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > * Please note, the __vmalloc_node_range_noprof() falls-back > * to order-0 pages if high-order attempt is unsuccessful. > */ > - area->nr_pages = vm_area_alloc_pages((page_order ? > - gfp_mask & ~__GFP_NOFAIL : gfp_mask) | __GFP_NOWARN, > - node, page_order, nr_small_pages, area->pages); > + area->nr_pages = vm_area_alloc_pages( > + vmalloc_gfp_adjust(gfp_mask, page_order), node, > + page_order, nr_small_pages, area->pages); > > atomic_long_add(area->nr_pages, &nr_vmalloc_pages); > /* All pages of vm should be charged to same memcg, so use first one. */ > -- > 2.51.1 > Reviewed-by: "Uladzislau Rezki (Sony)" -- Uladzislau Rezki