From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B87DF34E764 for ; Tue, 18 Nov 2025 11:08:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763464089; cv=none; b=P0/nrBo6pV50/cBVc6xAI1gMgpnybHYm1XHyiXSRDN+8l/YvZy2rhAQdy1QZKPCWVlmcXrD/Dzax+UOcOYpYHRRMiUP9B2h6NrKJcHYoPG5to3AI07BEfCgelyAAfCi0SNJyvKjgnYebpCrctnVsFsq0HoX0B5H44d5K1XiY/Mw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763464089; c=relaxed/simple; bh=GV8FQ3eNIT/+xB7w7ijUUdGhF1aGprfG1JgLRmP4eE4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=saoPcYQFXei5Eeu2+gqqDeQ0mbmffgloHYRcpop6ZBQKvRu86pOyVvOyTeQRXZUoXeaNn7rUbhUI1nJLooXxcMvSnOBhfO3sj+cd1Jxp5biJhQSe4GZv++P1L6KcpU9kBcC/VGmLppjZWIPeebyTCQTVjDzDikAYUdcw2RFRmzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RavKYT+x; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RavKYT+x" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-477549b3082so43991225e9.0 for ; Tue, 18 Nov 2025 03:08:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763464086; x=1764068886; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=N98Pe1e5VEGFDBS/VZ7pBrHXW51O5Y7q6gPyvhlhdfY=; b=RavKYT+x78zFH9F20sLRYLxqaVUMNL8vKLO6ZwNrVDbVfbwaOawvyZnUD4S5cnzwKp fbYyWcxo928bADoUfvStVXrdvTb5cvKRyEO9bLoV6m419oYpfjYkqs1+V26hc1ccKR26 XgjA2lgZ0wa5JatmWM3V16t9khLMsnr4Ea1cOmCLzW2s78ofeTLMKye+vlBOOsXYht5l Bnuzx02moCj5s3aithrgZMUiuuV0EAZhFNkNIwL4rDC0J1sFTeZA2mfPFJ9zZb26I8mw i6OcApI0oZvbNYzaH7FFMTbqmjKiFksDXbvy06WyXK+9yyfxLPyunk66HAOaUnONcIzT ex1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763464086; x=1764068886; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N98Pe1e5VEGFDBS/VZ7pBrHXW51O5Y7q6gPyvhlhdfY=; b=oxJqQkbrWGFG4SRWyrhpiSKBaHGO9iASCTh970xuwLSf9sm2OEWsSeLB33i5VOVA/A V0KKcMe2nGKiICB5i+M+o2YYCEZoXgm7TvzXLIJJAhNpYRYw5T3lsLRlKKcOTET/2W3R hwPamOH8zawc7n5dVRDq2L811JgVRQYtqiBS56LjRwgpP5jomckJ3hSqTjJgNBa2j70d ZBR7dYgGH1sQzdXXvGM3mmc5Ll/Ta+Ud3HW+g7bwVJ2AQMR7LAPKTgD2vj79sFuPEa31 nsaJ/ijTrzmwwdYIh2rQiqnFF4SM3jrckiy2th6QCgpYOngLc/WE9HXgaUEcLoE0Dzwn eLRA== X-Forwarded-Encrypted: i=1; AJvYcCXtbJTTahYcSVp2Wtnd7T/zW3cj9kdZFyW7NqxHOnf010fc67QGQw2emv8XaViOKhrBqI4OvjD2uKCrz5k=@vger.kernel.org X-Gm-Message-State: AOJu0YwB5ZDUmS03l+bQU6q1qGAeib6wqEJKHQns/YoruTFq8WYyzUSJ 84Ntjc8BF+9Wu8gH+KSGEz7jG4NFq0g/4bRzTCu17j34iBXgeiMZ3Qan X-Gm-Gg: ASbGncvrR9GA/qPT1fQdZVhrctkRxTQ5sc5EqyYr8H8k2/WJzIlSOw/aVp9wyWyzj+F atYj/g6tQO4Cvgt6TCPIL8WQOGaRVZEaosXkOvLywkb9vq8LOe7rfGMWq7ZkJeEwIlo25ziJ6XU pYqNEtXI9ohVEivygTnWCC9JUxagl5X+YAQStsv7bO8tpIXIlQKO8OH9F0AaC7WOgxuC8s5+xbE CFiwNH4qfzNM+YlUusVwDqvj8JCwbypUe06VSlTwexdkwXmC2VLaktkGiILJA/aTPCFUOVxbLsn 53fWkbquJear3KLH0ciokqGCFOQrpVp9vyBtpbJX7MoN7z+g4u16rNlSNmGsJKLctv7tjWbXaEV dc1dvFd1zHk30+V0xBswCj7nYHN7UVVgGr4sERRXBHScFrvLfURTTvT71BwA8dipf+kyP/F0/Mc 6mgO5UXjM7zn1iXyqI2+4G5cRVhQ== X-Google-Smtp-Source: AGHT+IHhBQ+SOW9FB+mUYjIqlnhQ8s3Igj2q1Qsqq1WrBjrlDkH+ap8ORZ1KcYn1dggyWC/R4J+11g== X-Received: by 2002:a05:600c:1d19:b0:45d:f83b:96aa with SMTP id 5b1f17b1804b1-4778fe51e63mr136760215e9.7.1763464085764; Tue, 18 Nov 2025 03:08:05 -0800 (PST) Received: from google.com ([37.228.206.31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f0b62dsm31625842f8f.24.2025.11.18.03.08.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 03:08:05 -0800 (PST) Date: Tue, 18 Nov 2025 11:08:03 +0000 From: Fabio Baltieri To: Andrew Lunn Cc: Heiner Kallweit , nic_swsd@realtek.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] r8169: add support for RTL8127ATF Message-ID: References: <20251117191657.4106-1-fabio.baltieri@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Nov 17, 2025 at 08:37:41PM +0100, Andrew Lunn wrote: > > + if (tp->fiber_mode) { > > + phy_remove_link_mode(tp->phydev, ETHTOOL_LINK_MODE_10baseT_Half_BIT); > > + phy_remove_link_mode(tp->phydev, ETHTOOL_LINK_MODE_10baseT_Full_BIT); > > + phy_remove_link_mode(tp->phydev, ETHTOOL_LINK_MODE_100baseT_Half_BIT); > > + phy_remove_link_mode(tp->phydev, ETHTOOL_LINK_MODE_100baseT_Full_BIT); > > + phy_remove_link_mode(tp->phydev, ETHTOOL_LINK_MODE_2500baseT_Full_BIT); > > + phy_remove_link_mode(tp->phydev, ETHTOOL_LINK_MODE_5000baseT_Full_BIT); > > An SFP module can support baseT modes, if the SFP module has a PHY > inside it. But it could also be it is a fibre module with a laser and > so uses 100baseFX, 1000baseX, 2500BaseX, etc. Right, so for an SFP NIC would you expect ethtool to report only the modes supported by the module? It'd make sense, like right now I'm testing with a 10GBASE-SR module but as it stands ethtool will always only show 1000baseT and 10000baseT. > To do this properly, you need to be able to read the SFP EERPOMs > content, to know what sort of SFP module you have plugged in. Then you > can list the correct modes. I see, unfortunately all I have for this NIC is the out of tree Realtek driver and it does not seem to implement the API for reading the module EEPROM data, and there's no datasheet available, so I'm afraid that either the Realtek folks pick this up or it's not going to happen. In the current state the driver matches the behavior of the out of tree one, which is to only report 1000baseT and 10000baseT as supported, which I guess is a good hint that that's what the user can set the card manually at. Are you suggesting that I should change this to do something different? -- Fabio