From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3943350A17 for ; Tue, 18 Nov 2025 11:39:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763465951; cv=none; b=OpIQxZ2yCBYxxuOnJXFEyKk5NpuT2it3h4GX1xoMvUTSPtX/AclKIltH+QF+YwqU7dNNrWMf7p1cFyfCfxnwS1eBgf1xD55DZX965fIMDuFPkGvk9OTj1dklIM1jJ5gAW+eFxuhoZooCcLzERZ6gUp98ndqAB0rpqzPJtnhCUKQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763465951; c=relaxed/simple; bh=lstkbu9jeYEj+mqjxq9BNsch8aP/MpxnagJpphhbA7I=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GYOE6UDBUbsOhX5cVno2/kZsLV5Yboo1Nj2C1YByyw0ffYMb3TlvIJUt22r9V5zUpKqz9PN4oFYY/+yWMh4XDCHJP0scDEWuDcLsB53izRo3uTuXzpEgPtObjsTPVtmGFR0ucG7t1GW3Nju1SOVQ4tUpIQQgS7N6BsTlh2ljWqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AGM68Pei; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AGM68Pei" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-594285c6509so5563808e87.0 for ; Tue, 18 Nov 2025 03:39:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763465948; x=1764070748; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=rlTQClVvmrzgofylmc+Uoi7ksLdBMhV5f6NzAqw9ixI=; b=AGM68PeiS7VqQLocDd3Ktuyvtzo0tIXNrZTeqMfocWxEj/R2T+ZlVV19Io6cfNg8wx E4E5CjWJR4pFvGNkCCHMn3+S7msQ9HZq9hJ1zSZQRq/FS8aAiiUKNe3OTe71pjCUL4E3 peGvvRLLhrDPIXqEGMYHuCCFVUJEHeqlln51hBzkPMhKj385RQRqOK/gohtDqhH8dgHh xvfqXAmXbAsCw90m44KdnLjGfR0RWGkIYQWcPeHohpJi3QPpEixqOSWEtcwV7XhnckmQ iCrKe9UoCvfzfy3Vvyi2XyIWWdzT3PGRTo4+qx9S/bRHux3kg89betAAZ5u8y+A5WGOI NgOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763465948; x=1764070748; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rlTQClVvmrzgofylmc+Uoi7ksLdBMhV5f6NzAqw9ixI=; b=WX405W/yeBx7IZ+8H0iGY+7EtuO/LmZO/UlHsNVv8Lrhx+aGDjY0oI9/APs5mEHEni k4yAtAnxIRTjlGvVMJAL8LRIQbi1W25o4+QwZdv6FtYP0/b0jpeWubV0m6XoSMg/Jc4D atY+A3K+UrE/N77Zx+hWZWkhrQMkWFqex4YmGUppDDDAchOsg7RtOGbzmIKdGy4P/+fn azzxs50zKgMqMxDzl1FA9cHgm+DtLnn1bT1TfZ2mbjtM2j9nhlrSUFLmJbysrKYUZGpA CgXCOqV4TFVEeDhwNyMtbeocpmnzW0qrluoT3Wn0SFlHWuF6rjybXIRp8twHpb5VMkiz psiA== X-Forwarded-Encrypted: i=1; AJvYcCUVJmUeV7V8AI6HYl/YYfCpTsUsaliji7FfKO370WySNJx8oLI+9RiiJ1z3Y0Sa4ATlSnnspWQH6EYLK8U=@vger.kernel.org X-Gm-Message-State: AOJu0YyKEd3GuQdN/lJ0XuwC7S73gMeis+jO2BQPj1LtELSS9AWARzW7 ZdgbtAQoCA9P6Vn54NmwMdHLsm1WBE3BmWNzeF63QqE9aZl8PBGPFx3h X-Gm-Gg: ASbGncu3fK/4gI1tGbMXLnMIBEusmzgj5QJQnrzvIOIKMITdlh6M++XGJoN6KL4rF2U ZhGh8IEw1xcD7bOTofCj7tHLU+XhoXGGrjDvfs6qBaJG5dcQI2eJpHLfD8PlqrZROkYOi3vzkn6 OYA5WmbqeVaZ5fDZbwOaVyjw05w9smVOze3TSn97p6yxY/pNaCYcNeezlRZ8TubFIxuqOQ2hV7z 8ZGTrbAj4fNr83qKEc5Zo243oUSX/gl9EaTJGkhhPbFOVqeRVXZQ5G+cLU1zZ+YonJHki/wM+RS fGfNTmibIVVmxPT6QDHUKvPTDNdJVChd4bFvVkRlen65Fy6lIeflgaQNXYUNopag4M3H/myQ4Ke zZ6Z+VcOowaHpY2mYQNOe5M3WUgV+3tLDiFvPQF7C2YHcYhbPxgVbGKXRfY2coKX7pwf8j+ui8P 6w/lNxRVs+yh++xB319goN1mPEUMO+mQ== X-Google-Smtp-Source: AGHT+IEKGD7PXMBcM20Woz6ev9FO4W8dNz70vLMNsY0OMuwWIAFzfu3DdhtYGT13nMWnijRMcLW3JQ== X-Received: by 2002:a05:6512:39cd:b0:594:4b55:d2dc with SMTP id 2adb3069b0e04-59584217be0mr5431052e87.47.1763465947450; Tue, 18 Nov 2025 03:39:07 -0800 (PST) Received: from pc636 (host-90-233-212-127.mobileonline.telia.com. [90.233.212.127]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-595804004b5sm3919144e87.64.2025.11.18.03.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 03:39:06 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 18 Nov 2025 12:39:03 +0100 To: Mikulas Patocka Cc: "Uladzislau Rezki (Sony)" , Alasdair Kergon , DMML , Andrew Morton , Mike Snitzer , Christoph Hellwig , LKML Subject: Re: [RESEND PATCH] dm-ebs: Mark full buffer dirty even on partial write Message-ID: References: <20251117105945.10179-1-urezki@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hello, Mikulas! > Hi > > What is the logical_block_size of the underlying nvme device? - i.e. > what's the content of this file > /sys/block/nvme0n1/queue/logical_block_size in the virtual machine? > It is 512. Whereas a physical is bigger, i.e. my device can not perform I/O by 512 granularity. As for virtual machine, i just simulated the problem so people can set it up and check. The commit message describes how it can be reproduced. The dm-ebs target which i setup does ebs to ubs conversion, so the NVME driver gets BIOs are in size and aligned to ubs size. The ubs size corresponds to the underlying physical device I/O size. So your patch does not work if logical < physical. Therefore it does not help my project. -- Uladzislau Rezki