From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22B9831076D for ; Tue, 18 Nov 2025 12:42:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763469745; cv=none; b=G9DQSgYwwokv1JclZB1uUxfUdF0BpvgVSDxVPhbze0J+F+lhDXLKX2cVmise6fHoqYIuUR7t2HEaV1oaMWgVvYzUzb4SK+i3n3/X6Uy7X2e9URbBRzvpPJPMZgH5kr5f1Hm3askL3LxDVjKoIV9zWXSCFIc944bgjCWOWMcAk9Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763469745; c=relaxed/simple; bh=A3eWYGUg+9NlLdRkr4jNbQw1dciXDZqc9zalybbz0iY=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g0Sr8tu1KbespoqNHP35fMTRkiUEQOU3M4qNuhhWm5Jd8qslygAhVzWQ1u1oNLJPD9wzwTyYTx5WVVrlMnYb3SxS4ujehb1/uogtxgcGKVeyMETv+0f1bQ4nkiSiHVCkat2uE9yw5zlKvEC/UPLn1+I3xIpTgNdKn59+roL/DzA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JMMoR5Uo; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JMMoR5Uo" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-59590eef553so2426561e87.3 for ; Tue, 18 Nov 2025 04:42:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763469742; x=1764074542; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=QtA2omCvhhC8MI482XxJZXb5SFEBTy+qnOK3gJGQ5Ak=; b=JMMoR5UoHEsOnOtW+sWk5bhG7i0RHs34RPEq5VED++iPDoTdrSITyEgQ9yMGnVymxo QF5N2gY8tjwZxkBBIL//c4XxlIzd7MGaOBVS0lkLdKE9DpuHTr3NTeIrYDu9YbxEFIFF pOlaMhnHTH3A+NTgypecSLWRdK0Qd13XItmne9KxMfgXMYmmo4TISKkKCGXiqC4HOlxv vlrK+JMDFqksEHnONmA58cSROWt1l9iKimwe2BjAvf2mTCgOLpxngQTGdUunAW7O4qj9 oAynvZzvzy2VoH9ZkH3NgYPVBX+hwF09fZ/7uQfRJy8zW89OoeTkxQZZeuDDYicPfeNs op8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763469742; x=1764074542; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QtA2omCvhhC8MI482XxJZXb5SFEBTy+qnOK3gJGQ5Ak=; b=aGzZLeEXMgv6DIRYLyDf+7Djz0QgXxhqwh3otC1vY4wUB8kK/pQJDVZEqPelXZTUy4 0JdnfrrVcq5lOtSMjA1RmR7yHVSoC5p/Vc5qI1A8MkC/Qg0HYA62dimejylNxL4edTN7 +RcW4jqK8UZpMAHHP4NFQx7hHFYIWOjWoXiXc0LZEMFLClCC1+gihsnuNTCQi7Uxb37y GT8XQiCqyyth/S33t8htlt1kpEmOCv5K6k9R2+rR00yxntk0yoifFzCBYXMUWTTbml+g 7L4t2H3zY243AKqMyMJq3swcoqP3xahkFzGLRZmOemTPpnQlhQlI2IDP+mSmI3Tlhjpb /r0Q== X-Forwarded-Encrypted: i=1; AJvYcCVfn8kRtOn1OR1qpDI1d/zWnsry033uw6kOxMfpTjXSX68DziF/RI8bn333Zv6Ycr52PMWAqSEfu98IIXY=@vger.kernel.org X-Gm-Message-State: AOJu0YzDUVYMz3nambv74bJXD5jBmz3LWXedM1E+zkrL/CnFp/v4VuYb qv/OXa4mRm5TSWrkfACnctnFSS7gWnhskJN8S6Oe9wNC6Vr+G4tMaxoOXhh0SBpaWB4= X-Gm-Gg: ASbGnctlhNQ0sC8ZVaSOPxX7osftJfmvXE9lPk7T8hMo7MbdNBLCb3/FRiqvFYwndFl u1IfTAD9YshSfD+8/sUJc1TW+YNXr6KmAWgh1L7L5gi1jZ0Z99UBETYmerOfzIwvc9vllvEN5oZ 3WrvH+6PKY7zVfgstZu2dqcjZbGYBwHsC7zMA7FD8L4XFLxqSRjQwUWBbCFszbSsi4ktFBn45Pa Si2iP2aF3aguQD60V5zs7rAybYdJx8QIFukSg0uHrpFWBs8fBT6SkOtY9KejYJspGA4bAjp4+v8 TvWGMUm+TEfeoC9LSTPUX0z5na8xj5aQl51/V1BmyWYcMJ9BuvzX8Yo06M6sJ2R6pWdZIVzv9NP sx8QjOuLfisR37rgMWzHg209zD/2Z+VfJOtptpjbiW/880bfXC/JzpQ== X-Google-Smtp-Source: AGHT+IGadafoNdv8/E0ZXL0/MLxqF9Z9U2WdLWVoJ2s3g+20bFpVmRKZQjaatRukyCnlMqHf54sjLQ== X-Received: by 2002:a05:6512:228b:b0:595:90ee:f480 with SMTP id 2adb3069b0e04-59590eef813mr2968394e87.16.1763469741951; Tue, 18 Nov 2025 04:42:21 -0800 (PST) Received: from milan ([2001:9b1:d5a0:a500::24b]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-595803b2e26sm3960903e87.24.2025.11.18.04.42.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 04:42:21 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 18 Nov 2025 13:42:19 +0100 To: Mikulas Patocka Cc: Benjamin Marzinski , "Uladzislau Rezki (Sony)" , Alasdair Kergon , DMML , Andrew Morton , Mike Snitzer , Christoph Hellwig , LKML Subject: Re: [PATCH] dm-bufio: align write boundary on bdev_logical_block_size Message-ID: References: <20251020123350.2671495-1-urezki@gmail.com> <3c6ecb98-d574-9d75-a23c-fbdfa09428bf@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3c6ecb98-d574-9d75-a23c-fbdfa09428bf@redhat.com> On Tue, Nov 18, 2025 at 12:15:43PM +0100, Mikulas Patocka wrote: > > > On Mon, 17 Nov 2025, Benjamin Marzinski wrote: > > > On Mon, Oct 20, 2025 at 02:48:13PM +0200, Mikulas Patocka wrote: > > > > > > > > > On Mon, 20 Oct 2025, Uladzislau Rezki (Sony) wrote: > > > > > > > When performing a read-modify-write(RMW) operation, any modification > > > > to a buffered block must cause the entire buffer to be marked dirty. > > > > > > > > Marking only a subrange as dirty is incorrect because the underlying > > > > device block size(ubs) defines the minimum read/write granularity. A > > > > lower device can perform I/O only on regions which are fully aligned > > > > and sized to ubs. > > > > > > Hi > > > > > > I think it would be better to fix this in dm-bufio, so that other dm-bufio > > > users would also benefit from the fix. > > > > This looks to me like it should accomplish the same thing as > > Uladzislau's patch. But I think there could still be problems with other > > dm-bufio users, for devices where the blocksize is larger than 4k. > > Yes, but Uladzislau said that this patch doesn't work for him. So, I > suspect that he has "logical_block_size" set incorrectly. > Indeed. Because logical is < physical in my case. Your change does not fix it because of I/O size is equal to physical. -- Uladzislau Rezki