From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>, Jonathan Cameron <jic23@kernel.org>
Cc: "Christian Bruel" <christian.bruel@foss.st.com>,
linux-pci@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>
Subject: Re: [PATCH v2 1/1] PCI: stm32: Don't use "proxy" headers
Date: Tue, 18 Nov 2025 13:42:25 +0100 [thread overview]
Message-ID: <aRxpsc02hGW1w_hu@black.igk.intel.com> (raw)
In-Reply-To: <20251117204348.GA2522408@bhelgaas>
On Mon, Nov 17, 2025 at 02:43:48PM -0600, Bjorn Helgaas wrote:
> On Fri, Nov 14, 2025 at 07:52:01PM +0100, Andy Shevchenko wrote:
> > Update header inclusions to follow IWYU (Include What You Use)
> > principle.
> >
> > In particular, replace of_gpio.h, which is subject to remove by the GPIOLIB
> > subsystem, with the respective headers that are being used by the driver.
>
> Thanks, Andy! It looks like a lot of work to figure this out by hand.
True.
> Is there a tool to figure this out? Maybe something I could run when
> reviewing patches?
I have a déjà vu answering this question. Was it you last time who asked
the same?
The tool is iwyu which is heavily tuned for the kernel use by Jonathan (Cc'ed).
But I do it manually.
> IWYU seems like a nice principle but I couldn't find any mention in
> Documentation/. Should it be covered there somehow?
Perhaps. Maybe we can start with IIO, where it's a highly recommended thing
for the new code submissions.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-11-18 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 18:52 [PATCH v2 1/1] PCI: stm32: Don't use "proxy" headers Andy Shevchenko
2025-11-17 20:43 ` Bjorn Helgaas
2025-11-18 12:42 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRxpsc02hGW1w_hu@black.igk.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=bhelgaas@google.com \
--cc=christian.bruel@foss.st.com \
--cc=helgaas@kernel.org \
--cc=jic23@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox