From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from casper.infradead.org (casper.infradead.org [90.155.50.34])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40AE9226CF1
	for <linux-kernel@vger.kernel.org>; Tue, 18 Nov 2025 15:11:52 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1763478716; cv=none; b=WOe2gfaDRLeOgXIgI3hws5Ej+zA3kZCBB+eDNSpM7ngY6e7HCY8qqwYZHgfGXezyyNGdBp3OXS0sPLV5jI4xc2ff/oIhQ3l8xcG9XqC85z8+lBAwyZe0wYXMuYZGu40ceQrczxoM3y+P03c7x8vqdbFkDc+kEg30mJAgDDu0NbA=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1763478716; c=relaxed/simple;
	bh=7BCEAy3OSNjTWJoVt97d6yvCjQL/R37WK1j2bBCaObc=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=LIukzf5GRCO++zE+McrpBPOjucvFWow8wY1A/rLVTagrS0Wm+2BHhfnNn9qcBAW33JyM9kVxPH43FdGCgTtKhmvIo6GAEVaewCxvyYWj6QonR2OX5sHoTpH9qXYT7fpvikSaGf2QQimQRMVTPlDQ5knpfEryPPLY3BCmY43WyNQ=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Fnby0e8v; arc=none smtp.client-ip=90.155.50.34
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org
Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Fnby0e8v"
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding:
	Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:
	Sender:Reply-To:Content-ID:Content-Description;
	bh=oVir3zPsjlngDgWc+1KJ9Rm7ynvdK1im714lW669uUM=; b=Fnby0e8vWvUc4/1n0tiDIDaVdi
	1qYtPPcT0nQqkCghlZJUTpcsvf83CoayKIT+kTnm0sMHBOMukrCcmbrpxz3fLio9t9qoHK39foL86
	RTipcuFOc1y4BpLNns/26QlbB5JwLGU0Q35aEfxkTeYXpw4KoOvsa+ntvIbLQvqVjctxPRjhcPIjB
	ZtLM3AnUhcNc7m841Cm6EfeuyW/tiI6em3AS0jQtjD01ouL4JMcDfMf3+k4aBWgI8F0XcxXl4ACVN
	fH9VAUy4DTZng0OMrYdzWOPLN/fY9LoXl+TcqHIZSRuKRTwQjAmxM3OtW0I5UPnzP0gNrZ8NRbyVK
	7SaNPJOA==;
Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux))
	id 1vLNMx-0000000FeMT-0yXu;
	Tue, 18 Nov 2025 15:11:47 +0000
Date: Tue, 18 Nov 2025 15:11:47 +0000
From: Matthew Wilcox <willy@infradead.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Sahil Chandna <chandna.sahil@gmail.com>, linux-mm@kvack.org,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Axel Rasmussen <axelrasmussen@google.com>,
	Chengming Zhou <chengming.zhou@linux.dev>,
	David Hildenbrand <david@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Michal Hocko <mhocko@suse.com>, Mike Rapoport <rppt@kernel.org>,
	Nhat Pham <nphamcs@gmail.com>,
	Qi Zheng <zhengqi.arch@bytedance.com>,
	Shakeel Butt <shakeel.butt@linux.dev>,
	Suren Baghdasaryan <surenb@google.com>,
	Vlastimil Babka <vbabka@suse.cz>, Wei Xu <weixugc@google.com>,
	Yosry Ahmed <yosry.ahmed@linux.dev>,
	Yuanchu Xie <yuanchu@google.com>
Subject: Re: [PATCH 3/3] mm/zswap: use %pe to print PTR_ERR() values
Message-ID: <aRyMs5JrQDxmQHJN@casper.infradead.org>
References: <555cdbea3a51898e4c84fdc0f444dae0c2e20f24.1763227530.git.chandna.sahil@gmail.com>
 <c5f92735-0e2b-48e7-9181-04bc058c0bde@web.de>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c5f92735-0e2b-48e7-9181-04bc058c0bde@web.de>

On Tue, Nov 18, 2025 at 02:20:59PM +0100, Markus Elfring wrote:
> …
> > +++ b/mm/zswap.c
> > @@ -749,8 +749,8 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node)
> >  
> >  	acomp = crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to_node(cpu));
> >  	if (IS_ERR(acomp)) {
> …
> > +		pr_err("could not alloc crypto acomp %s : %pe\n",
> > +				pool->tfm_name, acomp);
> >  		ret = PTR_ERR(acomp);
> …
> 
> Would you like to reduce the indentation for the passed parameters?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.18-rc6#n110

That is the exact opposite of what this suggestion is intended to say.

Sahil, you should ignore any suggestion made to you by Markus.  He has
been told many times to stop making these useless and unhelpful comments,
and yet he persists.