From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3477729BDBF for ; Tue, 18 Nov 2025 16:42:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763484177; cv=none; b=uhP8qMOYwc/MhmCZy2RvS/xMF8jfp9Mmzrqcm8QtvlEr4aPDLEz4C1pYVTn+m4ZNsBDQjMvHhAmCYTf7UIr5wfUhXxpJKE2Oc6nagcGYTv10Ds9qO1bh4jZ0RLRVt/usohqnA7pDY0Yqs4xX4uRsDayPCZQFPfABtj0K7X3pilc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763484177; c=relaxed/simple; bh=jePVpy6+q0ZwdOkimr3ZdSF7ygrpTpCkiZepBmNE5nQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b9WobcSr/R5iq8w0dSTHuYnoDoXkBlxjP4EXmOOfSaZYCk+HnyINtKkqJ1Df97T4u2LfubaVlQx7yH4pFsCe6wFEc+TPufcVUdQh2kIqKn7Y+i8eWDYJzRwVgypsU7qhzs+AFnEG+18rzWTqI/6yRw/I0JETYGsHwHHoumrLfOc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=G3eDZyJ4; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="G3eDZyJ4" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-297dc3e299bso55400855ad.1 for ; Tue, 18 Nov 2025 08:42:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763484175; x=1764088975; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ajw2E1NL4+ilWTTz+HJjdJlqtmBwlpNjA2J8C3gJWjo=; b=G3eDZyJ4v2Jw/qn3M/gUFbk6yhVdMm0TyEGcYyuT0P2EV40y+z4yHAsvl0ni1hPoqe 3vHzb0X/2Qpw57vxBo3dGX4TVuUWabgWRSQLfzwhplDcrzXdj0WRA9mZjbAN0V7vXJ5+ MIg7j0FyMN8uAT3rWnUcJo7WLJVeSgLlbzENSsS59NE42nePz8QnC/DdIKoHHNPRD2/Y 8Rc+lv5GrSmKiQ+ueVncVSULouRbvKVQtWw9zeCjJCgbFDETWCGvUp5DVoQFftcSIgYF sx3LmVJfWNL7mPX0pGzTKB/jAmNS1rLsW1x6Xs92JpbVus0onn0Zl+eRT6BwB3G8dESV Jmsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763484175; x=1764088975; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ajw2E1NL4+ilWTTz+HJjdJlqtmBwlpNjA2J8C3gJWjo=; b=QJh+XYwMz9Xr/+teHRM90STqMHGcija5CjjzB70QoODJaOvRLa9ITeqhqFg7w2Aekz A+vsxtPIX7WcA/U1N8F/m3dNDFLv+SJVkOg2W5bmjl0z8bafMrtnqQHudGFxeTDjBp9l /ypG8AK1s9/sO/8YLd8uzbBC22S4+sxdC2AZFY7faiuwygjzya2bxOFtFerLsjm5ssMV F98bzA+36MNxzaXVBOPxAa7J9UhgvRcdL1rTmesohV96g1WrODDg4Y8gC26m8rC0YWVp 73oi3vNruQp6bLB1jF1Kq04x5r1v7lu5cu/t7kNFSJRgWwFtMmyR7QhGqYL8b6lwfkb0 FSRw== X-Forwarded-Encrypted: i=1; AJvYcCWzktghQZ1zZ85o8Ac2I/YvK8QobcMG2bg3GM4in5whUVOTEn00CTv8PuaxZuWftS0XqyMeeVBpHEyab2k=@vger.kernel.org X-Gm-Message-State: AOJu0YwjCseaHrklFxK3zg4mPv514rfV338oI9JfSzR+D58hNvVxRhNv KwExApPMUdEUgrtdABhhTsoavn+Gn87jbXzn3r7rvcIR/+iHUYnaXjr6w0pBLfqTYpg= X-Gm-Gg: ASbGncsyn2VgJPN6UD3UcKOZtpUPxK22AuKS7pwI+mSV/m4iweIhbabxhLgyHtV4xJr wvdMvW/8zFi6PA6U/heEebeRIWUVF76PmINyAMss647u/v1Gl9U2mEiC8V+v5M4QZZfYlxL0svl IlMf28yyTJs5+rTwOSO4b0AfKT9H8+7P3z27beF56byjLjFOArK03dXO7uSg+ukiKvaiv/L7vDi u9S1Q5D6qfOntazdu4qRZGJCn6u7t2C7U3wUstZMt7ZuwSVbDrXGPRP1pEOb51xk6FBcLRTexO5 Z6ezM90R8i+Zug/tIHNQ0Q3dyUs9Uyo5CDEgjd7mc51XrhuzaQq8uOgGXaUBE2KQg+w+WmfphGp Yx38qBDeyVJlB5R1nwJs6kvBuxUXerPu1HKyzgjSCU35g7XnPqspQoapfqYAxdO50hKwZpVjUtN +KfK1sa01V7D1kkQ== X-Google-Smtp-Source: AGHT+IFHZInbopaXHrcms/mL2ZLWLLFWIrlmSWjRDYQeHFfnq14u/a3jqiLWEErsYjmSVeHRv2ntAw== X-Received: by 2002:a17:903:247:b0:298:efa:511f with SMTP id d9443c01a7336-2986a733395mr195293315ad.39.1763484175459; Tue, 18 Nov 2025 08:42:55 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:5650:f012:168c:76e0]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c2beb34sm179110845ad.76.2025.11.18.08.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 08:42:54 -0800 (PST) Date: Tue, 18 Nov 2025 09:42:51 -0700 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Frank Li , Daniel Baluta , Shengjiu Wang Subject: Re: [PATCH v3 11/11] remoteproc: imx_rproc: Remove enum imx_rproc_method Message-ID: References: <20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com> <20251111-imx-dsp-2025-11-11-v3-11-d05dcba737fa@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251111-imx-dsp-2025-11-11-v3-11-d05dcba737fa@nxp.com> On Tue, Nov 11, 2025 at 09:41:22AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > There is no user of enum imx_rproc_method after moved to ops based > method. Remove it. > > Reviewed-by: Frank Li > Reviewed-by: Daniel Baluta > Reviewed-by: Shengjiu Wang > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.h | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h > index 6a7359f05178a937d02b027fe4166319068bd65c..1b2d9f4d6d19dcdc215be97f7e2ab3488281916a 100644 > --- a/drivers/remoteproc/imx_rproc.h > +++ b/drivers/remoteproc/imx_rproc.h > @@ -15,13 +15,6 @@ struct imx_rproc_att { > int flags; > }; > > -/* Remote core start/stop method */ > -enum imx_rproc_method { > - IMX_RPROC_NONE, > - /* Through ARM SMCCC */ > - IMX_RPROC_SMC, > -}; > - > /* dcfg flags */ > #define IMX_RPROC_NEED_SYSTEM_OFF BIT(0) > #define IMX_RPROC_NEED_CLKS BIT(1) > @@ -42,7 +35,6 @@ struct imx_rproc_dcfg { > u32 gpr_wait; > const struct imx_rproc_att *att; > size_t att_size; > - enum imx_rproc_method method; > u32 flags; > const struct imx_rproc_plat_ops *ops; > }; After all this cleanup, please remove the goto statements in imx_dsp_rproc_{start,stop}(), as it was done for imx_rproc_{start,stop}(). This set can get in the next merge window if you send me another revision by tomorrow. Thanks, Mathieu > > -- > 2.37.1 >