From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2989E3702F3 for ; Tue, 18 Nov 2025 20:20:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763497225; cv=none; b=JK80WkfbXQztkEmLa9aNCAZ+HSN1KbD5IYqXid1VyjmcRlZFV3KXNAaNduwJpPYc5pAIvMeWCO38UYwCPljO185fI9MRSCsS69R/dtn8rGHLwpm/o1t9wF/m3v7h15MJKsXeGHpGtOJKYKHSsm8RHTxWd5XCsUY8cz41utI4o2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763497225; c=relaxed/simple; bh=IbrP+RAFFs5uSyKH8DEgaYosOA3a4YB08+rNm2PfJmI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QM1p0EDyHOaR1WO9NGsXEJ82BHPgSTrXFSaxkEYTfTGfiory3/bL6DJo6UGhhRENnVGjoRg0xBq95cpinF/RKF9vLs7gDKuEC76/Ih2Uqp9oU6xl4Oql6No6kOGOzmQ8QJtcbaOLJarM0XVlL2YflQmFSEp2ZGUTO6hvb3nIFsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SODY/Dwp; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SODY/Dwp" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-42b38de7940so3364962f8f.3 for ; Tue, 18 Nov 2025 12:20:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763497221; x=1764102021; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=l0pKkIaEqkTeFfMBeLi6StcxmGY0QC1qizzrKLLRaeo=; b=SODY/DwptoES347ziIflWCk4w8S7ebnTasQFqlfGU6FywPE0LsAyXaUwno+JtNfmXi geU0lyU+gmxa5UlrlF20DVhmk7f9foLN3BIEeqsyIjKKgN5xhOsl60IGjztce9lVM+sB QqrHObsMRve8QyLemh1wkn/oymnTNrAaMQN4Ds1zSqP/poeeuWcx9XOWpfZ96v3GT0ua byhYU5L4aJDyTF3l4ibLfzNbNubAf3Pl3bn7vCgnDUNb92VByfAygJvJRdC04PRPDvrM RGYHa6Nm5f269SRZdh4HS/CfdbKJ46PAYM8NmuVGe4h6w4WCSYPjhVcZwyFU0dKFOB4R FOSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763497221; x=1764102021; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l0pKkIaEqkTeFfMBeLi6StcxmGY0QC1qizzrKLLRaeo=; b=EJmxS7DZrfxqMYuKEGIdjzARRtJavrm8i65ZnvBGU7Epi+MfB6Moxs+RyzYHFlW4AP d0BbgreqJkjDn35QVdyCypSYJb7E5IScRCPDCpEz9S1KK1MtY5LR4o2i2vteVvPFxZHi xH6rQI9WQyxrGuHNZTTbre08PEdSaVuHjfoJ0WiCXY0Bu+tR6uK7JnWDhvlepvarcUGw 8P3W+6516LWdqnotS5hzmEeZuE86Y0mT1ou8UMOFiMUbrPA69VwxK9GxGfEfiC90SEZJ smtSMkWVWlp/IXMVlDcjd3BYOX0mkCvBS/lzQyGheUkJ1PUF19L9Se6eLES/Hk3eLuJ+ 4rsQ== X-Forwarded-Encrypted: i=1; AJvYcCXx6m6gSCpTZlh7YtddUJGLhx8sMPcDbOZHKL2cG+SlnIRfEZLWw0AWyXODoPj9Lk95VXZjAJq/phcfbIs=@vger.kernel.org X-Gm-Message-State: AOJu0YxfL38XubDZqoK6uiqsiaR/DXxuXkXk4azaHPLrqykkc57IBS4V E38nX+IpaxeFwdBEuWJfgq7ZielCkgLyTYkv3rptXUqEJHGcauxxFP8+ X-Gm-Gg: ASbGncsEFzkykmjTMqL2c3AHy0P0K9faxcc+PrfM0Zh43KZJsWLdqPdQGzSMLijlqQO eA3rmqtwohGLAVxTOCwkx8XvPU5edm+bYnIy4xXOMC9WE/VJFFMbacBlg1J1T4pB05rHFXxMEud LYxkt9DrlalaGFavMswlncRalHCLdLwOpyZKdQ4b6yz1lFke1un1vcOBtEjEDe2wiCvzUDJ7UEp ElVXBrdQDQSnYqvc1ZZMdGbU0PdhmTl6BPwYKeF+IbDVczNd7R2MDauWHnyO3qSM0j+XQmI+9Bc cWMIl6r7g/UvPSFHp7PEsGdrZ/qM+wPoyrs/Yn4ohuA2eLXDkUr0nlJFsV991rKLCKqGrDU0Ayg qKNq1HxQpfBDcAQLuUxIZRBCcxId9ZdZsZwNoJ852a9R0h5uFbtxBt+ZKD4SBjajVDCuiIO5WP3 ZI4bT3TC8W8lVycDghTPU+CN640OEc1buEnBa8 X-Google-Smtp-Source: AGHT+IFewRuIeONGEHUMg5h6XpjXzlc8IyfzgPHPxe8zn2VsF2GBYuWpckKVA66DE8AtS4uUJlK76Q== X-Received: by 2002:a05:6000:2010:b0:42b:2e39:6d66 with SMTP id ffacd0b85a97d-42b59339192mr17414878f8f.15.1763497220979; Tue, 18 Nov 2025 12:20:20 -0800 (PST) Received: from google.com ([37.228.206.31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f206aasm34279654f8f.40.2025.11.18.12.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 12:20:20 -0800 (PST) Date: Tue, 18 Nov 2025 20:20:18 +0000 From: Fabio Baltieri To: Heiner Kallweit Cc: Andrew Lunn , nic_swsd@realtek.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Zimmermann Subject: Re: [PATCH] r8169: add support for RTL8127ATF Message-ID: References: <20251117191657.4106-1-fabio.baltieri@gmail.com> <89298d49-d85f-4dfd-954c-f8ca9b47f386@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Nov 18, 2025 at 09:02:22PM +0100, Heiner Kallweit wrote: > A contact in Realtek confirmed that only 1G and 10G speeds are supported. > He wasn't sure whether copper SFP modules are supported, and will check > internally. > > I'll try to strip down the patch as far as possible, likely supporting 10G > only in the beginning (as 1G requires some more vendor magic to configure). > I assume the typical user won't spend money on a 10G card to use it with a > 1G fiber module. > Reducing complexity of the patch should make the decision easier to accept it. > > I don't have hw with RTL8127ATF, so I would give the patch to Fabio for testing. Hey thanks for following up on this, cc'ing Michael as well, as it turns out he was also working on upstream support for this at the same time as me, maybe he can help testing in more scenarios. I did test 1G support between two RTL8127ATF cards and it works fine, have not tried between that a 1G fiber only card (don't own any), happy to drop it if you think it may not work but hopefully it can be tested and kept, it was in the out of tree driver after all, I'd hope the vendor did some interoperability test with that code. Cheers, Fabio