Re: "controller is down; will reset" on SK Hynix NVMe drive in Lenovo IdeaPad Pro 5

[Keith Busch <kbusch@kernel.org>]

On Mon, Nov 17, 2025 at 02:39:17PM +0100, Thomas ten Cate wrote:
> The log suggests to add the kernel arguments
> "nvme_core.default_ps_max_latency_us=0 pcie_aspm=off
> pcie_port_pm=off", which indeed makes all issues go away.
> 
> I haven't found a reliable way to trigger the latter error
> specifically, though doing something I/O heavy like compiling a kernel
> seems to make it more likely. This makes bisect difficult to do, but
> it's clear that something was going on in previous versions as well,
> so I wouldn't necessarily call this a regression. Either way, the
> issue is still present in mainline 6.17.8.
> 
> Since it happens only after some idle time, and disabling PM fixes it,
> this seems related to power states. But of course, I cannot completely
> rule out faulty hardware either.
> 
> Machine: Lenovo IdeaPad Pro 5 16APH8
> Architecture: x86_64
> NVMe drive: SK Hynix HFS001TEJ4X112N
> Full lshw output:
> https://gist.github.com/ttencate/5540c81454bbe1fa679955effba65eba
> 
> Distribution: Arch Linux
> Kernel version: 6.17.8 (vanilla from commit 8ac42a6)
> Kernel configuration:
> https://gitlab.archlinux.org/archlinux/packaging/packages/linux-lts/-/blob/b0cac6a69041703bbe1aba4a2a269585d77b108b/config
> (plus `make olddefconfig`)
> GCC version: 15.2.1
> 
> This is my first kernel bug report, so I hope I didn't miss anything;
> if I did, please let me know. I'd be happy to experiment or try out
> patches.

The "report a bug" message was originally pointed at hardware vendors
rather than kernel. Something is wrong with the SSD, the PCIe slot, or
both if the power features cause the endpoint to drop off the bus. The
only recourse we have in the nvme driver is a quirk to disable APST for
the device. The driver doesn't control the PCIe ASPM settings though, so
that would have to be a different quirk if it's really necessary. Do you
need all three of those parameters, or is disabling the nvme driver's
apst sufficient on its own? These parameters do have a negative impact
on your machine's power consumption, so you'd usually want to hone in if
it's just the deepest power state or if every power saving feature
really needs to be disabled.