From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 283AD26A1B9 for ; Tue, 18 Nov 2025 22:01:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763503308; cv=none; b=M480gg3o6/1qO7oEfAaak+6XuxsI9qsYwzlmEcEIQBMCoqxB/ur4X4mDs67+ykdoITvu3ZAC1XhSkxjr7EvKN55toCT0oq6nD/zN/TH4nhHWmbAP3gFmtXwl6xuw8gAwfSi11vslGq37UowCyOPwuSqXTNVXFcrLTSM0t6W8BEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763503308; c=relaxed/simple; bh=VxzyG4LUyqSss8TtW+6ssOa1nK8AYBqmOYLe1JvodF4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WFp+5mOjNiljA10H7XOi5tSHHLVAV8a9jFc8J04adK0iKKOaEbGqEoEse7eGoLiTYoS6QYJvCWq+Npeo/3WPEO54WOgIBVtZqSZuacbmKY9klhy7WfZ2YpCGJ0S3mVQF09pRxei7e750pq1JUOcNSM6C0nQN9lfypzV2bz3w2gQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TQlpTm96; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TQlpTm96" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-477aa218f20so8526655e9.0 for ; Tue, 18 Nov 2025 14:01:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763503305; x=1764108105; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jXah3cbf0knU5Q6XpR431aW6C9/9DUU4ivHmHxyWSLI=; b=TQlpTm96zf6nH1Le/dg+uARpoAcnIvNhuxzD5NT7nUVXMA/n9DlS6/QJq5mjRLUmiE cH0Fy1u7SLZRBSSiOOvGNpxLSUbnuX8H3OEDd49h0bBq+UFXCnh42LXA7ktFoySTrjvK y6is/RUAO1sbq9VdZxLRblLFTr7QEH3g4aE0uQPztXRVkiuLkdvmpQdfHcZOofch3MRY xy7AJIDReXR7QcNcYTmbVNSk5+vy/txLB0IVFMLPlc8CBTS6YV4U+gRfhFqMGgm9mfZ7 LvForJr19khcYJ8Fjw/17g8CpGQCGp3UnPD2lWk2GYApJdGOCKxqEooayd5ExXjVRswS KwAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763503305; x=1764108105; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jXah3cbf0knU5Q6XpR431aW6C9/9DUU4ivHmHxyWSLI=; b=Zts7rRj5p838tIaXMVTJEecynzAqazG5rE4ySY4x5WCAbGHWz7SOFs1TXziv/Ao8Cx DLjIExoW+hVOfA4rdVeCxoCXcthSyyVFZ6SXhBbhqEWo5eZhwgRfEZq1eqmSSVSIH+WU EF74P7t/PXYAhXohpNfv8wH1ANCN5wBmJX1wsiiYMiKrCs9yROZOkmFzOyYXUX7dXOQi 6lggWuctaRrilRGQAGDeb1NV4Knv63Bi+KtZY11TyhJ2RgQBlEOBUYl9Sf/Vz2jy/Hci j+MF1lgHh6eUhG5usP00CLnBEHriusppLOdgMiltu2eiVkC+DP12a9S5O2bLJyEeW+jT ZSTg== X-Forwarded-Encrypted: i=1; AJvYcCVm5G2LxHa7nedC35tpYW+pN5RQe+NIc0nfD/8BehZ1PD76apCDLSG18RkuaAmKUbnwbSVOGbF1M4X2wgM=@vger.kernel.org X-Gm-Message-State: AOJu0YynWBUhwOsnnElYC3YHKVb1nja5vJXpntEx6KhSvvXdWJp7o9qr 3piT9bkP5aer+S7ffZYszOwajS86820EttXwJ3AVhCpnDAdhTiPKN5BQ X-Gm-Gg: ASbGncttf/UtWXSw85LBUXobY9gQR2O7I0jOJyJfYfiydvYFMkmCf3YwhtUhCugkm1P VCslFAAgeu0v81mYV2zeAGazLSwOUqQwKapMvL1Ok62bwyG+kO6zcbIA4ROwxeuPfU8F6mDejIw oidgBsrA9lu0DGHB1duJB+tutqPkegUABauZUtjfX8XgQtU/u8vrBezys5glybKLtDkosBXpgLT dSXELonTEqMzebvo5wDajJZG2yh1y6ny0NwmyazRAExtOFn22pkczY0z/OpztwAGgEo5VIh4UbB TQMzKdjk680firUrTQTHddJ1H9yf5MQjd25+pRu4btkXNpUe58+p7pC5oQiuZRE2M3DvLi3ylXw 5mrUsaQ1RnxvVlkPu6yoYVzXZPfXZiBeMcWaykVUDV20xsbzCidzuQgPtu8Wi61qPAwPeLx/E2y mITxyC1+/12MCnV7RoNT0J8zFOgA== X-Google-Smtp-Source: AGHT+IHIQGSmUQPOk/uWxSPLANaIEivihxczJ8iiI0IlkCgOa+nW3ISphTxBgacrfZYBDxXLPgqxwQ== X-Received: by 2002:a05:600c:6287:b0:477:632c:5b91 with SMTP id 5b1f17b1804b1-4778fe5fabbmr219822505e9.16.1763503305357; Tue, 18 Nov 2025 14:01:45 -0800 (PST) Received: from google.com ([37.228.206.31]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477b106b10asm11972555e9.10.2025.11.18.14.01.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 14:01:44 -0800 (PST) Date: Tue, 18 Nov 2025 22:01:42 +0000 From: Fabio Baltieri To: Michael Zimmermann Cc: Heiner Kallweit , Andrew Lunn , nic_swsd@realtek.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] r8169: add support for RTL8127ATF Message-ID: References: <20251117191657.4106-1-fabio.baltieri@gmail.com> <89298d49-d85f-4dfd-954c-f8ca9b47f386@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Nov 18, 2025 at 10:31:54PM +0100, Michael Zimmermann wrote: > One thing the out-of-tree driver does, which your patch doesn't do, is > disabling eee when in fiber mode. I'd suggest something like this: > @@ -845,7 +860,8 @@ static bool rtl_supports_eee(struct rtl8169_private *tp) > { > return tp->mac_version >= RTL_GIGA_MAC_VER_34 && > tp->mac_version != RTL_GIGA_MAC_VER_37 && > - tp->mac_version != RTL_GIGA_MAC_VER_39; > + tp->mac_version != RTL_GIGA_MAC_VER_39 && > + !tp->fiber_enabled; > } Heya, don't I have exactly that diff in the patch? The second chunk @@ -842,7 +843,8 @@ static bool rtl_supports_eee(struct rtl8169_private *tp) { return tp->mac_version >= RTL_GIGA_MAC_VER_34 && tp->mac_version != RTL_GIGA_MAC_VER_37 && - tp->mac_version != RTL_GIGA_MAC_VER_39; + tp->mac_version != RTL_GIGA_MAC_VER_39 && + !tp->fiber_mode; }