public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: tomm.merciai@gmail.com, linux-renesas-soc@vger.kernel.org,
	biju.das.jz@bp.renesas.com,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: renesas: rzg3e-smarc-som: Add I3C support
Date: Tue, 18 Nov 2025 23:19:53 +0100	[thread overview]
Message-ID: <aRzxCY-Z59tMKro2@tom-desktop> (raw)
In-Reply-To: <aRyf_4U9DGRmssWd@shikoro>

Hi Wolfram,
Thank you for your review!

On Tue, Nov 18, 2025 at 05:34:07PM +0100, Wolfram Sang wrote:
> Hi Tommaso,
> 
> > @@ -29,6 +29,7 @@ aliases {
> >  		ethernet0 = &eth0;
> >  		ethernet1 = &eth1;
> >  		i2c2 = &i2c2;
> > +		i2c9 = &i3c;
> 
> Hmmm, I am quite sure the i3c bus is not named i2c9 in the datasheets?
> I'd suggest to drop this line.
> 
> Rest LGTM.

Ack. Will drop this in v2.

> 
> Happy hacking,
> 
>    Wolfram
> 

Thanks & Regards,
Tommaso


  reply	other threads:[~2025-11-18 22:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 14:26 [PATCH 0/2] arm64: dts: renesas: r9a09g047e57-smarc: Enable I3C Tommaso Merciai
2025-11-18 14:26 ` [PATCH 1/2] arm64: dts: renesas: rzg3e-smarc-som: Add I3C support Tommaso Merciai
2025-11-18 16:34   ` Wolfram Sang
2025-11-18 22:19     ` Tommaso Merciai [this message]
2025-11-18 14:26 ` [PATCH 2/2] arm64: dts: renesas: r9a09g047e57-smarc: Add overlay for P3T1085UK-ARD Tommaso Merciai
2025-11-18 16:43   ` Wolfram Sang
2025-11-18 22:28     ` Tommaso Merciai
2025-11-19  6:12       ` Wolfram Sang
2025-11-19  7:17         ` Biju Das
2025-11-19 19:43           ` wsa+renesas
2025-11-20 11:07         ` Tommaso Merciai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aRzxCY-Z59tMKro2@tom-desktop \
    --to=tommaso.merciai.xr@bp.renesas.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh@kernel.org \
    --cc=tomm.merciai@gmail.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox