From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA020DF72 for ; Mon, 1 Dec 2025 18:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764614468; cv=none; b=jzKTctz8prG+7zmr5idv/yV1ZDovNKVLeph3fbFy0KU5X1DYDSH6wVcAZFva/3E3NETrovXys1oTCoseRQ+ZPX0BW5gWUMjxSv8kkroHSrkkvjl4ja9mZwfBY+XWPSLhbgn2H40LR+sg5k00bBG5V/mcxN/0kCQKzAlx65Slj2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764614468; c=relaxed/simple; bh=DuTPv9w7IAEWC0VimD5SxTseN4bCXCYxUcVcpotFjBw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=cjT5VXWOFHXBGDlSad28zZ4+HW1G97ZnjJwM2uJw1+jrdtKeDS5u6KlpKrPqHn3mTWxNXzeYr9X9INwu8ondSUOWvETxI1NY4a3fKYf77ZvV8WnjpIvUv88/zMwSVs7IOFblI/vgrFziqgchutiLb73DoCclgVNLzkLGL2bAaVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Kc1WiYEy; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Kc1WiYEy" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-297fbfb4e53so68302925ad.1 for ; Mon, 01 Dec 2025 10:41:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1764614466; x=1765219266; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=IIswF9CMvnraK8e7L4/o0qadvBef2Ftje9TVH+1eYRg=; b=Kc1WiYEyYyK6JWiOglL4PGt0cE1AiKubJ8wX8gMYmVRmdgGOyDVrkJUE/IwaZbrzYH ZF2XdoCHKCf5PuvOu+shOVUr5S3WRQTHSwqncIGkpRs0SJxmPwqjeeD02eeeMW19mDW9 QFEV3EDqO/seBx57OAZyl+6NO4DOegm/ues1Vw6kHsVJsHjrd+7d+sOTV0dc3dl9TLe3 Vc5oScHD7MwDEnEUE6riVLTOk8UJsuQ+A5yc4FZfWRkC/jDRqJb5BtlkEIMy9KcsT/4q rpXypJh4+CR5bR1kimjKeWtkmN3/fATibxS3z+5DWCyNy59sT/yv9QjNZAquQ8jGq6x8 AJVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764614466; x=1765219266; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IIswF9CMvnraK8e7L4/o0qadvBef2Ftje9TVH+1eYRg=; b=lznO/jHEOsyxF2yUl/DVEYD6HFOstm7Iw5WxfcObVwukMlbsTWT93qdXcSGXy1+7e3 eC5LZAhaE6vAe1qYovy21JqUKVrvNCLGpRUtH9rsSDVwaJ5VDnRjIAc6lLcQOtqHUgbC vv8CXPfc5EraFzrbdik/HJbhg/kO33qmmR5WGMIA0ZLFdFFmpp2Ne1GytKD7n86Qc5iP WZo+TJWeSXdE4w8TYpOmbKWCVh42zB3BYlLnBVq3zdzxVLLheA7aaM2lK+yTxtwdZvXt jAJWgOvlNavuC8EdJhiXcBIE9cqTaNSw+P9UKBuk1XXhugG1AEXUy2rd+DEmRQ36IVkU oYpQ== X-Forwarded-Encrypted: i=1; AJvYcCUil5et0crgPEc9KW1mBnwfuVHmw9zgqJ/1Cj8u0y0VbwJNJlmhFKmHVuMMVxQEoqAbBjRlaPabyuekOqA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxlme3Blg4J9OJtQ7unlRxoEDarRGg6/EfHeUwJX2AM5+ccBhZZ ld/qDtx5nVucSKwL2Cd3Tw0yRqKFd/HIV9ANQ4h0LzHCsVYdd7Nli9s0hJ2ofnYQECzNRwuMCUe 6W5lj1w== X-Google-Smtp-Source: AGHT+IGXdEd9mdo5t6fFzrNJLEWOsjqqyHF+rT0I0RHXmvgXzC6pomZxFHRezlDsWy8wgEpE3q3L9Ag5pi0= X-Received: from plj12.prod.google.com ([2002:a17:902:c14c:b0:295:64f4:dde2]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:2f4f:b0:295:7453:b58b with SMTP id d9443c01a7336-29baae4569fmr291488755ad.4.1764614466141; Mon, 01 Dec 2025 10:41:06 -0800 (PST) Date: Mon, 1 Dec 2025 10:41:04 -0800 In-Reply-To: <20251201141556.GG3538@ZenIV> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251128-vfs-v619-77cd88166806@brauner> <20251128-vfs-fd-prepare-v619-e23be0b7a0c5@brauner> <20251201141556.GG3538@ZenIV> Message-ID: Subject: Re: [GIT PULL 16/17 for v6.19] vfs fd prepare From: Sean Christopherson To: Al Viro Cc: Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Mon, Dec 01, 2025, Al Viro wrote: > On Fri, Nov 28, 2025 at 05:48:27PM +0100, Christian Brauner wrote: > > Hey Linus, > > > > /* Summary */ > > Note: This work came late in the cycle but the series is quite nice and > > worth doing. It removes roughly double the code that it adds and > > eliminates a lot of convoluted cleanup logic across the kernel. > > > > An alternative pull request (vfs-6.19-rc1.fd_prepare.fs) is available > > that contains only the more simple filesystem-focused conversions in > > case you'd like to pull something more conservative. > > > > Note this branch also contains two reverts for the KVM FD_PREPARE() > > conversions as the KVM maintainers have indicated they would like to > > take those changes through the KVM tree in the next cycle. Also gets rid > > of a merge conflict. I chose a revert to not rebase the branch > > unnecessarily so close to the merge window. > > Frankly, that hadn't gotten anywhere near enough exposure in -next and > it's far too large and invasive. +1. Saying that I want to take the KVM changes through the KVM tree is technically true, but glosses over why I objected (or even noticed) in the first place. https://lore.kernel.org/all/20251125155455.31c53cf9@canb.auug.org.au