From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F287D30DD18 for ; Tue, 2 Dec 2025 10:18:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764670699; cv=none; b=lEXlRJxGAWM0TmU9ONwyrHfcrPTli6Vg0itRr92KFKkPasPfHbKjYCwG56HJn8uVliVi02EGUlAe/CKeyBn+G9IYlqtmtWKgSgt1Jku+FVCZyy9RsqcRWUjA/57kIk7TV98TQ93AwUT39Fza2JqpBzYflMWTeMYyREVgVWZzlSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764670699; c=relaxed/simple; bh=MT9zrf/cg1JZkz6GyWLfeQ8v3g0Z2erfHfgpesvFVnk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r83zY7aey1Gnct9Q7UVxHel3xNtmOJFQyveu03u+K4U9VidKNJ+shpsUS3nqDXbb+NYkK2+IBeJGhd07Tw7QcmKyINaT8il6j3dOwuMx9Z4WFhDcPOtgQTEqPUhIexK+HsJjsS0cWB9poWAp6ZH6n2f/u+Vj7YNIwaN+BkeUB+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=G43z5ovi; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="G43z5ovi" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4775e891b5eso22057535e9.2 for ; Tue, 02 Dec 2025 02:18:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764670695; x=1765275495; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9cAk3oLL8ROCJ57k2VQByXGpSqsygpTMtS752h0isB8=; b=G43z5oviz0aU1/WYGGN2bhwOU5HtTUE9wMHkzrHDLxzYKsFlYOKMz0/HXUYwTqFPBX LJa67haFkGUpBTUDvrTVi/2E8105VdWDfmtaF+yCNDKft1RJqrQLue8qbNYqPoErnoER 6yKiYp50dyD2Nb8TSmnmIzoDjgG5T86MU6fOoh4HLmCzNz6RuDo6z0ErViB6c97igQ+0 f2c5t5xZPX9PeZpWSl+3GjspUGuI0zR50fzfmeCeoMrxqcAgDmtlVTNb/YaU1zD4e+fY jscFcHjF176oBhRg3FtEyjbgUrUr7QosiS3w6W5tAD14LoJvn9FoYukaeURAxK/tWLsm p+Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764670695; x=1765275495; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9cAk3oLL8ROCJ57k2VQByXGpSqsygpTMtS752h0isB8=; b=cq0p87sWr+oMBbk0YajatuZGE1nBYqlvQA4lJCFrh0/E9uog5ciq89z7yNYgAu51Hj C7Hfijv2GYc8Ul11GTho5UO1HRcqkUKIrx96jZnvXjgD6MlR9a7UYbUGkx6eIBQhbtnP qDEAjMAPfbuuaTFaMwHm9shZAuTrNMWO/hWug8NoGjw+RpIFY9RJZRyWKBcxpUGszDTf ho81XM/gl6mpkipxI34Nb0qsoAEy6cIFQ0ZTZuTGOb6uXcFVVJbWqM+Cwi90ZClPnhLi JFwEXiruNixrZYAD+j/JTFhoGyq6Bo9F8mDB9/cXLDR7frTQSYP2AUcs+4e3reFT7JAQ REbw== X-Forwarded-Encrypted: i=1; AJvYcCWuq86pKlmQGbD52zzsixq5WY1v4EutNh+jO4ehVkQgDLu5EZ9jo68S7V5aZYfPjgb1XCrtiaKHGZz/I3s=@vger.kernel.org X-Gm-Message-State: AOJu0YyRsEGokMMJaWUGZAtbI9QXJV4OCtVIAQ5JRp4xytQCtt6Z2MTG 8htdJbetaAdWPWEV7I+tYXV2ECAK6BuzB3Zkwcn1JZL4p9yP115YlNp6yuE1e/AJUGQ= X-Gm-Gg: ASbGnct3ZjTJwvSzvw1VXpHKIr0dJgsra6kv40HRovA4JBmKn0tSrAfxFZmHbMmcOl6 8R55TK1e7Sb8aKB9L0Mu/Cb0D8UIPd9it0tF3tYIHlxu6xx0IxcjaVCbA8oahEK5XKIAQYvyBwj Sl6U7yOCSdduo9bu60zdahko/mv/gJu48jPRv21f2PKcHzQV00XPBLappy5Bb4XJdzvzzH8QH5m 1lPcBPaPL/m0ux7PiHZz1oWVmYRT73Zs41PbF8AO44Sj8lv9CLpPHlzqa2Hqhm0iKNwfboftOen C97gbVW/F/8mcSsG5x832pI7TGkF60Rd6umnbh863AluSusjRrqP4/nxKNXbhTwwB7Xx8FTWIc+ 3J+TO43LTFqJ9A6dZW2QPoX4jHWbbED6/5JvcMmxsEGVHaf4PmBfX2v5kG/bBPYd+3JGh0XyqR+ MEA7jobBQd4UFkmQp+ X-Google-Smtp-Source: AGHT+IHy3nFX0LKMVWLipxBkC1l1bBeysdgOp+AnUue/+gwsKv8yLm3DSpc6vz+WjLvbvqXoMhctiA== X-Received: by 2002:a05:600c:3baa:b0:475:de12:d3b5 with SMTP id 5b1f17b1804b1-477c01ecc7cmr422115765e9.34.1764670695027; Tue, 02 Dec 2025 02:18:15 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47927808a3esm12254865e9.1.2025.12.02.02.18.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 02:18:14 -0800 (PST) Date: Tue, 2 Dec 2025 13:18:10 +0300 From: Dan Carpenter To: Haotian Zhang Cc: Florian Fainelli , Broadcom internal kernel review list , Greg Kroah-Hartman , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vc04_services: vchiq_bus: Check return value of of_dma_configure() Message-ID: References: <20251202095253.1640-1-vulab@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251202095253.1640-1-vulab@iscas.ac.cn> You're not working against the latest tree so this doesn't apply. On Tue, Dec 02, 2025 at 05:52:52PM +0800, Haotian Zhang wrote: > vchiq_device_register() ignores the return value of of_dma_configure(), > which may return -EPROBE_DEFER when the IOMMU is not ready or other error > codes. This allows device registration to proceed with incomplete DMA > configuration. > If of_dma_configure() returns -EPROBE_DEFER then this will just fail and that's not really any better than the existing behavior... regards, dan carpenter > Check of_dma_configure() return value and fail device registration > on error. > > Fixes: 027e5703de6b ("staging: vc04_services: vchiq_arm: Add new bus type and device type") > Signed-off-by: Haotian Zhang