* [PATCH] dm log-writes: Add missing set_freezable() for freezable kthread
@ 2025-12-01 7:41 Haotian Zhang
2025-12-02 18:50 ` Benjamin Marzinski
0 siblings, 1 reply; 2+ messages in thread
From: Haotian Zhang @ 2025-12-01 7:41 UTC (permalink / raw)
To: Alasdair Kergon, Mike Snitzer, Mikulas Patocka
Cc: dm-devel, linux-kernel, Haotian Zhang
The log_writes_kthread() calls try_to_freeze() but lacks set_freezable(),
rendering the freeze attempt ineffective since kernel threads are
non-freezable by default. This prevents proper thread suspension during
system suspend/hibernate.
Add set_freezable() to explicitly mark the thread as freezable.
Fixes: 0e9cebe72459 ("dm: add log writes target")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
---
drivers/md/dm-log-writes.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c
index 679b07dee229..1f8fbc27a12f 100644
--- a/drivers/md/dm-log-writes.c
+++ b/drivers/md/dm-log-writes.c
@@ -432,6 +432,7 @@ static int log_writes_kthread(void *arg)
struct log_writes_c *lc = arg;
sector_t sector = 0;
+ set_freezable();
while (!kthread_should_stop()) {
bool super = false;
bool logging_enabled;
--
2.50.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] dm log-writes: Add missing set_freezable() for freezable kthread
2025-12-01 7:41 [PATCH] dm log-writes: Add missing set_freezable() for freezable kthread Haotian Zhang
@ 2025-12-02 18:50 ` Benjamin Marzinski
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Marzinski @ 2025-12-02 18:50 UTC (permalink / raw)
To: Haotian Zhang
Cc: Alasdair Kergon, Mike Snitzer, Mikulas Patocka, dm-devel,
linux-kernel
On Mon, Dec 01, 2025 at 03:41:03PM +0800, Haotian Zhang wrote:
> The log_writes_kthread() calls try_to_freeze() but lacks set_freezable(),
> rendering the freeze attempt ineffective since kernel threads are
> non-freezable by default. This prevents proper thread suspension during
> system suspend/hibernate.
>
> Add set_freezable() to explicitly mark the thread as freezable.
>
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> Fixes: 0e9cebe72459 ("dm: add log writes target")
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
> ---
> drivers/md/dm-log-writes.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c
> index 679b07dee229..1f8fbc27a12f 100644
> --- a/drivers/md/dm-log-writes.c
> +++ b/drivers/md/dm-log-writes.c
> @@ -432,6 +432,7 @@ static int log_writes_kthread(void *arg)
> struct log_writes_c *lc = arg;
> sector_t sector = 0;
>
> + set_freezable();
> while (!kthread_should_stop()) {
> bool super = false;
> bool logging_enabled;
> --
> 2.50.1.windows.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-02 18:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-01 7:41 [PATCH] dm log-writes: Add missing set_freezable() for freezable kthread Haotian Zhang
2025-12-02 18:50 ` Benjamin Marzinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox