From: Brian Norris <briannorris@chromium.org>
To: "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: Linux 6.18
Date: Tue, 2 Dec 2025 11:36:41 -0800 [thread overview]
Message-ID: <aS8_yf3huoqDz2hB@google.com> (raw)
In-Reply-To: <fb19346c-908a-47e1-ad45-bc44f0a10f7c@intel.com>
On Tue, Dec 02, 2025 at 03:37:58PM +0100, Wysocki, Rafael J wrote:
> On 12/2/2025 5:50 AM, Brian Norris wrote:
> > Looking closer at this part of the API, I think checking the return code
> > of pm_runtime_barrier() is a bad idea, since it's inherently racy, and
> > there's really no way to control that race. On the plus side, this test
> > is the only one that does it. So I can probably just go ahead and make
> > pm_runtime_barrier() a void function, and stop pretending it's part of
> > the API surface. One fewer weird part of the runtime PM API to think
> > about...
>
> Yes, pm_runtime_barrier() should be void, the return value is a leftover
> thing.
Thanks for the confirmation.
> > Maybe I can get around to that tomorrow.
>
> I can do it unless you specifically want to take care of it yourself.
I wrote the (bad) test, so I figured it's good citizenship to fix it.
And anyway, I drafted it most of it yesterday already.
I've submitted a version here
Subject: [PATCH 1/3] PM: runtime: Stop checking pm_runtime_barrier() return code
https://lore.kernel.org/all/20251202193129.1411419-1-briannorris@chromium.org/
Feel free to tweak it or do it in your preferred way though, if you'd
like.
Brian
prev parent reply other threads:[~2025-12-02 19:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-30 23:59 Linux 6.18 Linus Torvalds
2025-12-02 2:39 ` Guenter Roeck
2025-12-02 4:50 ` Brian Norris
2025-12-02 6:01 ` Guenter Roeck
2025-12-02 20:38 ` Brian Norris
2025-12-02 14:37 ` Wysocki, Rafael J
2025-12-02 19:36 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS8_yf3huoqDz2hB@google.com \
--to=briannorris@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox