From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 353942DF6EA for ; Tue, 2 Dec 2025 19:36:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764704205; cv=none; b=KLbYHJ+kF4gmckE7grdVRsyxZ2WdL00XNb+3O4nI9S3TkzSzHksQk0kCz+csMlbCaiCsU7NAoh5CtxaY2P/4ot4NSLIdIb9m6AsnlnkoK4OHSHpjJLTauEbnC6aS7hfP9dTPvQEHg6jG0QlZuwoGDoCIxCiXzzkefbZZZHBefW0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764704205; c=relaxed/simple; bh=iVB2tUU9NyWCJwyr17jsnJeWp7fxwKZUMJnAoi+NC7c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aZetB6onlRymbbI/NFih1P2SWqDuPjBBGzPaM00aOI8CBTAI9IMW9f2yGZfx073uX/krZie8zQbTy/zW6sFypS7L3bnWNUjmjnaUi5HFS5nQcUxZBtsDlAWyyBt1GZYdJxfuQH4br81DSNhyKU8XM7X2CdUBiZV1dNGehjhdQbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=YGPCLLDs; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YGPCLLDs" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-2a484a0b7cfso201455eec.1 for ; Tue, 02 Dec 2025 11:36:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1764704203; x=1765309003; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QqCqs0wMDbUotwFHzh9uTitZSgBhU4Iq3Nx1nhtFb+M=; b=YGPCLLDsJbszVKDlpz43SN4xrJo5aCRc9fmxorSa2Y4m3PbLuM6Mv1c08mirS1ZoDS YYpsBBxVRsxer3V28qIhDMiHYlxhwt1YceB3EAxx+Sbro4uxLIFvBA53mb9wllx3dyYX 0S6beqq9Nr7Ei/gDldQVGIQBO9yJlp2pcbjs4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764704203; x=1765309003; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QqCqs0wMDbUotwFHzh9uTitZSgBhU4Iq3Nx1nhtFb+M=; b=anpyRVArATUFvumrLubBLryu1/paDoKV/mIEtr2rccHFMQiHDPRd5v4nACJurj1ZvX U5it7QKXl6ZDqYMeZtHp1Z/GGyRxoqzPw0rJqOl3BlWlh1tt+MstIFmypL3HRsVG/3h7 Jxr8s+TROQuv84lMRLjJk9eGJAitt7acyN/ZoWF72eK2n/CQzsPx/yZUDH3bUWFhkadQ YKQ/oaLB8AA5ccXxQi/3RBzCw21URYlEz+D4pKtpY6L7nRMuFVlzuXxGRqmjyT5A9MaS qXmlzvxiZDkICO5NXVxM+5rv5HVsMmS/eiGX5WPqgtG5CmMwXsuXBWWEZPee5Ku7QlrF mjKg== X-Forwarded-Encrypted: i=1; AJvYcCXbXE0EWUOPhJtePiw+A4vdc7UiVHLeOIhWObjRLyPgXldFDx0xzLWUki+fZ+yl7y6C7rNBqDpctY+nz+8=@vger.kernel.org X-Gm-Message-State: AOJu0YxQ8kgdEhr3sWd86FTf3V7uUf3f3oPFI4S5OYyT4ot5hqmQBMzA lRhj9CFTcT7ged5+ZSTWCJJ9F6n8SUNDIJYD2G/C5mF/r9aaJHtspWGUL5Q/QzieTA== X-Gm-Gg: ASbGncsctydJEtvsssyQe/lWy19DFCoTHjdTzo3SBtrnKRXKACSlTDpsxhel21Dn0G8 gbalYZa6m6uqTLDKjgUkBiL1tedsBmj9nTkRw1iOr6oPIR4iSCIxjEs2wCiCa+86U/lmW2ruoJc 6aFGC1ZQ+U6smEWulFbWB3SxZw7ktNA6PwsLGdfaBdMqMtdCTWOpoScYW+kG/FWur23zalV4X4Z ORKOhJDst/W6BN759PpUTD2J2PKm0/QbVr0Bv+daJeZjJm0IP/dPeIiNvbemJUu5ys2uhJv/fP3 gSSzvbAM8Lx2b+bxu9emRKXk371GWUmSLG1z67Qo+9L1BaugDUVERo1axxxLV4o/KQVxG7/xUyB JwpYNKiVwuHP46+I82CpHL/tOtKoOGwyrqU1HBfWs/Var7A3JpzHfXhLKfRdECVUpXDPXowKgLO 8hS+1P29sZijqYlWlxer3WgFO1Rb69vl+dEYZwMBjJpiVRjpd1IQ== X-Google-Smtp-Source: AGHT+IEVQx8sB6NEuDyNpChjzmxkOnJrEYSN+w7QdGbEZQrDRISastygm8L56l8ae3QxxfzVClWTZQ== X-Received: by 2002:a05:7301:3f0c:b0:2a7:760:2b49 with SMTP id 5a478bee46e88-2ab7e6a91bdmr2479816eec.7.1764704203092; Tue, 02 Dec 2025 11:36:43 -0800 (PST) Received: from localhost ([2a00:79e0:2e7c:8:eb2b:1140:65a2:dd2e]) by smtp.gmail.com with UTF8SMTPSA id 5a478bee46e88-2a9655ceb04sm56613186eec.1.2025.12.02.11.36.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Dec 2025 11:36:42 -0800 (PST) Date: Tue, 2 Dec 2025 11:36:41 -0800 From: Brian Norris To: "Wysocki, Rafael J" Cc: Linus Torvalds , Linux Kernel Mailing List , "Rafael J. Wysocki" , "linux-pm@vger.kernel.org" , Guenter Roeck Subject: Re: Linux 6.18 Message-ID: References: <93259f2b-7017-4096-a31b-cabbf6152e9b@roeck-us.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Dec 02, 2025 at 03:37:58PM +0100, Wysocki, Rafael J wrote: > On 12/2/2025 5:50 AM, Brian Norris wrote: > > Looking closer at this part of the API, I think checking the return code > > of pm_runtime_barrier() is a bad idea, since it's inherently racy, and > > there's really no way to control that race. On the plus side, this test > > is the only one that does it. So I can probably just go ahead and make > > pm_runtime_barrier() a void function, and stop pretending it's part of > > the API surface. One fewer weird part of the runtime PM API to think > > about... > > Yes, pm_runtime_barrier() should be void, the return value is a leftover > thing. Thanks for the confirmation. > > Maybe I can get around to that tomorrow. > > I can do it unless you specifically want to take care of it yourself. I wrote the (bad) test, so I figured it's good citizenship to fix it. And anyway, I drafted it most of it yesterday already. I've submitted a version here Subject: [PATCH 1/3] PM: runtime: Stop checking pm_runtime_barrier() return code https://lore.kernel.org/all/20251202193129.1411419-1-briannorris@chromium.org/ Feel free to tweak it or do it in your preferred way though, if you'd like. Brian