From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7553254774 for ; Tue, 2 Dec 2025 17:09:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764695364; cv=none; b=uqjkgtghO8pbRSrkAvvoNE+rdVnURNjqgQfxJKyEykn52SqMG944AVSR+Hi/AwKWwh7sOmYUy7vLt4P5YUhpJ31YmT9ChjAp6KERKoGl3+aPbiJQ+1vU1FX34OMepMX9/ams2KPaIdKXMeH6lZyahn0JT4WYUOURdDgEWjPpMKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764695364; c=relaxed/simple; bh=45MijeCikbLICClrSiN36MCZK5B0JwjpmGbgdSAYvuY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PcO7jr3GDfbE9VCh+W7t7qhnUqvCP5KG88q6o8S6ekRcA0HliAJ9UYFF7d3NeQZN8gHXtlmeVOhXFW9DmR+dtJCPTldANnFizvOErSN6q9gDooBKEeTxJS940NOwYVp79TU9+dqOn9iVsKP0qQcfcMZWEEw5m9Ww7E0JJDJ7q70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=PH/F4oQf; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PH/F4oQf" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-29852dafa7dso1010145ad.1 for ; Tue, 02 Dec 2025 09:09:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1764695362; x=1765300162; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OE8hvHCw3MFr7aZguM67044oyYLQlhCB1XpMeHQTUwk=; b=PH/F4oQfllFQewD9Ay9rugExZ3sSmPY1FUv29HXLcH43ssBIzf3h+yFjOEd+2d/LHo iqNK3o2fvrzbKLXLdKaMipdJj7HZBweKZbm1eh9U/LXBzBKEqIVWMI6D+3ozlBdK5piG Aelije6MchodJScij2Ulha7omddcVyFU8oY2aQt7C4uEiljW+OIs8dQ9Gtm+/27iMjwN +wdBHZuuCTD+hBpzza9cFo+GrGNGqiOTyEOrvHnDBJCkDx6N0PcyTXSi1Kts8IRemq3Q NB0ZhNaElDPvTGa/NPSBFXtHDndFdPLvaL/rxGrRVIuupi4ZLAlAl+PvkK2O9dYqaenT ur7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764695362; x=1765300162; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OE8hvHCw3MFr7aZguM67044oyYLQlhCB1XpMeHQTUwk=; b=ndVAoksH4S4FNJqIaqLyQFre6aAu47cZZNNUZMEF92WZi+9oXS/HopetPr7IVSXcJm FYOQUUYpgsLTIuUHA8XMSYhtchGlw+mgGywHlBZ0D5XkHZB2ShKKeblV8vKfKd9Vvp/T eJfgfU5/EUJC1R+jM2/F7ONLb41y3h8fkTxJ4DWfRwItobguz5JU/cAQPhTR2rgb4jxA gqU+ElRvyJg208Bx8GKnaG4tB7AlsnJo4qsJW4O5nwT0kCXLrg8ubW6X3A14pRfWsfzs 7e8OtxoKGgDqSAk64BlAJlAI8T54omrk1Asq21W/vYvfWYiCK0SrMaLFDuincmuWYBUY MKbw== X-Forwarded-Encrypted: i=1; AJvYcCW8N2ELqDDTkLoUHGaadMvyf28XUSg6APJzObeR5Sp5lBhuuhJQcjHpYjrS/MIPADkJjDvjv4FQRdjr998=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9lL10sp+tMdqdTujVZ0PDR9F7nI/3i+V2QPgHiOYTonfOMV41 kP+F263dV9yVVRkmEvx3+pdLWGUSkDUD3VkxZ9WGjZ5Tv1hFsNt3wvGWfdbkomYN/g== X-Gm-Gg: ASbGncvyZZYsMFR79+xAZglNqNvLyPOfuEuwIAm8jWjlUhZPjt5j+K7KBlAGQbe6+9l JdS3oEA+CL45VXTYsLXVtKbl91OaRpDtPIqr1zuTrlV6xQ5txI9wXpJIDF8uFR3x4qv5XDXdmzi Wd4iMbfkMCRQunS3KAtP83313/sVAbn91HRrq+zdWwrt7el/sYpHgFUVy85ip6Dvp5n7GMaoX4V 4LmIXsS6npgEkUQEi9sT5N5KrBDRZ6WioMn7i88hDP0iycnbGoaeHW8zEURk6yXxDLjMFHgz8ij 4DcBRxSh5EKcU3xUAoxvtG4zkVMbdog6yqDmeTOUhU5ITrEdtQH6FBxXNcEWQ2825G3IMssEzi2 FntVsAETC0a4EXq+vysnzbASeuJSsnlao/IvYmFrP4v+14McC5QibQWvL1y6OaJm4Nu9x75ZW/K B/Z66h3najo5DkjjrEwAg5LN7DrG5ao89CZTsU0dfByBBJyoir1w== X-Google-Smtp-Source: AGHT+IGn6qVIdCSHwhrPC1gJqwBrvK6krzCrgmGdVcVIh8pC0eWA+kD/oRIoY5s7r5uGCIuLAyh54A== X-Received: by 2002:a17:903:1c8:b0:297:eadc:3cd5 with SMTP id d9443c01a7336-29d648abdb6mr335365ad.15.1764695361233; Tue, 02 Dec 2025 09:09:21 -0800 (PST) Received: from google.com (129.35.125.34.bc.googleusercontent.com. [34.125.35.129]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7d150b68805sm17547149b3a.9.2025.12.02.09.09.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 09:09:20 -0800 (PST) Date: Tue, 2 Dec 2025 17:09:15 +0000 From: Carlos Llamas To: Sunday Adelodun Cc: Greg Kroah-Hartman , Arve , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Suren Baghdasaryan , linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, kernel test robot Subject: Re: [PATCH 1/2] android: binderfs: add missing parameters in binder_ctl_ioctl()'s doc Message-ID: References: <20251121111203.21800-1-adelodunolaoluwa.ref@yahoo.com> <20251121111203.21800-1-adelodunolaoluwa@yahoo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251121111203.21800-1-adelodunolaoluwa@yahoo.com> On Fri, Nov 21, 2025 at 12:12:02PM +0100, Sunday Adelodun wrote: > The kernel-doc comment for binder_ctl_ioctl() lacks descriptions for the > @file, @cmd, and @arg parameters, which triggers warnings during > documentation builds. Could you please add the warnings here? > > Add the missing parameter descriptions to keep the > kernel-doc consistent and free of warnings. > > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202511201725.ni2HZ2PP-lkp@intel.com/ The link for the `Closes:` tag should be on the same line. > Signed-off-by: Sunday Adelodun > --- > drivers/android/binderfs.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c > index be8e64eb39ec..47f6d1e5971e 100644 > --- a/drivers/android/binderfs.c > +++ b/drivers/android/binderfs.c > @@ -224,6 +224,9 @@ static int binderfs_binder_device_create(struct inode *ref_inode, > > /** > * binder_ctl_ioctl - handle binder device node allocation requests > + * @file: The file pointer for the binder-control device node. > + * @cmd: The ioctl command. > + * @arg: The ioctl argument. Can you please follow other kernel-doc format in the file? e.g. alignment, no period at the end, etc. > * > * The request handler for the binder-control device. All requests operate on > * the binderfs mount the binder-control device resides in: > -- > 2.43.0 > This is the wrong file though. The reported issue was for the drivers/android/binder/rust_binderfs.c file. Can you add the same kernel-doc additions to both files in your next version? Thanks, Carlos Llamas