From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C9AA1A262A for ; Tue, 2 Dec 2025 17:11:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764695508; cv=none; b=O4pcPsKy8suzhubr+OeMT7u+NwMS/mlgW9FD1YAk9QvltfwPkANPP8EisKDu8UDUIi9crwSTdnXkvpgylmui8F5ToTYlgjNAn+q1M64jI4612N0Lhpt+PA344UfbHsl3bvUpKZHcJYLyy03Mv+mkHA2lrt+Ph2kNTHlccfpQ+JA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764695508; c=relaxed/simple; bh=NlRtEfjmqJngOZiPtp3BkA0Auz2ik+L2+TB7ln+mJTg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uOqmv94bKKUscErRNIAMpWHsa2JwLTkU0JzDUjWRfjgsRm1oyIsJY/N1kBxxNI54s40CMV5wy5Ku+O1pqm+5KCn888Lg6yeExQEsowhN8rJmTrj4WWD5A6tlVsLzcVV0gDmGK7ggJfpdamNuwuRkH1a2YFH3s/RiVvWnE4Lwx14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=SpqqSuSY; arc=none smtp.client-ip=209.85.214.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SpqqSuSY" Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-295c64cb951so1061785ad.0 for ; Tue, 02 Dec 2025 09:11:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1764695506; x=1765300306; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=a2SmQzdPa569Mipnc8Fvji3wocLWE6hhRcSDli/sldQ=; b=SpqqSuSY4gzYs9I00ZBvZIkVQ8xjp028p1Ew14yEyNnUiNG+aoWtjNSAh/Q77Rj7ow XNIFYydndl7toVkqMe0HdBD2kj1AeDZD8S5ZzI7BM5czk13gxNB3Gf371V2tT/LPl47s xoj7ZE1rG8YcG6Sh++hTWmUQhEIK0JjgEmeoRs4m9JPk6+e7s8n46glAtcQiE86/I8+v FWLZ2KYBbyCAKzmJlRqa8wcDWikC/1m2VKpmaZ6ehrpcKqeDM1IrGwaKPvfsRFy9QAhA JlYvUsAks7akL4aWO9xR9pgby4anNgOrocfeB2lmM6fCfEukPbdRpnL+DvFSKCsMm5DW mwzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764695506; x=1765300306; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a2SmQzdPa569Mipnc8Fvji3wocLWE6hhRcSDli/sldQ=; b=nZkM7/jrUXZIuUdCuDL11O0Y4762MfTPXZ9KIom3pOXTs7RC6kOj7erFx9T1jAu0Cz ba1Ny5oO2qddfu0yPFQf3agIQB1HBtmN11lCwF0OVRiFZ6aFfMHFuAh/qcwBoaJfkudo fLMSnRTelv6n39oKMgkoExV8GW1MNfa+mQ2jEMe2c5FTPclrXyAL025SJI3R1RtMXqsz EWOV6LeUTkSvysRA7y+MZIbRU42zUW91EZf5arJ4hfqZLv7KvUC1K1APa+3uNLJGQHCw kx/U5kviLsXpUGOwzF5V4n5nqYN9pD7qIwvEifymFkRa1rRx9IoNxlhg3LW/NyuAwjY3 85KA== X-Forwarded-Encrypted: i=1; AJvYcCV92yqKbqgDl2MhG0EcY8KMnn1SkuLq2XTlTZ1iNKlrIG+J9U+qcv1VSyzhEHreCytJzNH3qYzac9Wiw0I=@vger.kernel.org X-Gm-Message-State: AOJu0YzDjq6+BodeXh1mjsnoK68dldFqE9OnxO3AxTy3EE4xvzgA+8sZ 5OmgBD5/aC+ak0RQSsVxZ5+c+C3pnK8HeVAL51VC16Mqc6mfKaEyhErgS08jqnC64A== X-Gm-Gg: ASbGncvkjt9zXHfNMvOR3paldQkwMcsfmAYhTPgqbinsfzuO+iXsrlb9VtKeFK3/yPa ku12tGuGd29ZncwjLqqDqyHfkpE94qkChbVSU4E8x9jdHNL08dT3wT6MPN9+l4EXi27rMkkHuW7 ipbuKtOK7S+NfD+c0kAAza0MBb+vXAOrgLNB9ZGLMPdGGx1SZDjz1HhhS69Dlzvo4g/CMRP0g64 BFGujHN7y5clOwETMYhWYwq2ZA5Y9DH8XcC8WMTdyQg3rhy0yHFJVvnftJkGVwyw45DNcgyh/Ti YgVDhuuAdhp6WPIzJ3mFo6zen1btqkkzS+c8UJLPABGKhQYGNw2/dT/JpfW+h/ogy4fGTZHeHkU JqO8nXQW0kyJyJ/p6t0EGzJ17uASHheavlBhKBsXPc95yTsv0Zifo3TVp8URFrQwrEm+V6hAPhr MuHd4jvJBmr072uxtJjyeAIg3swn1qCnb38H/lcoyDpZOAz6uid/WJZj8wEIY6 X-Google-Smtp-Source: AGHT+IGQATs7M+eeKshlxyjYti9Gf/nKtFGuAKmHJ/UOzDc80Sq2/zOORM/Dt7vPzhTo+0wiF4ueLw== X-Received: by 2002:a17:903:11c7:b0:26d:72f8:8cfa with SMTP id d9443c01a7336-29d648b3dcfmr244005ad.13.1764695505646; Tue, 02 Dec 2025 09:11:45 -0800 (PST) Received: from google.com (129.35.125.34.bc.googleusercontent.com. [34.125.35.129]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bce40acd7sm162686665ad.17.2025.12.02.09.11.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 09:11:45 -0800 (PST) Date: Tue, 2 Dec 2025 17:11:40 +0000 From: Carlos Llamas To: Sunday Adelodun Cc: Greg Kroah-Hartman , Arve , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Suren Baghdasaryan , linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH 2/2] android: binder: add missing return value documentation for binder_apply_fd_fixups() Message-ID: References: <20251121111203.21800-1-adelodunolaoluwa@yahoo.com> <20251121111203.21800-2-adelodunolaoluwa@yahoo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251121111203.21800-2-adelodunolaoluwa@yahoo.com> On Fri, Nov 21, 2025 at 12:12:03PM +0100, Sunday Adelodun wrote: > The kernel-doc for binder_apply_fd_fixups() was missing a description of > its return value, which triggers a kernel-doc warning. How does one trigger this warning? Was there a report of this? Can you add the warning you see to the commit message? > > Add the missing "Return:" entry to doc that the function returns 0 on > success or a negative errno on failure. > > Signed-off-by: Sunday Adelodun > --- > drivers/android/binder.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > index a3a1b5c33ba3..535fc881c8da 100644 > --- a/drivers/android/binder.c > +++ b/drivers/android/binder.c > @@ -4669,6 +4669,8 @@ static int binder_wait_for_work(struct binder_thread *thread, > * > * If we fail to allocate an fd, skip the install and release > * any fds that have already been allocated. > + * > + * Return: 0 on success, a negative errno code on failure. > */ > static int binder_apply_fd_fixups(struct binder_proc *proc, > struct binder_transaction *t) > -- > 2.43.0 > Thanks, Carlos Llamas