From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 044B52E8B71 for ; Tue, 2 Dec 2025 20:34:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764707645; cv=none; b=ovtScwdaKvBE05zWAAmDZWsxeAzAWSV0EVtUaNG/CKJi+Wa8sVYvQqZugLQVRR4W01yf43p/RA3JV8vRclRYqewRdqJvESD7si8y4ONeptzkkRTjjaNoeS7JFi/P91K/HEwmR/YK4Zq3xfAwp7mwXIdHLT/6XiuXjyBQg4x8Fi8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764707645; c=relaxed/simple; bh=Cf6b4+V9opVKdSSXm4y65skKTdpW57ouuA6/NZAkz9A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g2xor0Z7EwvlG8HOdZ/HgZgayOKMcAjMDY9UQ89uMJgCtgudRfro9otG5pei+07pxW4L1J3g6FqIV+HKq0KJw6BUwm49A27L0j3M3ZjspE0aAzErWD00HQZdBYTSumgJFYRCfcLnfBlH9GR7J38qe8Y9t8QiKVgktfp4xDaHEJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HMr75TkA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HMr75TkA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CA57C4CEF1; Tue, 2 Dec 2025 20:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764707644; bh=Cf6b4+V9opVKdSSXm4y65skKTdpW57ouuA6/NZAkz9A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HMr75TkANL7F961M1dO/iNCaIJhFpl3hAqGapApldoKEGQoTMvo0PLffblA6fUDHg y7AS+gioPIZ3vrr76LZ5vcXCnO2XNH04RAYqcH7R/kIsUyIIJp6GBHdnlRuEHhuBPu LjcVMDvquehHwSIDNz8V2daHPHek0yowK/mjFR/A1orD1n/5K5g3H6wTuJITutsyJe bdOoR52klw0VZ0+oD+hGd0RcDabm/xsTFsbkffItl8dLVTt3y0SQxm2G/hq/huxvPO FA6Yi6wcK/rUahjVZOB47HepRmIqKT5iR5tQVVetKGauo6NJfDUB+KV5GpdnPvtg7B I80dE06vCOprA== Date: Tue, 2 Dec 2025 13:34:01 -0700 From: Keith Busch To: Eugene Korenevsky Cc: Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] nvme: nvme_identify_ns_descs: prevent oob Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Dec 02, 2025 at 11:30:04PM +0300, Eugene Korenevsky wrote: > OK, tried to make the patch as close as possible to previous code. > See v4. Yep, I saw. Mostly looks good to me. > Also, adding 'pos += len' to modified `for` makes the line longer > than 80 symbols. However, checkpatch.pl says it is OK. Let me know > if it should be fixed somehow (e.g. by moving 'pos += len' to the > end of loop compound statement). The convention for this driver is to wrap lines at 80 characters. But don't worry about sending a new version for just that; I can fix that when applying.