From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ZRZP278CU001.outbound.protection.outlook.com (mail-switzerlandnorthazhn15011022.outbound.protection.outlook.com [52.102.183.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DBE22FD7D3 for ; Fri, 21 Nov 2025 10:34:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.102.183.22 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763721257; cv=fail; b=Suc7aveIHj5iIKulNbTV3xyyq2+V3Y2vxer6nURMcYxd48wWYWtfooWLK22NSbgAWqZ8sp8gxftoY7bCOJG7keBQUYoNKIa/nJ+CwIPORfxsH5ochHUk9tZjqOtLWqD8fQ5ikDOxEM/6cEB9sqXYmAOwEM/bJouiBLjxBNq1icY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763721257; c=relaxed/simple; bh=xSYuJVcnGev9E8VA5G2Tf/dHc09nYD+7Zuh4goAOUW4=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=gpwjuzMfAH9oAZctF6U5hkef8HaCICeDfQa8FWo8BRMGGaoj9XabqRALTvv3crPyRsNwQeZc/V694sb7+EMaoo+DnKsxNjRKtBi7fFcIIVav5jy8AEbmEoMPZWTjFk3IGbRnBKuh+RuXG5C0YmpUmw4W7MH8ri1Y6LMHD1bTQYg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=duagon.com; spf=pass smtp.mailfrom=duagon.com; dkim=pass (1024-bit key) header.d=duagon.com header.i=@duagon.com header.b=uzzSBEan; arc=fail smtp.client-ip=52.102.183.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=duagon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=duagon.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=duagon.com header.i=@duagon.com header.b="uzzSBEan" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XfHpCzhj1sc1qExmLB4fJIwSZq0773U2LaztTxGktaensMelLxqf6iEyPq9LZoDpx71R3IfAaoBXrJPnBaWiCDOQcin1cpDm+vdcsV9aY4nXd2n8iDOEV8Vk/p7+VyvuM6C5KShNHOupmqBlobHjHLCWkoxUSg6OQo5/bQ3wLv8ffau9G+58olRzK0pIjSBm19fm46Q0vlKXRcpyT6g5t6Rdf4oT71JvmnxPMxsHi3+pEwjY8LBwyjE5/Br356pkEkAGlR8CBIXWriwGERlI0xYG4LICKaobJpT9NWIdok/RVp2py+0P3iPKp2uRdC/wrgU/pruFZ7lF6YBjWTcn3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9e2T+YAikDJ3mLvGrNPccfhX4uTZFDUk2H2LefZInZY=; b=EGcJC4lBc6LcM0wPKNHkNFUsTWlGNVhcLCP3w1dJC7w9EO9raeKlq5XJrZZFsIq5AOY9xSuX89O64luJ4o7BCZNletpBKrn6P9TQkhcjPc/8YNLMv6HWxeTsFRy2k2mpKZYx3kczWmJFa6EcWa1urzQqn630dFgwpogTrB/tVCiPhjX0U7zGE7qO59heWvxcq7I5OBI+ZkICNS28YXw4wqpeYVb4Gld6WNGUkrztym2xL3kxcnVwQF0kFS4354scYSvZLDtVi3yS9Wim6pTlwVtXyWWIVqWZZvJv0tN6n4LoRG9QuW1+EeNTrN+cJWiNI36SicYTT4IXTP+sjeGNdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.93.85.50) smtp.rcpttodomain=gmail.com smtp.mailfrom=duagon.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=duagon.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=duagon.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9e2T+YAikDJ3mLvGrNPccfhX4uTZFDUk2H2LefZInZY=; b=uzzSBEanuoHRRP8J5z6K2L5ecolWL0HKQgh8b2gl3FLd/sIBXkONM7dkVhzc5cj8rmJu3fIU5k4Q2ldoFbqZPh1BFbG+eRoGE1app8OlFJXOEKUN+graioKIykk7HPT8ypo8VR7ZlQdZt4SeBI+4LsfJNOwnHU0qjOPkWWM/bVQ= Received: from DB9PR05CA0006.eurprd05.prod.outlook.com (2603:10a6:10:1da::11) by GV0P278MB0115.CHEP278.PROD.OUTLOOK.COM (2603:10a6:710:1d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.11; Fri, 21 Nov 2025 10:34:09 +0000 Received: from DB5PEPF00014B9D.eurprd02.prod.outlook.com (2603:10a6:10:1da:cafe::b7) by DB9PR05CA0006.outlook.office365.com (2603:10a6:10:1da::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.12 via Frontend Transport; Fri, 21 Nov 2025 10:34:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.93.85.50) smtp.mailfrom=duagon.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=duagon.com; Received-SPF: Pass (protection.outlook.com: domain of duagon.com designates 40.93.85.50 as permitted sender) receiver=protection.outlook.com; client-ip=40.93.85.50; helo=ZR1P278CU001.outbound.protection.outlook.com; pr=C Received: from hz-deliver01.de.seppmail.cloud (2a01:4f8:a0:900b::219) by DB5PEPF00014B9D.mail.protection.outlook.com (2603:10a6:18:3::284) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Fri, 21 Nov 2025 10:34:08 +0000 Received: from hz-glue03.de.seppmail.cloud (unknown [10.11.0.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hz-deliver01.de.seppmail.cloud (Postfix) with ESMTPS id 4dCWmJ2r5sz4wvX; Fri, 21 Nov 2025 11:34:08 +0100 (CET) Received: from hz-glue03.de.seppmail.cloud (unknown [172.18.0.6]) by hz-glue03.de.seppmail.cloud (Postfix) with SMTP id 4dCWmJ2RX6z1xY0; Fri, 21 Nov 2025 11:34:08 +0100 (CET) X-SEPP-Suspect: 942ac8e42ea541c8b9502bbd8a4fd38e Received: from hz-scan03.de.seppmail.cloud (unknown [10.11.0.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hz-glue05.de.seppmail.cloud (Postfix) with ESMTPS id 4dCWmJ1qwqz1wLh; Fri, 21 Nov 2025 11:34:08 +0100 (CET) Received: from hz-scan03 (localhost [127.0.0.1]) by hz-scan03.de.seppmail.cloud (Postfix) with SMTP id 4dCWmJ1bsjz2X7F; Fri, 21 Nov 2025 11:34:08 +0100 (CET) Received: from hz-m365gate01.de.seppmail.cloud (unknown [10.11.0.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hz-scan03.de.seppmail.cloud (Postfix) with ESMTPS; Fri, 21 Nov 2025 11:34:07 +0100 (CET) Received: from ZR1P278CU001.outbound.protection.outlook.com (mail-switzerlandnorthazlp17012050.outbound.protection.outlook.com [40.93.85.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (secp384r1) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (not verified)) by hz-m365gate01.de.seppmail.cloud (Postfix) with ESMTPS id 4dCWlt3YBkz2wqc; Fri, 21 Nov 2025 11:33:46 +0100 (CET) Received: from AS9PR04CA0048.eurprd04.prod.outlook.com (2603:10a6:20b:46a::27) by ZR4P278MB1971.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:b6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.12; Fri, 21 Nov 2025 10:33:43 +0000 Received: from AM1PEPF000252DD.eurprd07.prod.outlook.com (2603:10a6:20b:46a:cafe::4) by AS9PR04CA0048.outlook.office365.com (2603:10a6:20b:46a::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.11 via Frontend Transport; Fri, 21 Nov 2025 10:33:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 20.79.220.33) smtp.mailfrom=duagon.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=duagon.com; Received-SPF: Pass (protection.outlook.com: domain of duagon.com designates 20.79.220.33 as permitted sender) receiver=protection.outlook.com; client-ip=20.79.220.33; helo=de1-emailsignatures-cloud.codetwo.com; pr=C Received: from de1-emailsignatures-cloud.codetwo.com (20.79.220.33) by AM1PEPF000252DD.mail.protection.outlook.com (10.167.16.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Fri, 21 Nov 2025 10:33:43 +0000 Received: from ZR1P278CU001.outbound.protection.outlook.com (40.93.85.51) by de1-emailsignatures-cloud.codetwo.com with CodeTwo SMTP Server (TLS12) via SMTP; Fri, 21 Nov 2025 10:33:42 +0000 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=duagon.com; Received: from ZR0P278MB0523.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:34::6) by GVAP278MB0104.CHEP278.PROD.OUTLOOK.COM (2603:10a6:710:22::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.12; Fri, 21 Nov 2025 10:33:41 +0000 Received: from ZR0P278MB0523.CHEP278.PROD.OUTLOOK.COM ([fe80::39da:49d1:7c23:953e]) by ZR0P278MB0523.CHEP278.PROD.OUTLOOK.COM ([fe80::39da:49d1:7c23:953e%7]) with mapi id 15.20.9343.011; Fri, 21 Nov 2025 10:33:41 +0000 Date: Fri, 21 Nov 2025 11:33:35 +0100 From: Jose Javier Rodriguez Barbarin To: Johannes Thumshirn CC: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mcb: Fix incorrect sanity check Message-ID: References: <20251120113732.24678-1-dev-josejavier.rodriguez@duagon.com> <6b6e7d3e-7219-4459-b177-1e4123c531be@gmail.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <6b6e7d3e-7219-4459-b177-1e4123c531be@gmail.com> X-ClientProxiedBy: MA2P292CA0019.ESPP292.PROD.OUTLOOK.COM (2603:10a6:250::17) To ZR0P278MB0523.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:34::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: ZR0P278MB0523:EE_|GVAP278MB0104:EE_|AM1PEPF000252DD:EE_|ZR4P278MB1971:EE_|DB5PEPF00014B9D:EE_|GV0P278MB0115:EE_ X-MS-Office365-Filtering-Correlation-Id: f0b92361-ba0e-49bc-4e82-08de28e9810d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|52116014|1800799024|376014|366016|38350700014; X-Microsoft-Antispam-Message-Info-Original: =?us-ascii?Q?QLQ02YYywlCEU6QOc+cvpAbDrKxUroDPOcj80ngtZICX1y2Tc6cThVkqhdNO?= =?us-ascii?Q?9VQ0ZXpiMRC1voapZ8O7PkpNNKDt6wiDQQIVDh15HjMgtyaMwM/8pXIriEAg?= =?us-ascii?Q?9jxad0NADJb1YPXFr17u4eMcyafzlgK5A5U16BkV11S6SGIN9CGEPO+3KA+u?= =?us-ascii?Q?c3PeA7ATZauZjlHVTfcaapNpxW89oIaXcUFoXIiZPIb9jJeKaKpABh0JWb/s?= =?us-ascii?Q?KxjxOhbhwOwqrLdj80VpWDMREEpFwz78SOsjQSvO5B7uejvVo73nIhfBMr1j?= =?us-ascii?Q?ogUFrJ9dvQlpL1r0W/gAWaPi9g93ISGOVhiO+uA1iqi9c8DYUb6hlrLLGzFh?= =?us-ascii?Q?Re8LRgcP9v2P+lmc5h5lvw3IZTMbd06EP//Y43S307E3XYZiaCCNKVUyfSn9?= =?us-ascii?Q?lNBJ2dQPtl38QSxzxNnndsopF7tYMa7T8m3KhD0g/m8AU8HwOynvKPxgIi/S?= =?us-ascii?Q?iSs70kZDptErycW8/zKUAgbRHxP5pwxmVP5Z73Jyp/DpEjC0NaQPsuFLIdfi?= =?us-ascii?Q?Yv4y5qYlVCZ7CWDSBKuiVAETq26Xx7M1EkUA0Sd0p26pZ4WYRw5KkJePCWqa?= =?us-ascii?Q?gC386pu2DDpUy6ZIzWbzsbySIXX2c+xM8ifpcHgr8TGdsxdHSAge74xEGv24?= =?us-ascii?Q?koG99hSKcTADNCdDRd71W0BBuwhp5AxXg+GdJtv4wtZvKLlcWyoB8pqNPRhY?= =?us-ascii?Q?6yN9qyvX9XPwRY1h48C44MUADCK2EuvppuYyIFirixKOjZc/INP47gjhN7oB?= =?us-ascii?Q?j9VmvMQB+5vNSaEI3T+FByLJNSm6hn8Lze4M7q4wamwTGbH2we/vUtEdEIkO?= =?us-ascii?Q?QccKwkETheXSLANG+FKcy3i5qmGYMZkyBF84ygDe1msJsIzltD2oeFi6eTWj?= =?us-ascii?Q?iMHrOxCUyXKfek2x6nGm3PS9HpR0caH16WUybCe//RyOZ1SoJhRO37E67itV?= =?us-ascii?Q?A2dUieFOiW8ruOJyo3WI+TFYw15/Q/vOdavRBAuzlhjXmselEp2HYHSAZlJC?= =?us-ascii?Q?Xt08bhX4mRQmi1KybkKZxbIo+IppHyi7JsIV4k4a7WjMZEjDq0qZd5/NwTHx?= =?us-ascii?Q?pUBzB1kC0gP85RdMY879n0fmSIaehVEujmBK5MHLp21ROqwS8YKaGqBvDUdc?= =?us-ascii?Q?j/asZ7Hz8kJnS65rTwnCe2vJc4Xjc9dubQmUN4xQ826jcczEcYgYoALfQSEV?= =?us-ascii?Q?VBzp8kkiEINv5f4QV+jede3uf3L1YrlhWxAK084xxzfWa6YA12wdqPXZUB+t?= =?us-ascii?Q?0Slb3cTbPUfJrquEjthleqWKdc4NkeydiJkOjDnQQdI1D9uhJUHgfXHahYyx?= =?us-ascii?Q?LQ7PRQshekIWNBOKKOZa35Dc0eu7oUOSIYRi6QxSL61ihLf7z/nP2yBhqipe?= =?us-ascii?Q?h2Sgd9GDNNqm7s0FB/Z2DaCs19jkFS7ZZ5WHxqVk/A/i+XuEqBGRCx3enntu?= =?us-ascii?Q?lQEH8iNwF8sySILmn/QAt4ayHOTZAKHVnfLs3VDVrTFTMcYd6gjpMBwWtoC0?= =?us-ascii?Q?T07NFSJQpbArfj0mJrH09/HzDybq85+klqxV?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:ZR0P278MB0523.CHEP278.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(52116014)(1800799024)(376014)(366016)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVAP278MB0104 X-CodeTwo-MessageID: 4f2ac3db-6e2a-4f3c-964e-25b450b46fd7.20251121103342@de1-emailsignatures-cloud.codetwo.com X-CodeTwoProcessed: true X-EOPAttributedMessage: 1 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM1PEPF000252DD.eurprd07.prod.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: fcef4aa1-1435-41c4-8a97-08de28e9704f X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|376014|35042699022|14060799003; X-Microsoft-Antispam-Message-Info-Original: =?us-ascii?Q?IsWplFYQfDEyHlJT+3qvASoksdmpDnRdntQLTj1HHiD3AusraNQwbMgBh+Wr?= =?us-ascii?Q?2rCfi7cyjwrY2kBZFzyj+DGD8jJVrFb0JNdAYs7jxbHY7+/Q/TpI7ImyJ6XQ?= =?us-ascii?Q?8SyxZG+x9v1GA3yABYKvqsbsyY7P+0FlB53x++JVqRfNCX1pkNNvnvpC6URI?= =?us-ascii?Q?XEt9HrlYAF1me5y1Bd77du8X+v3LNcGUIYmzLC6N/6xvlxFXnNHrVP4NQrgL?= =?us-ascii?Q?q5sKF17qeDNSLYgQTVvi2MqaWsRBALoasi3pDuceYqFBJ8WMW83mRlOgWdUR?= =?us-ascii?Q?/dwvG/ACD16JWVLW1jloVGw3Y/saFI0D0fSZ8pIKcQXbvedi6pbqtjy0V6Hp?= =?us-ascii?Q?GoSa2L4hKjzIYuFBNUDfVT36FVIxFB0Dwnf7mANICf2VPQ3SssX8HZ0Xirr6?= =?us-ascii?Q?Gu99OSJiFLN1mFSEmrHiuV3qHanhroXaDxqEGye5mIJZ0d8grpiR29jGtFrZ?= =?us-ascii?Q?1RtApbK/YENJjZCRPIoEzNbKHnhq1L1LfwLwgmosOxqjo0OQs+Q0zKOHInSt?= =?us-ascii?Q?iJHa1E5XXkHka6UUNSwAOO0n9PXAdYsWpmH344nn/1HYhCzE5/GOJYL0DXU3?= =?us-ascii?Q?GnswhhlY5pXQWNfVJxf2sjg3jG/dZ/oFLg6cP9frg+hNfeCTXHH+P+JnDRBH?= =?us-ascii?Q?+LZ58Q3GVD/TLYqXaBRP21hzuS19qcRpEqNACgFhqIME4avczilRC/XdDPLA?= =?us-ascii?Q?dR4PJfH/2dnMQdy4u4vCunyqUdLBLUbBa+CJXpmx52tuXvORDyuF9kwFLKnh?= =?us-ascii?Q?+1il1AMaQFPvu8b4dnrE04lmqA4PScEB2n9AsCDzvYGBzAObBAmpmF5hnU2w?= =?us-ascii?Q?qOSndc3mLG2u4iSDYFVurz5cvMEl8Q2CAQ75bM2KPGbyCvX0p/9+04ShS3n4?= =?us-ascii?Q?UG7jDyHCh6LUsJliSRVibBux/p4VnELTEe6ytQSGcs2MsiGGVG/AejG4OqcD?= =?us-ascii?Q?ZOVsCaFcd9HrW+XwEHZaUwrs6ZzgnzkBjWqddERuk33YRiohrdTf3LNsBksc?= =?us-ascii?Q?mjTdSruiOQ62PKI0gQyO09SQEdmDlLeAh12ELm12Ae0c7Fedv91Z5hHg+wua?= =?us-ascii?Q?O5dwEsMPgj9NuLgyrBmwt5hgLDZs1gSlxV5pZKURSYVdYMsC7vWy8QfKU4t9?= =?us-ascii?Q?KZOmKvQRN4DI3i5rc3BvAKMoIpINqXRB6TsxAJfXx+EuZpRoZygKYaxZ44ae?= =?us-ascii?Q?4nNRJly6V/Gi2i8tIviSW82WzpZBvAkNf5Z79j9J4aHvvNy2+1hecwllNSro?= =?us-ascii?Q?XHybwyIHalWkvCiodqD1+g4BIheOU+bvOqBnM2x6+4x18HemLCMH5pzFnifc?= =?us-ascii?Q?+2IjaprrnWONcjiDDDYy+iJliAM0tdgp1Wzr1Ks26/2spB96cAtE0VUqJIiQ?= =?us-ascii?Q?+keTVXm0hrHPFSZYHx4dxtM1x0THjm3BGlhmwQ83AvokJNslMN8Nfj3xqwIQ?= =?us-ascii?Q?aU26PFr32vVgWDmxaFgEcm9Vl6Me/lcCVRCa/65FBKIxba6RDjg4Olza4Cah?= =?us-ascii?Q?NYWyOXWAD/B9cta6H+xOB4ZNiGiE24ihW1r9OPXtSM7IW1Zxga88WpD0+87I?= =?us-ascii?Q?kYjbeRL5GiXv6782QmA=3D?= X-Forefront-Antispam-Report-Untrusted: CIP:20.79.220.33;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:de1-emailsignatures-cloud.codetwo.com;PTR:de1-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014)(35042699022)(14060799003);DIR:OUT;SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZR4P278MB1971 X-SEPP-CCCVersion: 2025-11-05T14:36:24+01:00 6c313bee X-MS-Exchange-SkipListedInternetSender: ip=[40.93.85.50];domain=ZR1P278CU001.outbound.protection.outlook.com X-MS-Exchange-ExternalOriginalInternetSender: ip=[40.93.85.50];domain=ZR1P278CU001.outbound.protection.outlook.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5PEPF00014B9D.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c6d83fe5-8a86-4318-601a-08de28e971d3 X-SM-ruleversion: 2.1.0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|34070700014|36860700013|1800799024|376014|35042699022|82310400026|12100799066; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ZRpCyefDmichPr7k9PjvuneFH4ufzzE9/AtDKh/ZtFt6mqwNIn3ULV0GObRf?= =?us-ascii?Q?6b24ouKj6r/EBNvXV9eqfeoDkCcDA5mOvYMv/jri0cwdvXcLRxXonRfFsULP?= =?us-ascii?Q?RPsPtI614X23rYphoEg1ereAjILctKUkAutk+/N+hzOD6CafyCcJf3pJhj0s?= =?us-ascii?Q?9FBqropMKNA1HnB+o7H1/BPAXMqCJuHAmj+kMQi32XLwhPkwD8NjZPfOlHNU?= =?us-ascii?Q?oa1/0RCyYO4xAvCzugfEUHEd/UQ75iuzltuwiuJ3U01XZX1H3nO4NsH2/R8d?= =?us-ascii?Q?LalGSVwIlrUfxCXkV+h018ErJXuMdG9grF/IemfG7X4Y48xBkk2cXGpsJ3hT?= =?us-ascii?Q?87kSoIJpojNG3Dr4YnP5xavE9iyF7NDdFNVd8QxlF0F7nMCYTtMdKRirfMrc?= =?us-ascii?Q?VwORldHb7hsIVdCl70+A1mexKvB31JuQRU9VCnOX/RjrgZPB+YAnIb20Xesa?= =?us-ascii?Q?J0w6f0Mn9EVOPTDVmQyoItcGwEkD++5gyk4TXhl2VkA4UGoWiSlI+sFYASNM?= =?us-ascii?Q?VuN9EorcCSUiXksdtPgE8JB216z2VIp/Yd3W2HofXmnvobzKqiT/aWRnQZmk?= =?us-ascii?Q?MSQE2nnf7jiYfDYakA+gi1P164/2W8UoJy3Lcwf7B63aSV5kZsy95S4t/a0i?= =?us-ascii?Q?6CAERZ5v/4lm4q4DjaK+fLjY1Ic8L04Ya64+13igU81UJupzB85VRMqXP3Du?= =?us-ascii?Q?YO+0VvPzk/HRFV8sxvydbw6GQhO8tJ2I5la63hnn6oCTiA1lIDsR+6JIdQBE?= =?us-ascii?Q?XrfE2mkWaOd4ByA1AtK+hgzXGOFbcYSb5AeYE/8oRTxf0aQi/rImJKhIBEPP?= =?us-ascii?Q?V9qgO4MnRBSIrl9FwQi9+dz/kJX8iHWFR+06lFd/6KExAx6WXjiv5Mlv+7wy?= =?us-ascii?Q?eoHbwVYT7oxCXnv2QbGVFCvukKYW8I3EfZ88TC2j0tcPakNzN5Pi99Bkefyy?= =?us-ascii?Q?LvoYyezj20ynU1AvEyyT9F7Kfa1th3HFeUblnLHc+YO1O2S/tufrPXfKvIrq?= =?us-ascii?Q?8IsTQ/XiKdJdLYQ/3dPmn/ZkWSA0P0d9Oeg/rmlbMI5l4Atk/U8X4QnUHoS8?= =?us-ascii?Q?4jBe/vmNOWUPTQt+gOwlPriwNqu3C7X8+dJGThXyJr3NzEig5XBXOYUCzJJi?= =?us-ascii?Q?80mcOAP5gQMxAFLFIcERlU1uMGzO6AFsW30Jrwvbi4w3uPQWlgi8sY571OOk?= =?us-ascii?Q?ZYZTSKTqj94pKRXR2MQjQ4xtGBkLjHekpfRl5w4WG7yRjelD28n1WE7AoqNV?= =?us-ascii?Q?/xUkZO1UA4WKQ+jbZDz/1LmFXpyqgyRczVaN7KkNNkqMnzQimC+ECwZ6NsOY?= =?us-ascii?Q?0Vqu794qbn7FdPUBfs7S1K5IJPSsiFJkWIF6BYzLO4LkUGzGu2RwsXZeJcNF?= =?us-ascii?Q?+Di3Rwb47g2NfdaB4U09kAEyk5rILg8UUam3lRxtSJWXHVtS6R4IR8gDKCKE?= =?us-ascii?Q?qh3JegchSoUMhOUh945q3sqOb2QgDHO4+H8QfzpmxwnLO92QrBqvFi8MbL5m?= =?us-ascii?Q?PPNJsmsLQTGxvjJCT4F97apGuPcCHgcAY30ipPR6Y6LaRlzJRVMryvkMLw?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:2a01:4f8:a0:900b::219;CTRY:CH;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:ZR1P278CU001.outbound.protection.outlook.com;PTR:mail-switzerlandnorthazlp17012050.outbound.protection.outlook.com;CAT:NONE;SFS:(13230040)(10070799003)(34070700014)(36860700013)(1800799024)(376014)(35042699022)(82310400026)(12100799066);DIR:OUT;SFP:1501; X-OriginatorOrg: duagon.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2025 10:34:08.9520 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f0b92361-ba0e-49bc-4e82-08de28e9810d X-MS-Exchange-CrossTenant-Id: e5e7e96e-8a28-45d6-9093-a40dd5b51a57 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5e7e96e-8a28-45d6-9093-a40dd5b51a57;Ip=[2a01:4f8:a0:900b::219];Helo=[hz-deliver01.de.seppmail.cloud] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B9D.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV0P278MB0115 On Thu, Nov 20, 2025 at 12:48:45PM +0100, Johannes Thumshirn wrote: > On 11/20/25 12:37 PM, Jose Javier Rodriguez Barbarin wrote: > > __mcb_register_driver() makes some sanity checks over mcb_driver > > to check if .probe and .remove callbacks are set. However, not all > > mcb device drivers implement .remove callback. > > > > Remove .remove check to ensure all mcb device drivers can be loaded. > > The only driver I can see that doesn't implement a .remove method is > gpio-menz127.c. Yes. In the past gpio-menz127.c also implemented .remove method, however in 3bd13ae04ccc ("gpio: menz127: simplify error path and remove remove()") The driver changed, using now devm_* functions so .remove was no longer necessary. > > Is this safe? > >From the point of view of mcb bus it should be safe becase I protected the call of .remove on mcb_remove(), preventing possible crashes when the driver is removed from the bus. I'm afraid I'm lossing something because I cannot understand why these changes are or not safe. Could you explain me why you understand that these changes are unsafe? The other possible approach is to adding an empty .remove method on gpio-menz127 but I guess this is not the best way of fixing this. Regards, Javier R. > > > > > Signed-off-by: Jose Javier Rodriguez Barbarin > > --- > > drivers/mcb/mcb-core.c | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/mcb/mcb-core.c b/drivers/mcb/mcb-core.c > > index c1367223e71a..3d487d75c483 100644 > > --- a/drivers/mcb/mcb-core.c > > +++ b/drivers/mcb/mcb-core.c > > @@ -85,7 +85,8 @@ static void mcb_remove(struct device *dev) > > struct mcb_device *mdev = to_mcb_device(dev); > > struct module *carrier_mod; > > - mdrv->remove(mdev); > > + if (mdrv->remove) > > + mdrv->remove(mdev); > > carrier_mod = mdev->dev.parent->driver->owner; > > module_put(carrier_mod); > > @@ -176,13 +177,13 @@ static const struct device_type mcb_carrier_device_type = { > > * @owner: The @mcb_driver's module > > * @mod_name: The name of the @mcb_driver's module > > * > > - * Register a @mcb_driver at the system. Perform some sanity checks, if > > - * the .probe and .remove methods are provided by the driver. > > + * Register a @mcb_driver at the system. Perform a sanity check, if > > + * .probe method is provided by the driver. > > */ > > int __mcb_register_driver(struct mcb_driver *drv, struct module *owner, > > const char *mod_name) > > { > > - if (!drv->probe || !drv->remove) > > + if (!drv->probe) > > return -EINVAL; > > drv->driver.owner = owner; > >