From: Simon Horman <horms@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Chen Ni <nichen@iscas.ac.cn>,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/sched: act_ife: convert comma to semicolon
Date: Fri, 21 Nov 2025 11:47:34 +0000 [thread overview]
Message-ID: <aSBRVrb0ic5h9DEZ@horms.kernel.org> (raw)
In-Reply-To: <CAM0EoMnQqNwkdUec0tX4cznZk8teiPRx9iBv5Ff-MeSDASj-zQ@mail.gmail.com>
On Wed, Nov 12, 2025 at 05:50:36AM -0500, Jamal Hadi Salim wrote:
> On Wed, Nov 12, 2025 at 2:28 AM Chen Ni <nichen@iscas.ac.cn> wrote:
> >
> > Replace comma between expressions with semicolons.
> >
> > Using a ',' in place of a ';' can have unintended side effects.
> > Although that is not the case here, it is seems best to use ';'
> > unless ',' is intended.
> >
>
> IIRC, Simon brought this up in the review as well...
Yes, I might have.
But at any rate I agree with the analysis above.
>
> > Found by inspection.
> > No functional change intended.
> > Compile tested only.
> >
> > Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
>
> Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
...
next prev parent reply other threads:[~2025-11-21 11:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 7:27 [PATCH] net/sched: act_ife: convert comma to semicolon Chen Ni
2025-11-12 10:50 ` Jamal Hadi Salim
2025-11-21 11:47 ` Simon Horman [this message]
2025-11-14 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSBRVrb0ic5h9DEZ@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox