From: Dan Carpenter <dan.carpenter@linaro.org>
To: Hans Zhang <hans.zhang@cixtech.com>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH next] PCI: sky1: Fix error codes in sky1_pcie_resource_get()
Date: Fri, 21 Nov 2025 16:35:35 +0300 [thread overview]
Message-ID: <aSBqp0cglr-Sc8na@stanley.mountain> (raw)
Return negative -ENODEV instead of positive ENODEV.
Fixes: 25b3feb70d64 ("PCI: sky1: Add PCIe host support for CIX Sky1")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/pci/controller/cadence/pci-sky1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/cadence/pci-sky1.c b/drivers/pci/controller/cadence/pci-sky1.c
index 99a1f3fae1b3..d8c216dc120d 100644
--- a/drivers/pci/controller/cadence/pci-sky1.c
+++ b/drivers/pci/controller/cadence/pci-sky1.c
@@ -65,7 +65,7 @@ static int sky1_pcie_resource_get(struct platform_device *pdev,
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "cfg");
if (!res)
- return dev_err_probe(dev, ENODEV, "unable to get \"cfg\" resource\n");
+ return dev_err_probe(dev, -ENODEV, "unable to get \"cfg\" resource\n");
pcie->cfg_res = res;
base = devm_platform_ioremap_resource_byname(pdev, "rcsu_strap");
@@ -82,7 +82,7 @@ static int sky1_pcie_resource_get(struct platform_device *pdev,
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "msg");
if (!res)
- return dev_err_probe(dev, ENODEV, "unable to get \"msg\" resource\n");
+ return dev_err_probe(dev, -ENODEV, "unable to get \"msg\" resource\n");
pcie->msg_res = res;
pcie->msg_base = devm_ioremap_resource(dev, res);
if (IS_ERR(pcie->msg_base)) {
--
2.51.0
next reply other threads:[~2025-11-21 13:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 13:35 Dan Carpenter [this message]
2025-11-24 18:08 ` [PATCH next] PCI: sky1: Fix error codes in sky1_pcie_resource_get() Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSBqp0cglr-Sc8na@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=bhelgaas@google.com \
--cc=hans.zhang@cixtech.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox