From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D622226AA88 for ; Fri, 21 Nov 2025 16:07:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763741262; cv=none; b=p4FJ7kAOi/VXJ5IcSutrBTNQtzSrekdT5dQjU5EBTcOMCeSGbvsema5kpU5Jc1NTYY4oXHCm9NnHGNSr1vC7VulEo9kVrKSm+SHnpCsgGbE0AWrk9TBpksWcX1I4cIZsJIzB/BozWHTLat4mofQ7S6IL7HSZAK4Se6t57btrp9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763741262; c=relaxed/simple; bh=wn6owfeRxRPe40xy+DXQaKR93Rsr/G+e6Zx6128A82U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qPkt04idc+tElKHbYPse4N7zVthr6qFsJ/xglnJbfwUCA5e+lLFq/1/3usbIXN9RYffXefRR9jO2Ga6K4nHk8yK67vx9dgEAhwRqQ6oMWbC3+c+O7746Ste/297mYpdjpEIKopHUDWWOSR1Y0NFWagr470k9bqyLmjZs7EIJGDU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=TVwkFsbL; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="TVwkFsbL" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-6419e6dab7fso3129192a12.2 for ; Fri, 21 Nov 2025 08:07:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763741258; x=1764346058; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PnOOycxNF5fyRZhcK18TYLex92SaJsAfVif1Pw0Trgg=; b=TVwkFsbLT0dOFvWR7V8y/ZccEe/9TIXKXUz+ml+MH4NF0ynFvvjPrMnNzuC8dsy4P1 1AihgzYX/CEoEe1KvEwRdFYoTtRNJEhqGUoQArL64rzWnZ66kM5LICU6DxnF9JbhocbH 4cBracFf22PDoK6uAMuSWst4Wca22XUh12s4lVxvHgdVAwXzKbtqOgq6QGSd09Pj+LRy fjCoN+lH22sU2ngU+o7ZugTZ+RZ5mZmsiEjVAsVefElLEUjalojOCrkWjXdGAwzII0X4 6nW6wUjlzIk7HlpjWVXp3g7Fe5m9Wu+rOXucg7bXyC2Fh5DwLiroAyzeVNVqTl1HzhmF 66YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763741258; x=1764346058; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PnOOycxNF5fyRZhcK18TYLex92SaJsAfVif1Pw0Trgg=; b=sQGxvrtQoUiZKxrqzHnKtwhNy9l780xYPkajKb8M9TW9ibWCEtU+mIldqNKb1UtJpu J7dgM7XnX++Dxv8dec/+xofrtQAks+MOEjge5i/zVUeKGLDre1+QvPLz0xNMs0ixyqA6 41b06DdHhbis/waf6RxwWUKk5Fb4QNlGGfNnm/P80uAzM0o9nlFIPEdb15MD6RRFs++g D1AuZ4BafvAXFxad2r6W4URNuXvEzncmDZNRT3Dgj7IwwZJpnK7ioRz+BAS5MyrdRn7i DlbJjtEyNHmWMc8UVsuqTlH8+JchpMEz6f/J+DHwsVYsMfHYhkDlbB8atxffeEOsrG9E PIxA== X-Forwarded-Encrypted: i=1; AJvYcCWVV+NX/TcGcfrnKyL6me9vGauShyAspu+GRwVW5MdRayOkp/qwTGyMvu0Oak4Dgk5tiIlHPNF0WNGP3k0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/OJIEJfhPLE3ZHLNejiuQr7SSA4zmwRANAgfCKB/Px3ZXH/UV J3XX8BZWtVpf+m6QeQA0j8FGp+Yxj5DXT7Qh6UtTcwDhrBa+Chw0NEshoqo5BFvqaPI= X-Gm-Gg: ASbGnctue/AfrVY76JLIqrnLVUeFGYmu0Dj7fvMR6Jb8HxYdAFR+urwLNB3OvxCBWEj okSAVDuFuAV5bEunFUNMaV0fXj+WsTdy1LHxgni/s0eYr6nY2hoaIvXBxTy3K0lCxc3AQmX8Pif KeLyFI3c9krOpXAsVbZdO8pgGMEtDrpNq5e9pTNgfZqayp52xbqxmprW8X1FSShpY9fSkdr2L43 12Y1Xcwo30wUj1EL56PHo4pZiFPmx0ARke+XQiTB1u/q15ePjSR6vVHMbk++0laPZT7q2eNuIW9 kgZT90ydAIbKgitmVFP87EplSDML8PNMnn4p6PqXHpgTe5vdtKGsd9/SB8f/jkI8iB514oo6C+P 5AW3ZgsFPhKTYWnIlEWD6y2RqJai7aFSjUkHECq/6T+qouQzd54oqJJGI8F6HJXiVAv9rhvOPJi YH10SQHV0A4x/1aQ== X-Google-Smtp-Source: AGHT+IEtEoguEHPGYvq3E63Klx8ryrzeA4TW7G6RMp29+tfF0QVe0Rg/qVVe8p+SVRLWVGLu8CSVFg== X-Received: by 2002:a05:6402:534d:20b0:641:24cc:26d7 with SMTP id 4fb4d7f45d1cf-6455446791emr2237886a12.14.1763741258105; Fri, 21 Nov 2025 08:07:38 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64536443784sm4740404a12.28.2025.11.21.08.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 08:07:37 -0800 (PST) Date: Fri, 21 Nov 2025 17:07:35 +0100 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Sherry Sun , Jacky Bai , Jon Hunter , Thierry Reding , Derek Barbosa , linux-kernel@vger.kernel.org Subject: Re: [PATCH printk v1] printk: Avoid irq_work for printk_deferred() on suspend Message-ID: References: <20251121102010.359369-1-john.ogness@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251121102010.359369-1-john.ogness@linutronix.de> On Fri 2025-11-21 11:26:00, John Ogness wrote: > With commit ("printk: Avoid scheduling irq_work on suspend") the > implementation of printk_get_console_flush_type() was modified to > avoid offloading when irq_work should be blocked during suspend. > Since printk uses the returned flush type to determine what > flushing methods are used, this was thought to be sufficient for > avoiding irq_work usage during the suspend phase. > > However, vprintk_emit() implements a hack to support > printk_deferred(). In this hack, the returned flush type is > adjusted to make sure no legacy direct printing occurs when > printk_deferred() was used. > > Because of this hack, the legacy offloading flushing method can > still be used, causing irq_work to be queued when it should not > be. > > Adjust the vprintk_emit() hack to also consider > @console_irqwork_blocked so that legacy offloading will not be > chosen when irq_work should be blocked. > > Link: https://lore.kernel.org/lkml/87fra90xv4.fsf@jogness.linutronix.de > Signed-off-by: John Ogness JFYI, the patch has been committed into printk/linux.git, branch rework/suspend-fixes. Best Regards, Petr