From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B08423F417 for ; Fri, 21 Nov 2025 17:43:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763747008; cv=none; b=bUGaWLdkw3VMvdyu9OHsNtHSPkLOHfuxuJpELuc+eSiZJ3Nlr19AqT05reDAWgfTzz4ilzCESuWwzzyPrI3ERtxQ8SpC+fIpn3jvztuN/DMcJrwBWLePE7ugMRjp7ar/YUsJvnaARBfn6sXC6wN/yl/vAD80YbNAe3Sln69oJcg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763747008; c=relaxed/simple; bh=y62j1qyv7cgXLbtLXC53Pk0kooT7stT3fh5DjyrzJJY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=akAGdyiI1ks7QTk27/VA7ZHrsKIHYl6jTmvaIE41I6fe+EbVmIPdTJFKtEfW5EqC4QO7Bpbmvgl7CuELwnxttV5yXrHC+kk+qXlcL9la8WQHa1x23CEDdRwrmbOYUXMiH3ncqi45Q6js+xTODmY8PAaUmoqm5QBYnduX8suw0yY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZrlIEZxL; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZrlIEZxL" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-47774d3536dso18414425e9.0 for ; Fri, 21 Nov 2025 09:43:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763747005; x=1764351805; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DymXmqpOIrcn6HBsb6WiDUl4fGGkTlxCMuKU3m5KUbc=; b=ZrlIEZxL2Izo24hLTe+h5TWXYnatSLxVAzBWsxwCcmxdwk+x0eXXxGWJ7pfNgAZCEM NTN78O6KsRamILfzFnYmr4fqbe+dxGmJcUQuEaedGAaFgE1gH4MTzOO+JirDZOVqxxqn guduqzh3dghy9poZpBlNAPelGvktOntIpyO98aXQBT1Nm64vN2s6RngwKElM6fjBuOFL Hh4NYPcdBuX8j5HmQ4YB5IQBoENnt7pc062HrsqXGjAOWz6RqcMjjYtb622guV+kgOqN nWCZaETtrl/naXpTnlJR/LOe53uOJbgczQmKXbc4u5vIXWagafmzxpNfR/kcPbbG0vE5 Jx2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763747005; x=1764351805; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DymXmqpOIrcn6HBsb6WiDUl4fGGkTlxCMuKU3m5KUbc=; b=llvZOBw4LvmFIRqmAMi5TdVaIFlnVG7H9V+9C2a+VzsRsC86w6U89G8g0O8z9anifV lMOLSFpAcUxGV5DB/REVgB6XB1ihpseuYtcTRkNyA0rcbyg6OqWiH1kAMoqBDCLI4voE rUALxYKyg/HPzDCNeLwKtgmlNgqMUaZ3e6UnmZ/w8ZLsPafuYKRFEh6zWgfaObQN4fAS p4IJbtTzNQ2B2U1ABnXCjU+BRyMQwPkNtCqSQMHVXUsYk16hO71ONRJb9pODS3qmsx3V dGPSLu+q1UUH5MUTaV//dVHbhtY325yUTq1WfUoXHBPQYxEJK0TTO76IetxGqTsLY5y2 WoWA== X-Forwarded-Encrypted: i=1; AJvYcCX9hbYpTZRd+PSYdkuVC4j/0Ob761Ob63q3zR9sK6dcGhXgu6bjnM3r3j3jfbtl5GL4jSAbdG8vfJZOv1A=@vger.kernel.org X-Gm-Message-State: AOJu0Yxz3YXKz3ZGAKrllI9uWflBdmunk696RnIF2gV9QqHfakTGUF0+ HH6LB7fsdTrmJ3jCkYWq7AjOSJ2FoL9Gl8kBsahylPkSLMHNozv9unPZqVvSqVK178gvzI3PrOY 3mC1T X-Gm-Gg: ASbGnctEF4soLZlnQMBmv9l/USafFqMXvyxqhCfRqTTXNd1dxe1GBgj9zJDQhEVem7C kt3Mbr1F59xSORah68w7s3GouPbfW8KiyFgEJoPkROaCccovIOTimFQpwymYMcy7YPGXBpFopeh N5PM3wTSmCw5CEnYBCsWtHStpu5DUmqR678fGy8nL5ShD7owAH8Ua4xb+ZxX0JICF/4DKxAJTHh qhgUv7umw3pXKXGI99n3MPbCwbDX/EvvMaIp1UAMtJ/jzyGSB8QT6WtcexOBpNnIAe+UiPc7kCW 3OdvzsYdcFqiHuP0/1hGDMXlJ393Gtf6WiqR6Zxrn33chbEHvpLuGPfhelVcYMdRlTpQYOnaT9x F1VCe2tomyQaZezOUTQP2CxQuN9B9Ppoi3VvbpsKDkAIR4dsWB+UiKdRjBWce2tannSineU7UsL aGRX/HmxZmOunQ+aCS X-Google-Smtp-Source: AGHT+IGFQsvgqlLXjo1LFzfHENKzKFKxBi/jQaStpJz5QhBM3ftqg50gqcC3p5JGniMbhRFFXcSeNQ== X-Received: by 2002:a05:600c:3b01:b0:475:d9de:952e with SMTP id 5b1f17b1804b1-477c04c357dmr30706095e9.1.1763747004919; Fri, 21 Nov 2025 09:43:24 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-477bf22dfc1sm55987425e9.12.2025.11.21.09.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 09:43:24 -0800 (PST) Date: Fri, 21 Nov 2025 20:43:19 +0300 From: Dan Carpenter To: Luis Henriques Cc: Miklos Szeredi , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH next] fuse: Uninitialized variable in fuse_epoch_work() Message-ID: References: <873467mqz7.fsf@wotan.olymp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <873467mqz7.fsf@wotan.olymp> On Fri, Nov 21, 2025 at 01:53:48PM +0000, Luis Henriques wrote: > On Fri, Nov 21 2025, Dan Carpenter wrote: > > > The "fm" pointer is either valid or uninitialized so checking for NULL > > doesn't work. Check the "inode" pointer instead. > > Hmm? Why do you say 'fm' isn't initialised? That's what fuse_ilookup() > is doing, isn't it? > I just checked again on linux-next. fuse_ilookup() only initializes *fm on the success path. It's either uninitialized or valid. regards, dan carpenter