From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 018262F0681 for ; Fri, 21 Nov 2025 17:51:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763747514; cv=none; b=AeIEG96/nSphfnE7XO/Y4W4RwnRnxKRsoqPikUkBB8ozxPDpCX/1u0nC/i8QDHTP3Po9GPOASc97D3gnIJG0Z31nebfNT99fuTX3kgkizDK56YwwkglmMdNs5p2Ksc1zzotJMFaqmMEW8aakP7yEjKQhYzhlsfp+oEUtWXDi9Lk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763747514; c=relaxed/simple; bh=j79W1XyLkc2cQk8yvBCv0HIy2fTbW2KPf6ds/HaH9yM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NUq2UGFnVndAhg7bkm1/cbE1BgZzOWTKKuvPATmo4LO6FGYfac2ZeME+Fpj7qfirhHFZBB/c3yKCXrcYydYX/TMSz7kAYBiSDNZB0IrKBJGtZ7xIae6eMeQ3hk+WuuIZpDRtDS9T0CNVmRn4fn5mb3WOD8m3WVACDO+5nHomFcY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oIPkldrw; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oIPkldrw" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42b32900c8bso1397470f8f.0 for ; Fri, 21 Nov 2025 09:51:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763747511; x=1764352311; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=mgij7jlSeeNtSVewK3YJWmAW8IZcuGiNJDGAyt5nnbA=; b=oIPkldrwA7J8tXjqkEwMEfPt+f1aVS5opjvxUeTcYyTx+QBqh3Tgf3dHugPBvfBEmR 11YH2l4w6xlksauIZCW2ZqbYch6hKqt/WN8cQoMX4YyGKehCfZjWpr1cXYw79XSnSwrH kN10cIN8nyLe12S8miEmdYOvNkPpiQmXBXstkqukP5eIdLRLofehPbq2driyxTUx+PV4 Akf+t+mrAiEsLMvUswey39E2q34pJvQbZ1k8ATqE8P/dReuxrNMux6CRIyBm0gNlFIcO jOrwjb9c9Bc+r3vPxhBvxpric9O0eCPICDKdgGumybO8F5sOgdNiw+01xBRjJfpgu3PA lB8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763747511; x=1764352311; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mgij7jlSeeNtSVewK3YJWmAW8IZcuGiNJDGAyt5nnbA=; b=nq8DeP5yWmbDmRXwzgRHJUoU65icuwr/mu/9KGuMJBwRbYfJ5LSbVmoj9E7lby3d6v vQshC3SA55gbApehY2JIrok7K4TEpZWOWzNtDaApYdU++0fT4u9altgnqO+Rb5nUZPOY 63wl3NIggrkRyyI0MKgP9U3+CrzCJ8l6dVwzG/jKxshzGROAjqejn45Rgry3sfXWy5G9 W470ZtuRTt4K4CYzKl/pMifxMgv5V4MLm5z0hSQLYTqLIBF+1sbVrMecXE5se7qOWVUk HUO7AfsAtxkq9kIDfKMM9XFXX7ya/dmBInMIgFWUBUQDnRp/VCHM/IMJO/T0NrNaOMQ1 IXvw== X-Forwarded-Encrypted: i=1; AJvYcCW5c406hUfD4GhaAke/qIl/q4636aT5cVYdQ9MUHhGMP6q85qu1iyysm8uNPFExS+q+P3piPlAOjIa5M5Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwM9AS93lW5J/Fi866Ajsrmw1BT1F0EHCXvlNY0XA393sdh8wDZ pf+Wd5EO0F5W+Uvz8Tk6T4kYn6gl0cbj8edSjJzAbHb3fsmQazGlsutOto7XM3Gt8A0= X-Gm-Gg: ASbGncuKCKKwA+SL1o1HHW+MRS0o1EF12h7KVlIUH10OUTAsHqTBorIEq2BY+CmkQdX 6pqeWgY/frop4bdCF8tVcEcYxzsEkbogovxe7Lio3eUvfdZwyKGT4YvteU5INKkOC7eolkQwepJ FFSLSi8hKcBra+CFPc5HZDaLTIKvakiwNRuZYR1SIqtuHYgBozRr5lcGN+fnCbBvBm3UbaMe38u IWyzzdiIhZrMXecf8FeD2AmmvkyXjMTrxXjm/BmkfNG/anGRC34P7CiPVFDgOmVwv6EsUqevWj7 U3pj3Wdt/3aWqVWZI7cl35QrVu830XF1xWg6SLt0c7gZ4Jo6uPSFDeNL9DD5y0pjTdcdwLcl87h oLuub/TnwuKCSx0pPUkfW81BFOU5dIJU6tc5MP5P/f4YnX6WqUi543T1C8D9ZajzhBdDhVd6IC4 ap6pEOxhpg0PfxBEgk X-Google-Smtp-Source: AGHT+IED4J1eKGNDzGdZCS5b8bNqyTBjdzOFb1dzYZ1eI+fVN1oo8ZfJwofBTEhCKrfZm3+XkNeYXw== X-Received: by 2002:a05:6000:40cc:b0:42b:3cd2:e9bb with SMTP id ffacd0b85a97d-42cc1d2e29dmr3229968f8f.32.1763747511226; Fri, 21 Nov 2025 09:51:51 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42cb7fd8baesm12240013f8f.39.2025.11.21.09.51.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 09:51:50 -0800 (PST) Date: Fri, 21 Nov 2025 20:51:47 +0300 From: Dan Carpenter To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= Cc: Qipeng Zha , Hans de Goede , Andy Shevchenko , Darren Hart , platform-driver-x86@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] platform/x86: intel: punit_ipc: fix memory corruption Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Nov 21, 2025 at 07:27:54PM +0200, Ilpo Järvinen wrote: > On Fri, 21 Nov 2025, Dan Carpenter wrote: > > > This passes a stack address to the IRQ handler, "&punit_ipcdev" vs > > This first part I don't get, why you think &punit_ipcdev is a stack > address? The punit_ipcdev variable is defined in the global scope: > > static IPC_DEV *punit_ipcdev; Ah, right. Sorry. I thought it was a local variable. Yeah. Let me resend this. regards, dan carpenter