From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A6E2239E6F for ; Fri, 21 Nov 2025 17:55:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763747754; cv=none; b=YuDHQ7t/fRnoDMuW3RJVccpntD8YdYWM+/ShDB9s8oQloii3y6a+Pi3HO647fpj9vB1I7YyCdSRujHZsaXge0BcwPyfVkFmxMXiLL74FBtMXAEYmeWuIBZc9LX4854e+BHETsPlZk0RxmD/9w07EDOa58NufVR3umL66PHGDpDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763747754; c=relaxed/simple; bh=tEJqq7Rfs/EaLLTLsK4fB83SVwyDPP1g2+eZC5Cw+Kc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cUHQ/YctmiX2DLcI47nQFU1TXRpcltjGXG86gusaNnw8GynCwBnfH4Gt3fWc45n4NMf0QY6lFpeG8VqUG6ij97BsBzwLl10c7AbzoJmeUTcbsbjte2MgUvomG65JDsfsiaVsJZ/Kx7zMMkzOyKoBO0t+OwosWAanF0nfBV/K6GQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=xrZc9o9u; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="xrZc9o9u" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-299d40b0845so36415765ad.3 for ; Fri, 21 Nov 2025 09:55:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763747753; x=1764352553; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NOczehve2+cnsMUNrag+s9SdOyzwCWr1O+HoNDArIDs=; b=xrZc9o9uZ73ur5+Jz10sQx2w5OtWeLFN2CheHzkAaBMA2XCJP3BMPAmW9JY7+WZXwA 2nJqTB/JlpXob/eryJ2Izv4wdZ2sJhaYLYfFsFpxRS8ZEK5d1DIQrpJXhdATr+Ax9wxC bsH0V9lbVUXvq8xr3Xt5Rs5Trnv9igjudux5yd85lEnZ37S/Sssdgxa411iT29uZNg1M WSfrp/eyRV4dox+AZsYbaZxnSKG9sFgpHlgnDWE5+qHtnu5p+PdXuMIEk3P7TiuJV+1f T44nKBPckO5R9/5ZbM6p0bEANCkL1qjC1e0Fa/Bo/3Ya1UMskzakvVmCIecXbaAzVEne vrGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763747753; x=1764352553; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NOczehve2+cnsMUNrag+s9SdOyzwCWr1O+HoNDArIDs=; b=HJD6tNKfeXVhT/kCIOvt/5WnJZHscJfUkkpFGvnkGjeLr83Zpr/KJFDc9ZtP1f5v64 e1Gxb7Va1EmjosLeF7/zHX1PmomR1RNAJuny1QjvFFGibjfZCw8GjvjXIwVeZmoX79Ot SBjp3sGIqs7ZJrAg8SKfT0CVCkmqbCXm9bA3kgkGsuCcBnC1ZCx8YRjDvled90QqqZJb ZZCVjkDIG45veBwkF98bLYA1ri4YnBx7kUWCMcwO/C2Hw+Qz/4Cu+cApVfs5Ackx1l/4 CHeqc8gm0kdavL8gnFc/CJbi/3jTDKijQU4jZBZye0jC0jqqvAPGRd7iJ80cnKSi8HOn Xbxw== X-Forwarded-Encrypted: i=1; AJvYcCVJqy9uBor69DI+qjb9Cnfqv4dMxl8FBUIax3DQIKtSRu9iN8wb2UC50Q/CJ4jvrOXMtSkAugygVKVv7cs=@vger.kernel.org X-Gm-Message-State: AOJu0YyL9L/C2NM5uAvGFB+l8vAUJ9o5CByRw6apTgN0dAiMODCWn1RY 1YwxMcHov2t5au2wppE5/waLVwzRQqfBGuAX3vxCshtQ48LQor3ygQ54V2NV7AEHuA== X-Gm-Gg: ASbGncsKqJ8ZJsIzq9b98jKk/ZKKqVdiYhy5IlWGfQthXZloXoOe0XE1skOGSCBe2Fd FArOR8CLprf7pRV44I62ZhmzaaZizKkHAZuEsFatTEcSWV8Mqe4SspFmsucvH4GPJdS+6VRTa3l gGGETpZhuZXpwxZlslUzVmSzFoJmVev38pVZIZUO9M/jtTQ63/iH9rMq0kq97ean9q+1ycVEgiC cWD5kNl3Jeh0FFfPFei/BJtaiSLvwovvEI72lTLfkyaeopV/x/GfBH6Knbob79lPqnRiE9BwfQo DwF9cpDdnPuUpjFwJfOqUXF3tLRknudTuzqSau4ZSUcerM6Qg7ApGM9VJu+PzBq0Y/muuf8Ez4q U+6X5jFj+RKuXezEwXmrwSzk4UJNgV6GLOaF/keVJQxDlDuVODAoon++AxQ1AjateWrkVTiDMnX bbCeITIdPtNGoIozrdol3KyneasjrPA+lr1JYGoLbbqlC1+zRGFRVSTZY= X-Google-Smtp-Source: AGHT+IE2W4u9IOFJelWNiCRMfwPVNTwdUvO0tURMAaL/pRmfzeXyfqcqSuXHOyjy9NczAMIsi751Tw== X-Received: by 2002:a17:903:3c43:b0:298:1156:acd5 with SMTP id d9443c01a7336-29b6bf1a67fmr42515655ad.39.1763747752665; Fri, 21 Nov 2025 09:55:52 -0800 (PST) Received: from google.com (226.174.82.34.bc.googleusercontent.com. [34.82.174.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bd75e6c6ad3sm6145258a12.13.2025.11.21.09.55.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 09:55:52 -0800 (PST) Date: Fri, 21 Nov 2025 17:55:48 +0000 From: William McVicker To: "Russell King (Oracle)" Cc: Catalin Marinas , Will Deacon , Daniel Lezcano , Thomas Gleixner , Krzysztof Kozlowski , Alim Akhtar , Donghoon Yu , Hosung Kim , Rob Herring , John Stultz , Youngmin Nam , Peter Griffin , Tudor Ambarus , =?iso-8859-1?Q?Andr=E9?= Draszik , Conor Dooley , Marek Szyprowski , linux-samsung-soc@vger.kernel.org, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 0/6] Add module support for Arm64 Exynos MCT driver Message-ID: References: <20251120184242.1625820-1-willmcvicker@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Russell, On 11/21/2025, Russell King (Oracle) wrote: > On Thu, Nov 20, 2025 at 06:42:28PM +0000, Will McVicker wrote: > > This series adds support to build the Arm64 Exynos MCT driver as a module. > > There are parts of this that are just totally incompatible with it > being a module. For example, you can't register a replacement udelay > loop after the system has booted. > > This is the second time I've faced a patch series wanting to remove > __init anntations to call it from a module, where the author has > clearly not analysed the code to see whether that is a valid thing > to do. This is unfair on reviewers - it is the submitters > responsibility to check that what they are doing is valid. > > Moreover, in _this_ case, you will have received a kernel diagnostic > message stating that the call to register_current_timer_delay() > was ignored, so I also question whether you bothered to run-time > test this change. Sorry for wasting your time on this due to my lack of explanation. PTAL at my response in the other patch set. To address your testing concerns, this series has been thoroughly tested on Pixel 6 (ARM64) since 2021 starting with the 5.10 kernel version and is continually being tested on the latest kernel version today. Thanks, Will