From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DA70238C1B for ; Mon, 24 Nov 2025 11:04:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763982286; cv=none; b=XjAALrKiy/PIkZpOqr3D8WU6+aUg4YuuqOoma/MdseT5hmASRwmg1fRbafODHcWPdRUpvEYk0bukd4SEOEI4ZHOEZ8cUSK5xIETkU1kQNSDxQyrTlTFqQ7RpERfiVASRR0ldki0lXhCE/v1Hn1w8J5BO8nIyffKyX6D9fm0RCOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763982286; c=relaxed/simple; bh=yGGtQ01i6ULcnlphEJ3YP5AEFLU+uu4BCrDMhyrpMes=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RxW0Y7dxPRvrMsarFZ3gVwBUWkC+nOfR5qgnpu0D7BiA/8JeBSQdcSwF6piTDp+dHkAwv0JLQT0JQEkjvGKc7dU8upSWPV9XucncmIMMOdHc0b9rP0dH0WIq64oXFEC0NQnUDzCppTy2WHdx4bGHvhAwT1BZFdhzJNjqvL0esWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=RD6U6QQI; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RD6U6QQI" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4779a4fb9bfso90795e9.0 for ; Mon, 24 Nov 2025 03:04:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763982281; x=1764587081; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IxY0zFsSsb4UvWV8JkswEu93uViR5DhGzNdHTRi5eEs=; b=RD6U6QQIxGDzesx0pP11v24uK1dIkADuLPqpDDRQ4JCJ2SDfXoEGFUIBX6ILHWFsQ6 ozJeFFEK5QrXEsZYQAKOYxupggcbCATCgvLFReu7EwKgbBlao81yp6Kq6pXlmZQE4c4q 9QkD+PWSmJE5SPsiTn2tanTq8GdBstX8onrzcQAnUl/qrSiHIjAFzwrxPTEu6lV+ZnBH 0dsBjH3cYtrDUMvbjQm1vEjcKnqS1HpRs6lrg5W+wrArmUk68y20zj13naMc9lgTLQFa wO8RUefpzwhgo+QF9Z4GD4K1Nnd83eeXAS6BBER9ZjAAzrj9+MUnyxH2Yv7lDmOq7wZv yABA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763982281; x=1764587081; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IxY0zFsSsb4UvWV8JkswEu93uViR5DhGzNdHTRi5eEs=; b=azO/rvE7636TWC28kt/uLtkradtVGs9nZUSApB/kXwzVWXh2GMzNPHxfRKQkhqc5/A p3/1rnuLnztxwfM1v7aGQIOiBGdPbSsykO3H83KS/HIWu6xx6wGqxJyja/w+G2dlbFVM pyfqz8HjnHroBOeb5HE2ElFgoXSJKP1q59YUYbVTGe9GeRag5V5/wYNZjKR9kqgyvsmY GKH74klSadMGSfE2pAQhscup8CQspgahOL46OUYWM03yJOgYAA6MF4udnTin7p8I54Ut F5WIefBGuIzbe/os4qF9lKq9gDzxw4KMHrzJCXXsjU54rt49mJX1i7ufZ8grYNuUluuS Jf6w== X-Forwarded-Encrypted: i=1; AJvYcCWiJgLip39mzTbrZL5spZZ9mRxGfiIFcaT6l86/G7jUj5m/IrTbDyrG+YkZvv2rtsQvflPOAUlTSteKDiw=@vger.kernel.org X-Gm-Message-State: AOJu0YynqRlN8wvfvwFGbL+fyqtvKf87HB+Z0ksU8ED4JD0AYhyR73LW N2cnj+WODFbvmCBrg/mxJ5dBwR3zAWEDDYgCmvtXza+cL6cBSxEJeYUegPh1bBR7eQ== X-Gm-Gg: ASbGnctvmXkfR2EcI8fqA1G1ynKEt7WacWwvvNonl+9xlyS/8E925d0Hw2i0K1XDGSZ hLrL9ds1mczNNhA+8qCGYC+1Z6SiKhzNMB685wmfdwTASMK0JtWON9biOmH0mM3J/x+g4hLfYs9 8AwlwhI2r9m62PWKcroLCX8uL2o4yyQ8q1OsFqOuDjoJFVtU32kPYH9UMq/NYQ6DsQaY97nFrEc Si6DZvQlfVcYIlU8z0nkiqSneGOvE5+91cBtZ7S7ieT8YQ8aEw2mKsWQT0KyVcmrV3MdPKON1lK GIhLzeuC4SNowC8FpHX/96HvK4mIuW0eL+QgLQ5mUmY/jbfnk56JkpDvwNGcFA8RhjMUsCZrhJr ZWfvuEKpMz/qVguqGTFPPBFY0smpxvdwFpDoQGPPVTFTpt28DC3aN+q9Jz6OJrmPUWsnuEboMqS h3EfCwP1r0npQr9DH1EgJ7SQBZj3+lKU4+YszFEiI8h8l+vPgs4g== X-Google-Smtp-Source: AGHT+IHfC/zx3CtUqS+QNQEXWjnlvj8ok2cj2JsEBQqJZIsdvVIDhcfsaBV55OT3BOjTGNisyGw1Aw== X-Received: by 2002:a05:600c:a402:b0:477:2f6f:44db with SMTP id 5b1f17b1804b1-477c5ea4a1fmr1591355e9.5.1763982281333; Mon, 24 Nov 2025 03:04:41 -0800 (PST) Received: from google.com (54.140.140.34.bc.googleusercontent.com. [34.140.140.54]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf226c2asm188677715e9.10.2025.11.24.03.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 03:04:40 -0800 (PST) Date: Mon, 24 Nov 2025 11:04:37 +0000 From: Mostafa Saleh To: Randy Dunlap Cc: linux-mm@kvack.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, akpm@linux-foundation.org, vbabka@suse.cz, surenb@google.com, mhocko@suse.com, jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, Qinxin Xia Subject: Re: [PATCH v2 1/4] drivers/iommu: Add page_ext for IOMMU_DEBUG_PAGEALLOC Message-ID: References: <20251106163953.1971067-1-smostafa@google.com> <20251106163953.1971067-2-smostafa@google.com> <55391dad-339b-47f8-8996-afe337b238e0@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55391dad-339b-47f8-8996-afe337b238e0@infradead.org> On Thu, Nov 06, 2025 at 11:50:11AM -0800, Randy Dunlap wrote: > > > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > > index 70d29b14d851..6b5e9a2d936a 100644 > > --- a/drivers/iommu/Kconfig > > +++ b/drivers/iommu/Kconfig > > @@ -383,4 +383,19 @@ config SPRD_IOMMU > > > > Say Y here if you want to use the multimedia devices listed above. > > > > +config IOMMU_DEBUG_PAGEALLOC > > + bool "Debug page memory allocations against IOMMU" > > + depends on DEBUG_PAGEALLOC && IOMMU_API && PAGE_EXTENSION > > + help > > + This config checks that a page is freed(unmapped) or mapped by the > > + kernel is not mapped in any IOMMU domain. It can help with debugging > > + use-after-free or out-of-bound maps from drivers doing DMA through > > + the IOMMU API. > > + This santaizer can have false-negative cases where some problems > > sanitizer I will fix it. Thanks, Mostafa > > > + won't be detected. > > + Expect overhead when enabling this and enabling the kernel command > > + line iommu.debug_pagealloc. > > + > > + If unsure, say N here. > > + > > endif # IOMMU_SUPPORT > > > -- > ~Randy >