From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2C152EA473 for ; Mon, 24 Nov 2025 08:08:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763971722; cv=none; b=n6VVo++1y6v6KxESYURIv59gXJ1pu/mN64h1iSIsNHGjufq7+enijM+FD+san5z5rDlXtvXmBY8+xMcO5uGu3ONYBNg+07yNVIZ3QNp18ueYqdHS/JTEhiNaV0y7S+oSrnuahrUHKoxeROhSHNFOwVgj+55uEssLggKXIVCljM0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763971722; c=relaxed/simple; bh=Im77mryU7VUmttutMqwJrxYTuGiD46RxauoaARTENDg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hejqD/R72cBrOw4/ckPPNSE3QOPw8dz8b4KlNVmSuh84vPds4vuz+X+ZxAEBpajC1YxCY4gVOyuGadmtGOYnI3tJ6wpXbwxtCvD5QF+XqbU0pDUqHWm+2O5EbTHfiys/5DwbUcCMlxvWXIQrXSy18iykO2RXXQaM+Yf6afKA4SI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VzZlbGAW; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VzZlbGAW" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42b32a3e78bso3304991f8f.0 for ; Mon, 24 Nov 2025 00:08:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763971719; x=1764576519; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1bYpGSEP1f0o4pmboA4QBRCWseRS1Ggtj4d/5mRHK9M=; b=VzZlbGAW6hyWhjxgPYIb6U6aFkLS1SNCk/wwxPWmlmHUVf8s0LjhCYt9uF+gfVwzsL BSZ3v6vnhEX1LlMU6pnkEltGHVuo1fZe5H48yQl9xDkG8ew1I+YDBMFiUF25avqKWYcS OP6sx9pIdw5y6GJLkDTI7ksWbdOSQ1T+ySX3ZrwXd9b+2ZjvNXYzumbiH0hDOdOS+l56 M7dgrLLFSCSx6J2PMb+O8EB/iigoDzsyE5OPzE1LyJ0Q34g7i0dSjCY1EQP4rouTHUhQ o/3yzYzTQLoZnfyZlSzxOccGH5eAtJ958x7L0XQyhNaoPS91OCwAkm4Z+FgRULA/iYoF DLNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763971719; x=1764576519; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1bYpGSEP1f0o4pmboA4QBRCWseRS1Ggtj4d/5mRHK9M=; b=CqWPXs5zJDit3wUuigt1AH1j5ZUtgJGuqU51sAAnvHaPwY6gbaGxYK/MK3d0jT5cDT gwko/4G6GmsyBrJpeA9CmKFEkKnBgr9nf/PunmzA7QJo9ns29Jd9uzR1LS+jb94TLd+g NdIZDwAL12FCyy6F4cLsqeOsAn9R4mzo5uoYCYxexFiYHPPunDSQM7OeEY0tr/5amIT6 T7EvhYCQAgXNBYEBJejqg+BCmY+Ly5UUAsBwGsC2C+JTL8n4dKhgo5bGWH/x8la8vZhB I75gtDBaVamactOAUA0D5ievhfhGGFWDFCkUvHIvcN/SMtbCyb6pmN8Q7gwKGv349B1B mgiQ== X-Forwarded-Encrypted: i=1; AJvYcCU4kdkMoShZS921etfxY6fomTBx1DMCgiSyLtM3Te2sExhaEr1cQICVjao3gbW41GXzeHULAZj9z0QA78U=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1ea7Z516yOonmam6A0ZPkjrc6dHj1hxB/Nw+5w9hXN8xLZKQF VvFXGTauqa2MMHxip8FiIiRIfhaYUFi55XzM5qqoD/MdUFoUr1tfGvBeZhp3kMyya98= X-Gm-Gg: ASbGncu3Lb79Oc4GKWSb0DW3dxiHoLyb20/7XUEvih6Xhlzwl9+XEFSCnA2P7HnLwcY FondjoUs4m7O31emOI+s+OnG05N8Ls0eWJXVWfhG5icXQ0n3mqunKnImZk6viCHCxHybVMk9l5j QScWaXxfkhxQ3A3fZAWD1rX4df+lYdUDv2+5cOFqSfNpGGMLPO9gm05GQ91jF41LfonEmWonv9J ULDXnN8lC/OdBL7c+n2zDfgC2HIzPhP9Y6nQIJSJFG7S9Nr31g4CvFBBAendlMG0Cf0fPJrOF5f tWrrEPE+t0guQC38Nou0xJmn0X1u97gEN8tqPUnucjCw8qWJYVUzGSpS8vkfUlDloH9+KuwGXp+ FLY2tMPQ710/dtO4tzaeNbgQhR35hd/HaX7BjYQnrlfext2XCLUuyRg8AXPuvIquGjBWU3m4WAV ThEFcSVEoIhAPWYLFy X-Google-Smtp-Source: AGHT+IHSFHz49v0WryO/nI4mAehBYzC0d20V6jCCnGCpQk78qJcnCmmXv7HckVQLKSyH39HGGXciNw== X-Received: by 2002:a05:6000:2411:b0:42b:3a84:1ee1 with SMTP id ffacd0b85a97d-42cc1cbd1f6mr10744412f8f.18.1763971719156; Mon, 24 Nov 2025 00:08:39 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42cb7fb8ff3sm28319422f8f.29.2025.11.24.00.08.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 00:08:38 -0800 (PST) Date: Mon, 24 Nov 2025 11:08:35 +0300 From: Dan Carpenter To: Navaneeth K Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] staging: rtl8723bs: replace FIELD_OFFSET usage with offsetof Message-ID: References: <20251122174555.215109-1-knavaneeth786@gmail.com> <20251122174555.215109-3-knavaneeth786@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251122174555.215109-3-knavaneeth786@gmail.com> On Sat, Nov 22, 2025 at 05:45:52PM +0000, Navaneeth K wrote: > Replace usage of the custom FIELD_OFFSET macro with the standard > offsetof() macro in drv_types.h. This improves code readability and > standardization. > > Signed-off-by: Navaneeth K > --- > drivers/staging/rtl8723bs/include/drv_types.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h > index dd9018aa4ee5..47cabf8707f6 100644 > --- a/drivers/staging/rtl8723bs/include/drv_types.h > +++ b/drivers/staging/rtl8723bs/include/drv_types.h > @@ -173,9 +173,9 @@ struct registry_priv { > > > /* For registry parameters */ > -#define RGTRY_OFT(field) ((u32)FIELD_OFFSET(struct registry_priv, field)) > +#define RGTRY_OFT(field) ((u32)offsetof(struct registry_priv, field)) These casts to u32 are bogus garbage. Delete them. regards, dan carpenter