From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ED70257841 for ; Mon, 24 Nov 2025 08:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763971883; cv=none; b=hdlpm6zTncwoM5ZjTabP90jpwNAFb7reUri94fPlmLnGLqALz+tqB1A+8SvnQ/iTy1ieeou12yfgEpPTm31hANNVkjnfHTs8HJTrAUciUwM+/3UgXd5TOXNpStB/pIENYjXJrohw53lmb/KpD83BccxwEYj5u2iUxN6pP0XgpZg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763971883; c=relaxed/simple; bh=9/LqXReNlV95W5678xuTfFv15mPigSgn0EjVuI47LSA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iFFYQT1xVVHwQhyYNIKjU04NHqF9oKVCkSwYm1C1EAKy3LdJ4edhgMALYb5V9U4s653IyPtsC5MdnkcdRJniE0iLL3Z0q5qb7hkL/0B61ZCeMJPIK9+xXb1LSTL748b20WJ40xinHrhK1K+cZo3eRNR2mrUcRyLlROXB34UlC/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HGU6fpfr; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HGU6fpfr" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4775ae5684fso18333265e9.1 for ; Mon, 24 Nov 2025 00:11:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763971880; x=1764576680; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ceucUvcluXPiH3tbk9LX3444wQr642ZjfxUzVwjoyBE=; b=HGU6fpfrtnXT8HqTOAw5B8ZBFvmHrARgoxNmfOAQgiFPHJ1X5O/MwyOBVcYfY7rJKg vRQ67yURk2iDg0jB/Rqdx8Vx8YKKwrzFC6+aVAawzxcG9Thc8Gi76cQDHXYR0l9ruVox S6rimBDLIQF8Y7dszztDUe//XHOPq1fKX/fo4fLawHLiAofzbvhcw56N869nVVfp8sK0 jeUTdshcO6VFRYqg40S6xp3k5Ho7PguJk4GSyNUM/gOSdaqTXVv5B6Tt4WVlutD8ZXIK dqu3pKAiWO5ZQAi3w47vKNDLVXHuCB2bMuWWMimdXu9dsyV9Ro1yQvKGHfQ0TwDfuKDg ZbmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763971880; x=1764576680; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ceucUvcluXPiH3tbk9LX3444wQr642ZjfxUzVwjoyBE=; b=GQ5EyjdDjdBIDTUluqyNINhXZJln86q00Ye6/0rjfud+by4e6fo94YZ1+dk3z/nG53 8ryh++4loVZTfFkQQTncpCRBqGttU/noGebfNcmh8/eXXcrN241qYmWS7mUifTx+zqwK M4cdzwJc8DGS4oqLhDQHq0biBvOMhsINcKi19XKYgt1jcvEIgMykZGJVjJaefa0jfbBg LVdTniHEWD8WPeNcK6HbwIzttmEIhQNPq9uW5SxUv7kujwCeDGk1OJ8qps2sH6Ja1joN ZG1ls+rnkKPUsV2LtEb9EuFHbgW1uXfsa5QoXiBY9Zojgs/vcJKcQUbSZTXqaUrwP658 UM0w== X-Forwarded-Encrypted: i=1; AJvYcCUXWfpBsvPsmi5zmFm0ICPqF9sjMaFLbIUoeYt0tuWJbghSgSYTQPT46VU6xWCIUl/kU586NfoBVQ4asvQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7JZZ3CCeMEyBwHwiue1W/tIR41RO0o6lRI+bvj7tAAS/7/5lq 20/duKd3DAmVVf/YNv+YjDgiA9FV49o3FPfuHtMyd8J0IfvzeZrS309Y87ccz9QlB3s= X-Gm-Gg: ASbGncuJ5CJ4HfbnKTQkEXVN2G9trOW5q1fGac/GDdqiIo2SDo+rBecvtyC+KCUcicM w8ThsrurjE/a6ttVEidgbmju3vU7gjx0jUKUCbQPICCUkM/QaozWWKcXX4nzN4QHRTJWKuj3uEp JG71NPkhD12QgDp4jqsfC00I3DGnPL74RmIFZfbR/OgJYvISmd4cC7w2AGMWjwDYoz2A+poNUst 121bJjZ4lz/yDkABVePPyPMfydv4RFBgTOuZYQLtA9fktizRorjP00JpBzFbsYbmUAuLFCWwy1w IfxZBXWKpjmZ9+ziB241wIAWvOmlSJTDB3zm1AqiHiifmeEoTR0kuBmoKLxVXGwzrOFtiP4CB+G LdHqX4i9ob4ZqAv/zHS9VRqvi3NRmIy2WLwd3IQvoQc2Lm4eQ8BPzzTDbvokF8ZI3JOUCnsINlL U3O1v2HtwOpTcy+uQC5RigeyZu3dw= X-Google-Smtp-Source: AGHT+IEGJ3uwtOrUxKMiXPJQOEGm9ePbcq1oMaWMyyFaHBwkZj5DGIECwzi4s0SUQ3084kYW3Zt2cg== X-Received: by 2002:a05:600c:4ece:b0:477:7af8:c8ad with SMTP id 5b1f17b1804b1-477c115db0cmr117110365e9.31.1763971879798; Mon, 24 Nov 2025 00:11:19 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42cb7fba20esm27032200f8f.37.2025.11.24.00.11.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 00:11:19 -0800 (PST) Date: Mon, 24 Nov 2025 11:11:16 +0300 From: Dan Carpenter To: Navaneeth K Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] staging: rtl8723bs: remove dead code from odm.c Message-ID: References: <20251122174555.215109-1-knavaneeth786@gmail.com> <20251122174555.215109-5-knavaneeth786@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251122174555.215109-5-knavaneeth786@gmail.com> On Sat, Nov 22, 2025 at 05:45:54PM +0000, Navaneeth K wrote: > Remove commented-out code references to RTL8723A and RTL8188E which > are not supported by this driver. This cleans up the source file and > improves readability. > > Signed-off-by: Navaneeth K > --- > drivers/staging/rtl8723bs/hal/odm.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723bs/hal/odm.c > index 4b36af47f680..08ed38b2a563 100644 > --- a/drivers/staging/rtl8723bs/hal/odm.c > +++ b/drivers/staging/rtl8723bs/hal/odm.c > @@ -610,10 +610,6 @@ void ODM_DMWatchdog(struct dm_odm_t *pDM_Odm) > /* NeilChen--2012--08--24-- */ > /* Fix Leave LPS issue */ > if ((adapter_to_pwrctl(pDM_Odm->Adapter)->pwr_mode != PS_MODE_ACTIVE) /* in LPS mode */ > - /* */ > - /* (pDM_Odm->SupportICType & (ODM_RTL8723A))|| */ > - /* (pDM_Odm->SupportICType & (ODM_RTL8188E) &&(&&(((pDM_Odm->SupportInterface == ODM_ITRF_SDIO))) */ > - /* */ > ) { When you're breaking things up into One Thing Per Patch, these bits were part of the condition so it's allowed to move the ") {" to the earlier line. It's part of fixing the condition. regards, dan carpenter > odm_DIGbyRSSI_LPS(pDM_Odm); > } else > -- > 2.43.0 >