From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A8EA2F7AD0 for ; Mon, 24 Nov 2025 11:23:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763983425; cv=none; b=XevYlz5Y/JUZluUyek23XwAK1VWaO3WT8jb9Xv+j43BiePli545rtiucSejPDOTrbEdtLYiDDhhku9T+9Pvo8a9HlJW7Gf25nrG4vqdoBiGkPHQSDh21bBQAWD55/zxn7vT+qRaU/BnVUSjVPYSer43j6biycXLqqqcji05jTh4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763983425; c=relaxed/simple; bh=bBx2zX4NNXGxJ60W46Gs+T1nncBnetTXvCFoQnu4iCk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Hxl+lAmmx7Y1ySm4uMXzPH+AM0i29VnAJRonLOtvrw0KkFah1XHr57LKv9synBpnYpUgqf0KbeNSUqxOYdVOp65ke4tFk9I0sgxxvHz1Ya9kqtbvDlI2kRv8h0/RLEkrMr8zfyFNf2ExILRavf685vcInMG0vqkGtN1HsA/sKjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=VvbTV3FR; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VvbTV3FR" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4779e2ac121so95045e9.1 for ; Mon, 24 Nov 2025 03:23:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763983422; x=1764588222; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=A/9qmpcn6sF8ptPObBDBMptCfIXtJ3l0IrBw1r6Q5lI=; b=VvbTV3FRAI6BBkuQhd9BBTsJ2hO2iNMkNtHyLU8IHYwFjbcHGEqviSrjd/fPkn7pwb 496mBSe5DUdnLVqyk9J4y/sbLYCd6jAOXOIDiiJyxGe9xvGdJJ1PVQkzmjPs/mFfgxSu XuxboENupC5JmK27T4iGvXaUC+zbqti/YRmZnT6alrlzP2/WvGmIeSNilG7AMNQlzXAS rFToOoO8CHEQiHoEFDqGGYCcBg5qNYZ9A0/dqfPxO7GEBXoFiBkUi59X4paZD2DiV44L weDFpV97i2rXjuKkB1B02K88QMbO+cqD6GG1iyEcan0aCQXhx9obZMmMKdXh3ynyKhOW /cWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763983422; x=1764588222; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A/9qmpcn6sF8ptPObBDBMptCfIXtJ3l0IrBw1r6Q5lI=; b=F7PH3It302cDZhD6ha8vKTbdXijSW78cllvFGDig016ftQ7CIBJmfd9PJWTklSgQsq ncNVX52SzambAtmdsGG6prTzP/j05OmBgj6OxUcAwGNW4+cGVNfucgO+QFNeBFDq4FVr acJG8XXQitSTCn2wLLksk3anM7vXH5icb4XxRWlAN9XxxOcG8Vbmzm3q9LX0B+A+5/7U ZqaBG3KLk7FEhdRk6XAk2mMJQXq3Luz1e4jIEmt4sdvnux1p284IxdaEyO0Lf2BQkcYM 95TkAm+/6uNCXZWgAt5UvFEG9YBl0rJGa6USwCy9TX4ncs4XOTmbGz4xUGEHDepFBFlq 2Iug== X-Forwarded-Encrypted: i=1; AJvYcCXXRwtxW9SFNujl/rScF6KYbIdPWrdd7WxHVuMjQJglMLUgxGJHtOHBq5dHc+edmbWxtlicV/c59lz7ZV0=@vger.kernel.org X-Gm-Message-State: AOJu0YzSUgRdvSQ1shd2VNQHolHUfwRufXl2Qo3DhK3B07hBZhkQCSa5 USfqKvHfHD0O4il1/hEIBmJneeorVPXaZAZj7tjqPBWC2vvow4QYeP1/VtFgjSIV0w== X-Gm-Gg: ASbGncvP+1qF7y+sCk61OVQgRfr9ZOgwWOFMRazt3tspxIuHPaba0xEN8BIyyBx3hhM eFUAgk9Cp1+8Vz8HTf4LPlCArTW3kSHvfeYST2QQvbec9/4A9/cclFsMQ46qJW8jwBYm8BrNwq4 yHRaOZaB5OtenjsEBFbuocefPkjm7gUcWdEuGOFgzj6jGS80VRXYjt7Y2a+pRQZVID5fSHmm98l fUVeTxChWpAuEN0MLXa9Eb58ybzIk9dDtTyskD0NITgOBHYrV4mdQ64eGqW0qhypfiC4F07OF1o Z2r5lrHogFRTdH4HLxyhVbr8yGhpED5scJ93cpNJeQY9q1UPxiSpZHXXSrxRAGKbTaI2ApVEC9l GCYeyzk/6yDPH7gmso+FCXYlPxmwRi2atKDVt2idWbPA6WOxik4agqVevPaEnxFoyFsKw60X03F +9aweRiaDPw8zMLcXB93iAu4jt519qjwNQ/NfFWheKRr97FhLTpw== X-Google-Smtp-Source: AGHT+IHPjRoPkJts63WSW1KmhvXOZnj4KJdKdrrFOfPPYFwb16nEkLhtHX2sQ0Em7vKdjEkEynh8tg== X-Received: by 2002:a05:600c:3b94:b0:477:1afe:b962 with SMTP id 5b1f17b1804b1-477c5ea32a2mr1726485e9.1.1763983422303; Mon, 24 Nov 2025 03:23:42 -0800 (PST) Received: from google.com (54.140.140.34.bc.googleusercontent.com. [34.140.140.54]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf198a67sm200937725e9.0.2025.11.24.03.23.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 03:23:41 -0800 (PST) Date: Mon, 24 Nov 2025 11:23:38 +0000 From: Mostafa Saleh To: Will Deacon Cc: linux-mm@kvack.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net, joro@8bytes.org, robin.murphy@arm.com, akpm@linux-foundation.org, vbabka@suse.cz, surenb@google.com, mhocko@suse.com, jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, Qinxin Xia Subject: Re: [PATCH v2 2/4] drivers/iommu: Add calls for IOMMU_DEBUG_PAGEALLOC Message-ID: References: <20251106163953.1971067-1-smostafa@google.com> <20251106163953.1971067-3-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Nov 13, 2025 at 11:00:15AM +0000, Will Deacon wrote: > On Thu, Nov 06, 2025 at 04:39:51PM +0000, Mostafa Saleh wrote: > > Add calls for the new iommu debug config IOMMU_DEBUG_PAGEALLOC: > > - iommu_debug_init: Enable the debug mode if configured by the user. > > - iommu_debug_map: Track iommu pages mapped, using physical address. > > - iommu_debug_unmap: Track iommu pages unmapped, using IO virtual > > address. > > - iommu_debug_remap: Track iommu pages, already mapped using IOVA. > > > > We have to do the unmap/remap as once pages are unmapped we lose the > > information of the physical address. > > This is racy, but the API is racy by construction as it uses refcounts > > and doesn't attempt to lock/synchronize with the IOMMU API as that will > > be costly, meaning that possibility of false negative exists. > > > > Signed-off-by: Mostafa Saleh > > Tested-by: Qinxin Xia > > --- > > drivers/iommu/iommu-debug-pagealloc.c | 23 ++++++++++++ > > drivers/iommu/iommu.c | 14 ++++++- > > include/linux/iommu-debug-pagealloc.h | 54 +++++++++++++++++++++++++++ > > 3 files changed, 89 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/iommu/iommu-debug-pagealloc.c b/drivers/iommu/iommu-debug-pagealloc.c > > index 385c8bfae02b..a6a2f844b09d 100644 > > --- a/drivers/iommu/iommu-debug-pagealloc.c > > +++ b/drivers/iommu/iommu-debug-pagealloc.c > > @@ -5,11 +5,13 @@ > > * IOMMU API debug page alloc sanitizer > > */ > > #include > > +#include > > #include > > #include > > #include > > > > static bool needed; > > +DEFINE_STATIC_KEY_FALSE(iommu_debug_initialized); > > > > struct iommu_debug_metadate { > > atomic_t ref; > > @@ -25,6 +27,27 @@ struct page_ext_operations page_iommu_debug_ops = { > > .need = need_iommu_debug, > > }; > > > > +void __iommu_debug_map(struct iommu_domain *domain, phys_addr_t phys, size_t size) > > +{ > > +} > > + > > +void __iommu_debug_unmap(struct iommu_domain *domain, unsigned long iova, size_t size) > > +{ > > +} > > + > > +void __iommu_debug_remap(struct iommu_domain *domain, unsigned long iova, size_t size) > > +{ > > +} > > Since the IOMMU API doesn't really have a "remap" operation, I wonder > whether it would be clearer to have unmap_begin() and unmap_end() > functions instead? You'd probably want to call them as a pair, so the > check for unmapped < size would move into unmap_end(). I guess that would be cleaner, but we have to pass both size and unmapped to unmap_end, I will give it a try. Thanks, Mostafa > > Will