From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56C0E2FF678 for ; Mon, 24 Nov 2025 12:03:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763985789; cv=none; b=Qn810QYSwmB/LuYsLH8Cg86wlnSFgyVEp/dq0G+8ho0oXURdGXOgTKniVrBj9t46qggEMT8IoWF5Pv3KRi9VHQNpk+IV5ARQjisCUN660b5PL73RPP51iWQgJc7PbOvZfc+rUxH0Xzi905qhbl5JOPIzE8dxP7zOfzBNXufsnnA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763985789; c=relaxed/simple; bh=k5GTtDI9s6nIRlDbv/w9jxXzQouOJh/3X0JGzvKsIc8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ppUFm33ZKd1EPaSxIB1uUthYvMmIHXjTADE9PX6sSGs6h1K2P8ool9SFyIihVUcyJOvqr3wBqZZ36cj8hHRTLbIeZMP+Ds2zia2+zIrnJPAmFe37cMxGm1skOXJv+8q1ya3af2Yorl0Ena7eSqF0slbAsoo8nVSplIf4GlF1Xxg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kjx3hFN+; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kjx3hFN+" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-7baf61be569so5000942b3a.3 for ; Mon, 24 Nov 2025 04:03:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763985787; x=1764590587; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=U7zD51i8UUvjK5YMM7TBk8yuIWlAihYctE+BATz3e18=; b=kjx3hFN+Ftl+QSlQzJL1PffZl2jl2/8OHuQif2mk6Xw2wKOZGoGNWldbddKIpPJvsG fYCbdzQ0yqhlCUqyPc3bK+Ow3pumBy9hSn5XdJHhExC4C3AtUQC9niBoE5UIDfn0h60f vHP2b9reQWBMORc20PugVwK8cAEF9pdxxKpMdo2kkVa1SAvXW/MUyXEIJi1qkSuzVhmz Oi3+rt02S8LB5xRtcXrpQG/h1wm3+yx+ttH5XvB1uOGLn+ZqF2f4M+pJXQjRq8jZ3Cyb Vpj+WzQR9MlCOTUMmZUTqqLKj/5TLLtaJ/SJLn4ubtNts74vb74HjCm6Uff8xMAx2Si0 QXmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763985787; x=1764590587; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U7zD51i8UUvjK5YMM7TBk8yuIWlAihYctE+BATz3e18=; b=GYKj+VyOUrW044EfuqMQp9ajF1q+kiWmujqCrdg/b54m0NAkHwqYbZaIDfS1zQnwIV c8eKzUpaVJnR60xy7KDFBfK1xkNpLbVgMouaSOJUVv5JKZqyoP+gQl9JI+N384kXPcAB SQXwoDN6vdk4EubZSSTSgd1MguSShpeWoa23XSydr/CyrG3Z2W6FQY8Kr/Mnmi6UouQJ wNVUZhdBQS3N3QaHwDWTjXdeywkWg/Iy5b/XN0lmLTBdf7zML9eLwTzaOWlKP8aihOWE DYle9B4TcowUikbcznLDvsdg/2Jalk+1HBc/U2SC1ZPJ1iV+425fEqd3eLVDqoJvKlwD xuRA== X-Forwarded-Encrypted: i=1; AJvYcCWl+5G38+dAo9JMzNK4nccw2k22OVrlt40tNjWqffUsHNtVhoy4o7dYjX92nRJ3XmfmBcPGVOjEBX2BVDs=@vger.kernel.org X-Gm-Message-State: AOJu0Ywn7cU35bYMWEAc9rpu36EFh/W4DfZlRlGKqg1bnjGtzr7vJT7n XgY+VJRps+JJ329rOD26L0iWwmfwbSYxp+MPxS4Yu/k8wg8T1DXvx8BMr31Zm9Za X-Gm-Gg: ASbGncu88HbQRaNd4PfGKt/jNc76PaCM44aIeK0llYvdbFGvtB8en7ZRvOBj+5VQ1tm CfodJLlI33ltbjhXkxx1AsygVz5WYcGiUp4IMXTFFTM8V1pgXPhWKk5Bkm8Uju0sohpgLqoKfef DdwjelE+TVK54Vt0Cu8ZcfynMBBe0absAjltteapaE/4raFpNYfHjf76VGNm2mlwuGlmgUZw/Ws FI0bjlCoNSXLBP+DBaQu5Q1O/qqhjris/0Xf2IxCj7W2bn8iAA4mG9i2CH9Hv/sEO7//DOei3fj Ss3RLfFIJmH0LdXR8p/riDnzw69m5XuXbiQqNVTVNB9PrvWJCJJLHRqj7pzFIhWO8kbSv+utGm8 P9dTczX5eFlRNOU9H/eVj79EPEhdUjZwydP066p5gZBt62sSXZiBmU3gifIefdjOvpS2eZ1wYgG ieg07IDbgxpKPMQs3XYP+NWDOv X-Google-Smtp-Source: AGHT+IG5DVoDYtCW8l3qVTT8DjEQ1FSk5zCsnH5zDEQwtm06FXqxK9B72e5zSRQCzRfeyyCgb7n/IQ== X-Received: by 2002:a05:6a00:140d:b0:7b8:e83:1de4 with SMTP id d2e1a72fcca58-7c58c7a6bd1mr10695029b3a.9.1763985787373; Mon, 24 Nov 2025 04:03:07 -0800 (PST) Received: from google.com ([2402:7500:499:ceaa:13f2:ed9d:8825:326b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f0a67a4csm14660564b3a.48.2025.11.24.04.03.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 04:03:06 -0800 (PST) Date: Mon, 24 Nov 2025 20:03:02 +0800 From: Kuan-Wei Chiu To: Borislav Petkov Cc: Nikolay Borisov , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Yazen.Ghannam@amd.com Subject: Re: [PATCH v2] RAS/AMD/ATL: Remove bitwise_xor_bits Message-ID: References: <20251124084011.1575166-1-nik.borisov@suse.com> <20251124110526.GAaSQ79mo0yx1h1Xxm@fat_crate.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251124110526.GAaSQ79mo0yx1h1Xxm@fat_crate.local> Hi Borislav, On Mon, Nov 24, 2025 at 12:05:26PM +0100, Borislav Petkov wrote: > On Mon, Nov 24, 2025 at 04:57:51PM +0800, Kuan-Wei Chiu wrote: > > > Both LLVM/GCC support a __builtin_parity function which is functionally > > > equivalent to the custom bitwise_xor_bits() one. Let's simplify the code by > > > relying on the built-in. No functional changes. > > > > IIRC in some cases, > > Which are those cases? > > Do you have a trigger scenario? > I did a quick search, and I believe it was this kernel test robot report [1] that reminded me of this compiler behavior. [1]: https://lore.kernel.org/oe-kbuild-all/202501312159.l6jNRaYy-lkp@intel.com/ Regards, Kuan-Wei