From: Keith Busch <kbusch@kernel.org>
To: Thomas ten Cate <ttencate@gmail.com>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: "controller is down; will reset" on SK Hynix NVMe drive in Lenovo IdeaPad Pro 5
Date: Mon, 24 Nov 2025 12:52:28 -0700 [thread overview]
Message-ID: <aSS3fP1pnWvEHFLh@kbusch-mbp> (raw)
In-Reply-To: <CACbz5yE52zBkN_mhMhY_bA62z0Fajt3K+K65Fyf8bWBd13yC-Q@mail.gmail.com>
On Fri, Nov 21, 2025 at 02:06:23PM +0100, Thomas ten Cate wrote:
> On Thu, Nov 20, 2025 at 10:04 PM Keith Busch <kbusch@kernel.org> wrote:
>
> I tried adding the following to linux/drivers/nvme/host/core.c, in the
> core_quirks[] array. It takes a model name, not a device id, which I
> took from /sys/class/nvme/nvme0/model.
>
> {
> .vid = 0x1c5c,
> .mn = "SKHynix_HFS001TEJ4X112N",
> .quirks = NVME_QUIRK_NO_APST,
> }
>
> With NVME_QUIRK_NO_DEEPEST_PS, it still hung almost immediately. With
> NVME_QUIRK_NO_APST, it appears to be stable.
>
> Would you like me to send a patch?
Sure, but I think it'd be more universal to apply the quirk to the
nvme-pci driver's pci device table than to make it based on the model.
It's common for a model name to be different for various capacities, but
I suspect the power behavior is more generic than that, which should be
common with the device ID.
next prev parent reply other threads:[~2025-11-24 19:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 13:39 "controller is down; will reset" on SK Hynix NVMe drive in Lenovo IdeaPad Pro 5 Thomas ten Cate
2025-11-18 20:49 ` Keith Busch
2025-11-20 13:52 ` Thomas ten Cate
2025-11-20 21:04 ` Keith Busch
2025-11-21 13:06 ` Thomas ten Cate
2025-11-24 19:52 ` Keith Busch [this message]
2025-12-15 12:15 ` Thomas ten Cate
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSS3fP1pnWvEHFLh@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=ttencate@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox