From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AB62298CC4
	for <linux-kernel@vger.kernel.org>; Mon, 24 Nov 2025 19:52:30 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1764013951; cv=none; b=R/f6Ppk8NxBa36xJQn8nAjGRAquRPmOrfunxKXpPNNEqVF4R0NM7luAxbu0V4lQXe8dqYyPzNSnNipY1QkPld6Qfa4jwQ4vfLi36ehyDF0v6/mGFDJJiAfB6TPTseqUKMPcN1K/QFAQiSY2TouL1Sp9RAqXE8Xuk+5/s6vWv9u0=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1764013951; c=relaxed/simple;
	bh=P+lPYqigJMSESrgqokiVFRgcZyffRySe7GZFd7iwdu4=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=EFsmydiyIIoCwVUKtd0DptHB2D2wzvaQ1+vzzIqh5nl/6MNJv9FKyc032lLEtepGirjs0FHWmAJ1NIZt6zBU+enzTUSmDDvEs+xtMo058oPm6lfF2ZNAUVvLTa++heS0Cx5uKErPlVYjtSrHm/qeQ7P5G1BVwfnt6F/Ge44rEQM=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l29icPDF; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l29icPDF"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61D10C4CEF1;
	Mon, 24 Nov 2025 19:52:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1764013950;
	bh=P+lPYqigJMSESrgqokiVFRgcZyffRySe7GZFd7iwdu4=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=l29icPDFHOtS5Gwa6qfvrGFSyHPBR9J3v8UjT7XXqznC/lSD4U8nDJuT5S3EPS2AN
	 D+k0LjPlXXDRLxZCW6IaiQry00Tk8B1rAscYnxINenfI5Fy41moXp0IbccL4/gnQKW
	 ahMSloHywjUaenZ88Fb0zNMQwYnPURsxpIkFELuTNnr4I/eTTDFmTUPmni5EPsK6f4
	 OETNbSIwE+Owg0W9uD+ubn6nnhDA5lsZgZ980blG+iVSs6Ep8aTETd+Rp65Zg2CraW
	 +bKq6T39cf9Ex3y4LJR0kanDhPvu8EmU61OqqgaGNtagieA0TgTfyFBmDDgvUM7Sdj
	 WTnQG61o5KBCQ==
Date: Mon, 24 Nov 2025 12:52:28 -0700
From: Keith Busch <kbusch@kernel.org>
To: Thomas ten Cate <ttencate@gmail.com>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: "controller is down; will reset" on SK Hynix NVMe drive in
 Lenovo IdeaPad Pro 5
Message-ID: <aSS3fP1pnWvEHFLh@kbusch-mbp>
References: <CACbz5yFi8hiPD0Avg=KVTpdEeJC=3MMSkGtYOBQ=OmB_O0khyQ@mail.gmail.com>
 <aRzb6U1se40SrQRM@kbusch-mbp>
 <CACbz5yE1RNmJkg-RSBe2u60Y5yd1zxkEZ=pVy_gTa2JLh9d5xQ@mail.gmail.com>
 <aR-CUUzWzQKIAfqx@kbusch-mbp>
 <CACbz5yE52zBkN_mhMhY_bA62z0Fajt3K+K65Fyf8bWBd13yC-Q@mail.gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CACbz5yE52zBkN_mhMhY_bA62z0Fajt3K+K65Fyf8bWBd13yC-Q@mail.gmail.com>

On Fri, Nov 21, 2025 at 02:06:23PM +0100, Thomas ten Cate wrote:
> On Thu, Nov 20, 2025 at 10:04 PM Keith Busch <kbusch@kernel.org> wrote:
> 
> I tried adding the following to linux/drivers/nvme/host/core.c, in the
> core_quirks[] array. It takes a model name, not a device id, which I
> took from /sys/class/nvme/nvme0/model.
> 
> {
>   .vid = 0x1c5c,
>   .mn = "SKHynix_HFS001TEJ4X112N",
>   .quirks = NVME_QUIRK_NO_APST,
> }
> 
> With NVME_QUIRK_NO_DEEPEST_PS, it still hung almost immediately. With
> NVME_QUIRK_NO_APST, it appears to be stable.
> 
> Would you like me to send a patch?

Sure, but I think it'd be more universal to apply the quirk to the
nvme-pci driver's pci device table than to make it based on the model.
It's common for a model name to be different for various capacities, but
I suspect the power behavior is more generic than that, which should be
common with the device ID.