From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B383313E37 for ; Mon, 24 Nov 2025 16:02:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764000126; cv=none; b=au51A4Bz7dAGIT5W+43H7xA7v24tKWXmjcjQIA/65B4RJmPQ8dw6QjYQRFCnA8DApWgMDOKy+PavtkQeXvMx09muDarBPDbYQodR0pGZmU6EYRBjkbshrV6Ek4YOK09F48fm6EsI3RPTeUDvslgq1fzUjWNo0QB+ofXwVSNNlWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764000126; c=relaxed/simple; bh=uHrLKA9wKl7gy2YAVA3r41woIoGizB3IbJZXarj74XI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J4ej+AYXGG8fnbxuLmrTKkluJLM8BivLklfXckq9UiCyDQXMULoy+jenHG/5xMjRc0Z9pUrWHmZSKQ/NyfNS0dYQLP3pSs3YZGzg+YsMuZqsfOijYHRzkntL2WMDFh466NvjAae0maVJuxiOW5BtWOA0BrEmRMMLjleUV4Mv3fU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=pdXfmvmb; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pdXfmvmb" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4779a4fc916so109345e9.1 for ; Mon, 24 Nov 2025 08:02:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1764000122; x=1764604922; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=bLdELsThxmeB5YvfJC736dRFpSpC/jFiigw/6IO1T6A=; b=pdXfmvmbGke7I21fnLK8wzNNxuAmLlBLgV/PRg0UsSJ8YfqWq2LB+eCFIPYRg0wiLI IQeyr1E39Y02sGvEY44Rff5cWgdGWcin8/ujIYgZJazILXwalBy/EoBZ9naGvtMACFcY eaXz8btoOMy4/VpCOjRSUNVP4ATztmZ1G4vlFblfLP1Ai7/+jSItUr3X3GmnpXRUaMCA 1rgxVCjQvjJfEFzdcJhxrTGROUndZJnPfOkqjUSOaakFc9OmqUE4PqIQ6ofT53s4iW5W pX4x3jXMG7ON4rRTxiTwWQkhscF+SNIXyYSzWPqoOVkZjQUwX9dBq82ZI98P9BO3FaBD vhzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764000122; x=1764604922; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bLdELsThxmeB5YvfJC736dRFpSpC/jFiigw/6IO1T6A=; b=RChiGZwDMi98oINPLODRzQQwGbMJ1gQbiIQhBkGxZJvJod557BWoG93S5SVMdvSSEM 8It5I7VGwNkTii2r9tmer9/MdPG5wvmzvbUBXIOisZ2sBLpLo8/XTIHvXLKgiDjYqz6V hpYSb1vins/UqmSpgm8V+/YlQh/8vOHX+5OVGdR8SekCyS+tEGD+irEUroN/5et6E9w8 CLxwF9JnvNV070c+f3YLPm/QJHKEt0I0PCpb8Ttvcv9SGtkavtbKEIzax0J8du1gg1eS CVT9XywkDPN1Ky+ja/J31WNyfo/kD2lF5ebsM7SsJn1cgjeswZHmFjjZ3lMInq4klXlf KG1A== X-Forwarded-Encrypted: i=1; AJvYcCUMvD3YOgzqW6xVWhBH0iSrB30By8irAEtNdN7sN8zYLvPmrWkwknbLCwyCacxjbpIfM+hfa3C3InIGAyA=@vger.kernel.org X-Gm-Message-State: AOJu0YyJ/16z2k2vOegdmIo79br4wiE981NtHjg7hoHx8NQiDQSoq5i6 O4ldSqI4dyNUSpgJhHNH4HnHUpTEvDHukGH/r/H4pjgHd9AxjHBufC0bWXPe/jsRgQ== X-Gm-Gg: ASbGncsiadWwsrayf9y5eLdjqRXDSMrDuW9YPuOmt93txxmcErfW1U24lrOD4j3I8Oc PMJD3mNdXLlJlpnw7G4W3o29iROFAhLy70KEpBFUWsEihxVp1Ql5NtTntMEUfdo0kGy72FqfbLX NgPxnzJHiH0coj4dO9rxE0t9WkwfgTRVye3WHnpVYOLjFWwYBev67GuWzbaE6tBCb7B6xTVN3N5 2tAK+ph2liudD+winhsS21B+yiqJLu2NjwVvI/tV65Waz8zy0JtJCiKCVhYQbrWjJhKtAhZOHiy Jr0/R/VTKZAGnBoPVpffQsdHu3WMbduNB5ys9u2p0dnD6Wj5/p5+bIl5UOgeEDrdbbGmLOQ5Wgh 4U+ftDhPF2s5UbvbOfknBe9Yicn+Ipc2okRArnRGpr8aDo10CSdYCJdOxihQZUdHpnYZhzpUYWK 1F2Qn9DVbnW8kp9JuGePR1KY3A0O9Rfbi1kP+8n018M2ACpWCJZQ== X-Google-Smtp-Source: AGHT+IF87Of2xq3NRiXHoW9YLLU17xS9MSG7Pyejbfo/XW5RRV/9hA3ItGRGycpv5nRxS4fk6hR8OA== X-Received: by 2002:a05:600c:888b:b0:477:73f4:26b with SMTP id 5b1f17b1804b1-477c5e8f119mr2244225e9.3.1764000122272; Mon, 24 Nov 2025 08:02:02 -0800 (PST) Received: from google.com (54.140.140.34.bc.googleusercontent.com. [34.140.140.54]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf1e86b3sm239817465e9.6.2025.11.24.08.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 08:02:01 -0800 (PST) Date: Mon, 24 Nov 2025 16:01:58 +0000 From: Mostafa Saleh To: Will Deacon Cc: linux-mm@kvack.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net, joro@8bytes.org, robin.murphy@arm.com, akpm@linux-foundation.org, vbabka@suse.cz, surenb@google.com, mhocko@suse.com, jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, Qinxin Xia Subject: Re: [PATCH v2 3/4] drivers/iommu-debug-pagealloc: Track IOMMU pages Message-ID: References: <20251106163953.1971067-1-smostafa@google.com> <20251106163953.1971067-4-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Nov 24, 2025 at 03:35:47PM +0000, Will Deacon wrote: > On Mon, Nov 24, 2025 at 12:37:31PM +0000, Mostafa Saleh wrote: > > On Thu, Nov 13, 2025 at 11:00:29AM +0000, Will Deacon wrote: > > > On Thu, Nov 06, 2025 at 04:39:52PM +0000, Mostafa Saleh wrote: > > > > Using the new calls, use an atomic refcount to track how many times > > > > a page is mapped in any of the IOMMUs. > > > > > > > > For unmap we need to use iova_to_phys() to get the physical address > > > > of the pages. > > > > > > > > We use the smallest supported page size as the granularity of tracking > > > > per domain. > > > > This is important as it possible to map pages and unmap them with > > > > larger sizes (as in map_sg()) cases. > > > > > > > > Signed-off-by: Mostafa Saleh > > > > Tested-by: Qinxin Xia > > > > --- > > > > drivers/iommu/iommu-debug-pagealloc.c | 74 +++++++++++++++++++++++++++ > > > > 1 file changed, 74 insertions(+) > > > > > > > > diff --git a/drivers/iommu/iommu-debug-pagealloc.c b/drivers/iommu/iommu-debug-pagealloc.c > > > > index a6a2f844b09d..0e14104b971c 100644 > > > > --- a/drivers/iommu/iommu-debug-pagealloc.c > > > > +++ b/drivers/iommu/iommu-debug-pagealloc.c > > > > @@ -27,16 +27,90 @@ struct page_ext_operations page_iommu_debug_ops = { > > > > .need = need_iommu_debug, > > > > }; > > > > > > > > +static struct page_ext *get_iommu_page_ext(phys_addr_t phys) > > > > +{ > > > > + struct page *page = phys_to_page(phys); > > > > + struct page_ext *page_ext = page_ext_get(page); > > > > + > > > > + return page_ext; > > > > +} > > > > + > > > > +static struct iommu_debug_metadate *get_iommu_data(struct page_ext *page_ext) > > > > +{ > > > > + return page_ext_data(page_ext, &page_iommu_debug_ops); > > > > +} > > > > + > > > > +static void iommu_debug_inc_page(phys_addr_t phys) > > > > +{ > > > > + struct page_ext *page_ext = get_iommu_page_ext(phys); > > > > + struct iommu_debug_metadate *d = get_iommu_data(page_ext); > > > > + > > > > + WARN_ON(atomic_inc_return(&d->ref) <= 0); > > > > > > Is it worth dumping some information about the page in addition to the > > > WARN_ON()? That way, you might be able to benefit from other debug > > > options (e.g. PAGE_OWNER) if they are enabled. > > > > These WARN_ON are for overflows, which should never happen. > > I initially thought about using the refcount_t, but it didn’t seem > > suitable as refcount_add() expects that the refcount is already “1” > > indicating that an object was already created which doesn’t fit > > in the semantics of what this is. Similar for refcount_dec(). > > > > In the next patch there is a WARN_ON for the refcount check > > to capture the mis-behaving context, I will add a debug print with > > the leaked physical address in that case as this is the important one. > > I was thinking specifically about calling dump_page_owner(). I see, that makes sense. Thanks, Mostafa > > Will