From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEC071A9F87 for ; Mon, 24 Nov 2025 19:28:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764012513; cv=none; b=jUul47XZfMnLqD6xT/wCUTxZeQIzIvjXJAV+qVfPd9BGyfsnKJjn+tj2cCdxuCECy0Pp0WuUQjvZVu84lRtOYuKDvvTYu1Ebke56gkIwALQBB/eHQ8BKmKlaH4oT8zvzl0YFqOx6BMuRnDIkj1JJ0a5kys8CWk//iRqVAY2Cs2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764012513; c=relaxed/simple; bh=sDew0t9fu0jnEVo8dKYpXLQpMRfJPGurqD+BiO4AuRI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=evf3P3ydR6guRs085yTPUZThIwK1ISmEvvylXFwc64uEbvNK0STkhmcGPa7XK45nOuUVkGqq/R6nB4BeaAu353tY8pgSoG4wtLol8PBdxsp+weTGRbpTdUCUWZL8ZFHIdGam/YQdsYufSxlyy+KcqQfZEiYHTx3BRXduMAl3zFU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=dvkEvOoF; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dvkEvOoF" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-295c64cb951so31035ad.0 for ; Mon, 24 Nov 2025 11:28:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1764012511; x=1764617311; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=LWH9q/hl3rNSInlsbdja3rL4CO9dd/czAGlikc5ijjE=; b=dvkEvOoFE8dvN7Re6CCRsmwKt/+71rk1QV/BAepaErKPBDzxKj+nXIvOvf+gDzD2S9 mpyZ3hT9n4P4WoNBdIXWZcGQVavNu2WhY1FKD9x4xeDvamUrIEBhE3S41ZqNSytOHbvh ceGH7NMYumjukBbBC3TphuqOjhQizfBI24zFSedyhlQynq4e+eo6HDLjHI4v++0BORFf MxsCun/KzcYzLDWiZDp5YBWX0Iviu6sHkSDdCZqsDdeRdFMOTTJ8fHLBZw9oi7gYtydw +Z0VVzHjz0Dy4Qbh3CmpPHK862vsUvgRTHWU08ih2/NTXIZdJ+eUo/vGQ/RLwPEdUuKN 8mZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764012511; x=1764617311; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LWH9q/hl3rNSInlsbdja3rL4CO9dd/czAGlikc5ijjE=; b=L7dJhMbT4ZW3tcBDfhYfac4SJWTQni6lNL9SFTyjuAgsXuYD6Xxg9ii3b3JC4aqaUB gaCFiqxWVlCCDVZUmf8n+RBzh6Se5POLRyrCYWEmeGoX0YtSRiBrv74GHKYglyvsxIzm 8UtjIoP3NuLrNyXq6Oliv7HhjUehQ+cPURt7iLB7iUsHwM/rwKOV4rKrmF/JXgj3R9Pd n1fReTvMHlTiweF029TF/WGLpqsM0SrphQtSB54CXyXENA2OHJMpFXv0siRqjTnYFha3 MvDHDts3iH/ouvQ9jsh+aRXsKlfhqz6Ho5SyXbH/hZavizBuJmRMZy4wEvV5B1lekcxz cfDQ== X-Forwarded-Encrypted: i=1; AJvYcCVG0Qd7iLSvtbJu4j+0gFgq+SssDxl5Nfm8b3o9+kpVrkdt/xS5bkedT8gvjoYecDuE/snsVDHeID6ViTc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy064pmza11vs5w2qnASMKEiYd//1PsnrdHsRw+0Cb+HTS2K//a yjTE8bhK5Tnlkt5scynNTCkyp/Yzbxc7iT2u5c+vJz3OxTpclAWR/t4/zn9KN761Dw== X-Gm-Gg: ASbGnctC9VkwMIffzDT/5KIPOUzfCtO76TgjEZ+JbAxBWXKUz0nSQh4Yau80fmQfsfp 9aykwNzGW04iXxMMUXpJy3gg/WSjZM5jgrZnpBi8FyQBevzh+yIw9y74Ph8uQGkArJscf1VeYCE 5//wz84XEO2mo8KPPghKxsc0wY++vehZh2e5YxzT5BAwAxIGOFYPjjx74k06gUOTl46kSpy/lhC 3oU+OqLeEfKeIX/VaNiPZgKJsQX5s29/oSvbJCvoR2cf3b4/7volePLEL6iQzi00+peZkvzeG6q qsJvNU6/jJJ3NTvJF8Wq5vy+kmMbn3hhO/shkQscxEjmsSe5w8Ka53MI3kcrWtGnbJAc/cVhMer wkktGnrMF/cseNDcgP+FlO+tACba4s8vMNt4L7RvHbwlQEbsfgVfRQgLTTWLVdBHFxsEvGNtYiw g61zxA1vmSzaGeZAP6MLiViDQ3m9I0lDOzlWRCcQyLO/43h05c3TFepX4JMSw8F3nvbNoDfsE3y +wO0y+Cb3sa87IUzqvJEY2PcICNBxrTAPcS X-Google-Smtp-Source: AGHT+IFLRduFAIQy3YMAggJqo/rYWmJVJJ8UtSIVVJnP/AlGBxO6wqy+SVrby3o/Ep3mplNi6XKu2w== X-Received: by 2002:a17:902:dac8:b0:299:c368:6b1e with SMTP id d9443c01a7336-29b7b2cba85mr4907175ad.17.1764012510779; Mon, 24 Nov 2025 11:28:30 -0800 (PST) Received: from google.com (116.241.118.34.bc.googleusercontent.com. [34.118.241.116]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f095c237sm15674809b3a.45.2025.11.24.11.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 11:28:30 -0800 (PST) Date: Mon, 24 Nov 2025 19:28:25 +0000 From: Carlos Llamas To: Andrei Vagin Cc: Mark Brown , Andrei Vagin , Christian Brauner , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Alexander Viro , Jan Kara , Andrea Cervesato Subject: Re: [PATCH] fs/namespace: correctly handle errors returned by grab_requested_mnt_ns Message-ID: References: <20251111062815.2546189-1-avagin@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Nov 24, 2025 at 11:14:46AM -0800, Andrei Vagin wrote: > On Mon, Nov 24, 2025 at 3:23 AM Mark Brown wrote: > > > > On Sun, Nov 23, 2025 at 07:15:16AM -0800, Andrei Vagin wrote: > > > On Sun, Nov 23, 2025 at 4:51 AM Mark Brown wrote: > > > > > > listmount04.c:128: TFAIL: invalid mnt_id_req.spare expected EINVAL: EBADF (9) > > > > > The merged patch is slightly different from what you can see on the > > > mailing list, so it's better to look at commit 78f0e33cd6c93 > > > ("fs/namespace: correctly handle errors returned by > > > grab_requested_mnt_ns") to understand what is going on here. > > > > > With this patch, the spare field can be used as the `mnt_ns_fd`. EINVAL > > > is returned if both mnt_ns_fd and mnt_ns_id are set. A non-zero > > > mnt_ns_fd (the old spare) is interpreted as a namespace file descriptor. > > > > I can see what's happening - the question is if the test failure it > > triggers is a problem in the kernel or in the test. > > This is a test problem. The test has to be modified to check cases when > the target mount namespace is specified by mnt_fs_fd. Cc: Andrea Cervesato Loop in Andrea (test owner) to possibly make the corresponding updates. Thanks, Carlos Llamas