From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6EC32D9EC9 for ; Tue, 25 Nov 2025 09:33:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764063222; cv=none; b=WehcmLDGDm/uTKC8tm9JRwLP9a14UiJFlq6U6yrZJAKqaZ40rEskU6CPhN+tvMrvZxkw/b6wgfE9BInvbJ2z59QtCTaBrnqDXU8c3qfEZ5o03CxjtMhZ8Kr44ZKhBQIsaqhO0+UXjMXhANuR5QL481y5gFBzebR6XAO1hywkDWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764063222; c=relaxed/simple; bh=RMsCYX/RDDbGtkdxhQEm6fISCFDULwF2NOfT0i62ocE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FhDNNrejx8sLwJae/bFX6XNkPx4lKNDOZqbKrx5c9rTWI0/eIAI9GywP419tqmLFBpLA9De3nzJ8Ef3sCP0cVIHK0ifKlZ8wRigyNTPshdDdjsvnr4UzAcezJolof6L5BiW0L9XmbpK9QMAxHfVzTW3k1+FF7dYlxPXcAYcf2LY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=N6sYr7+S; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=KoLINEIS; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=lWYCjnHI; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=MHc3FMVj; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="N6sYr7+S"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="KoLINEIS"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="lWYCjnHI"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="MHc3FMVj" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5FDE822550; Tue, 25 Nov 2025 09:33:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1764063218; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=voGsWdT/TADa/XNKkRB7q0zQKzAVaHz4j72C+7TpNOk=; b=N6sYr7+S35XIvWbY9Dw3p2lG08suPP6KvOvmsNdce3b4Mqu/AbUJcLNeu62Xk4bu5a9tAg SEJoFMAO9Y+veerePRpfEVd8udxIbTGaz54lmw6DFeZoFhEcGkN2IBRWPhdXrTFF1M1UJM RLYt0QqPvzq9P/ZXwY6peaEnRz9xkio= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1764063218; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=voGsWdT/TADa/XNKkRB7q0zQKzAVaHz4j72C+7TpNOk=; b=KoLINEISLY9Jec+kwZYoCDJGkwwP5YAe+3K9l4ZDa8KuuK9Y/zdbFUnbfHbUvEh99eRxQ2 BPHVOdjs7MeEbtBA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=lWYCjnHI; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=MHc3FMVj DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1764063217; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=voGsWdT/TADa/XNKkRB7q0zQKzAVaHz4j72C+7TpNOk=; b=lWYCjnHIWZBMsS6UKx6RETYfnvd0jCOI3K2OEl6yJjnNfHtKU3U1kDPcV4Y9VBICs4aKit T1cihKATN7Pl+DzNu7Mzoa/wAChodfi8kt6gxKUsLYwlOrThjec0Hqno88OjGcN9nzZ9/j NU2HEinGB+H9+xkTBviEJ2D9Z5aJSjY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1764063217; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=voGsWdT/TADa/XNKkRB7q0zQKzAVaHz4j72C+7TpNOk=; b=MHc3FMVjNF2+NlJv5Q8a3wNlzaJTV+3SCFptkiTEfDvOR4sPJgSjwkeIkqskkNeHDjQ4hC fdAlK83ISqSK8bBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BEA5F3EA63; Tue, 25 Nov 2025 09:33:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id U63GK/B3JWlMRQAAD6G6ig (envelope-from ); Tue, 25 Nov 2025 09:33:36 +0000 Date: Tue, 25 Nov 2025 10:33:35 +0100 From: Oscar Salvador To: Shameer Kolothum Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, muchun.song@linux.dev, vivek.kasireddy@intel.com, jgg@nvidia.com, nicolinc@nvidia.com, nathanc@nvidia.com, mochs@nvidia.com Subject: Re: [PATCH] mm/hugetlb: Fix incorrect error return from hugetlb_reserve_pages() Message-ID: References: <20251022102956.245736-1-skolothumtho@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251022102956.245736-1-skolothumtho@nvidia.com> X-Spam-Level: X-Spam-Flag: NO X-Rspamd-Queue-Id: 5FDE822550 X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_SEVEN(0.00)[9]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MISSING_XM_UA(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim] X-Spam-Score: -4.51 On Wed, Oct 22, 2025 at 11:29:56AM +0100, Shameer Kolothum wrote: > The function hugetlb_reserve_pages() returns the number of pages added > to the reservation map on success and a negative error code on failure > (e.g. -EINVAL, -ENOMEM). However, in some error paths, it may return -1 > directly. > > For example, a failure at: > > if (hugetlb_acct_memory(h, gbl_reserve) < 0) > goto out_put_pages; > > results in returning -1 (since add = -1), which may be misinterpreted > in userspace as -EPERM. > > Fix this by explicitly capturing and propagating the return values from > helper functions, and using -EINVAL for all other failure cases. > > Fixes: 986f5f2b4be3 ("mm/hugetlb: make hugetlb_reserve_pages() return nr of entries updated") > Signed-off-by: Shameer Kolothum > --- > mm/hugetlb.c | 25 ++++++++++++++++++------- > 1 file changed, 18 insertions(+), 7 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 795ee393eac0..1767f7599f91 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -7269,6 +7269,7 @@ long hugetlb_reserve_pages(struct inode *inode, > struct resv_map *resv_map; > struct hugetlb_cgroup *h_cg = NULL; > long gbl_reserve, regions_needed = 0; > + int ret; > > /* This should never happen */ > if (from > to) { > @@ -7308,8 +7309,10 @@ long hugetlb_reserve_pages(struct inode *inode, > } else { > /* Private mapping. */ > resv_map = resv_map_alloc(); > - if (!resv_map) > + if (!resv_map) { > + ret = -EINVAL; Why is this one EINVAL? Should not this be ENOMEM? -- Oscar Salvador SUSE Labs