From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DF90270568 for ; Tue, 25 Nov 2025 12:52:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764075140; cv=none; b=co2BUy1aP2deAH/vxUD34Wu8elOHSY24jyCKt0p1FMxij9rXkuNy0ovMsjlaEJhdI7sYgnqbf512ScLIfaksZRpdw9BqSxvJG3zL3WTAzj12lYjQdNK+Sqfc58jCIymMlcPvkzUC2aLlBZj9CxiHQkx/J4x5LmIZeGpjvS/bDKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764075140; c=relaxed/simple; bh=vIIA4mGVLl8jc/UPq9XG9j6Ah4loj0+Tur/++NhByww=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Yv9eJCFPXHUclanPs/ase2EUHbqDzmHP3e6SEuF95Q5AbEmzc7+r4ZbkZuio/z09x8BhBAGzj2FLPcJEKZEszPwH4fFBMToI2ESfva8dsVDcfT5DcbwnaRezQXfes4ux6zHO+kDYvde/GKaF0cAyJL/T47VtVEX1vcHDZmrlmME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QEwdvki6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VWM/Wyrd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QEwdvki6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VWM/Wyrd" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AP9hnLC1978879 for ; Tue, 25 Nov 2025 12:52:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=ScsI51p3RWiGpmzl/Y8j4lB7 RZh14EyXHK9ApFQwIe4=; b=QEwdvki6JE1nnKvi9Yh4vrMtgDgaAtvL/NipXHPw wAmlsqyOgXI3fhNfjajdVEHWAxK3F+K8ipISqIID92tMVjf0EqseAppM9pH0w9Q3 wQaBvtzN3ltHeiGdvMMDuoFR5wBLaV+zdpdAVmPT5epttk78/omyvWS8SmLHZg8H I0jQ1e43W4GZ/2jCFaL9jF0ViiZEEGzjvnCKgx9v7VmQ0MuWXbLNdDaVKQHjytJO GEMp3HZMBdgSp5eD30gMzE8NR1VG+uQ6GPKqmoczrWFgndbNOYnKD6zTBCgmRpj/ uKey5g5MfmdpEaeLoUN/yXcq1kPITyp6JeS4Q6FcNPdheg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4amw9gtp35-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Nov 2025 12:52:17 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4edad69b4e8so123353431cf.1 for ; Tue, 25 Nov 2025 04:52:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764075137; x=1764679937; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=ScsI51p3RWiGpmzl/Y8j4lB7RZh14EyXHK9ApFQwIe4=; b=VWM/WyrdRbRXvZr+N8RBz8hLJSjGxj+Tb8KvYvxUACj1fOnmOis3Twm8mYf/A3uyq9 O6uzz3gStkl5/uTDp8InzXTh0uKklbARyAjZrVnj47bi1GFy5F32B65ywMQ4/5l3THpr LpccoGumDisaOIQygyN7d6+11385JJAtTO3Oy7l6PnwMIZarEUARXnKe6iIROY1E43Pz OklGgMRyFQKUISqpKfT8RXi/w2FqyxbSAzu71XJI7JIbWwjA2vuoKjco/MUhBwcrFf6d iZTdS6eV4dZUnWfFVhsolBUifP2OXqXLtAP35OmA/c3JWqd5XX183i9L/fBfaZ1VOX/0 +/6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764075137; x=1764679937; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ScsI51p3RWiGpmzl/Y8j4lB7RZh14EyXHK9ApFQwIe4=; b=d9AiQGkl3DeUg86cUybfnYlLZNkJItXXKJOn3efSKTzCTEoivPkvDRICaMbA3/Ajzp GdotswkHEcW78XitUdpADL0ERZmZrbMrwctB5z1CTVVKwqhTSKwyoqrJ10ePijCgZOh+ k/qybc6mB7nsLQnNypk7dsKt1HTTsLiLhUPMrzn2xJbHq4hY6GysNfT1935bz5bmWCI6 fPaxPDRa/3rMU3x+GX8S9bTvHnfdZIIh1Q+xgI91jgcsFsjA05ZJseXCxgULfnL5PXKf Or7h7ID4rQ5AArubBdY26Wpo62r4jKXGpYUx6ZFW0UinH15FtXuIYsw236AO26yDw72w qL4Q== X-Forwarded-Encrypted: i=1; AJvYcCX62tBrXXqsNQWGGk7Bh9PzT86QTL//0gq7DmT1HPp/nUSbHpvVTMeQNEOC88yA9aGfOpNRePb8EVJtgSk=@vger.kernel.org X-Gm-Message-State: AOJu0Yzo/06sLD+BQj1jBW3QyAwolKe/6NSaKx49rIuzVeSV19aA1ePj M6L9+6IRqQbgLNuiLZ3UviBghc/oADIrFmAMyAO0/VwOZPdSm+6rXwlnBmqM4G4oJQhKZDc2hf3 kgOWu7dEVlM5Yy2PIqFtdYRX5Y+nvT0iBPmIlHIeTK0L1xlfsQFDMQRcxqBBy4/bYb2o= X-Gm-Gg: ASbGncurA+pSxnUcohDttVNypjWj0an1uLZkJIidojnpLH3YorcIc5WfPQ/5b87n2yN IIDrjOQW9ngKu7TPO0hJ7ouwDTIxCgRG5wwsDAxGn5tSZJOPozvq7o5i2WCWM2Vfa83V9YBr0yn ybIx4BR9jTjt1gbhHuzLrRDK8vd4c4qpdqjr4kXGyIrvGylWS3TYh4uQpPlY2GEVLTYLmyf8ion PgUN/CB7KSYYEDzICoBCtuMAw0NX6hPgdqpPYqS4NHETrVLgyy+C4riVbVZiSVWYmHRpT7QsklW 42BIUAnnHW913UT2iw8wiID0TNND7Xm7DtyiTGBxLWZC6LMvSHylhWzgQ68Mr2MEDyovZKp1OyD AnXrzUZyKkjImJ3clGbwnybQWCIpfvienbNTht0+FkpJ/ X-Received: by 2002:ac8:5dc8:0:b0:4eb:a715:9aee with SMTP id d75a77b69052e-4ee4b418901mr258840751cf.4.1764075136698; Tue, 25 Nov 2025 04:52:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IEh976qJxsmgG1mRA1z6ZOeIgC3zUggBSkOeolUKxGfDS9bMppxdScyvFcId7vgKqtNNtwSgA== X-Received: by 2002:ac8:5dc8:0:b0:4eb:a715:9aee with SMTP id d75a77b69052e-4ee4b418901mr258840511cf.4.1764075136248; Tue, 25 Nov 2025 04:52:16 -0800 (PST) Received: from trex (125.red-79-144-189.dynamicip.rima-tde.net. [79.144.189.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf1e872esm249357255e9.5.2025.11.25.04.52.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 04:52:15 -0800 (PST) From: Jorge Ramirez X-Google-Original-From: Jorge Ramirez Date: Tue, 25 Nov 2025 13:52:09 +0100 To: Dikshita Agarwal Cc: Jorge Ramirez-Ortiz , vikash.garodia@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: venus: assign unique bus_info strings for encoder and decoder Message-ID: References: <20251121184306.218169-1-jorge.ramirez@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI1MDEwNiBTYWx0ZWRfX9ZjXtnupnYkU IDAdH1P+ftn2G3bkkdtVycsWqSxwnyl0S6Q29C80BOheouhwHR7Uep2YV9HnV/7gj5BnamOiIAL Yh61Onvtgr+c78QUahAnRlT5hVTAzkHC+2obemp5PHqQ6QphInexYEoGg9cVEStXymWk96vtp8k 5RpxVvrdLQ5Q9ypZtTSMHqXRxPQaqKzF9GsF4GTmoGYdLXRno2M8hzHsDi4zbtAO61zDqzAc16Q L0sLBFWiOLG82TMi3zKU3KZfkoo8wmF7sgC8rQVEJMkAxwekSFgkeFWenEkNUIR/2p0VU5434wl BrHmD0pvt62XAuMMmwbfn0ulHAgtbl5O3aSH5jbxJQbRQApoIApWxpFddSKRWZ5Ph+/fuO8ny43 8XHSlPgwJ+vcHrq17PPbh8Rhmck9rg== X-Authority-Analysis: v=2.4 cv=H53WAuYi c=1 sm=1 tr=0 ts=6925a681 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=QCpOfKHlYVe8AePir1+hrw==:17 a=kj9zAlcOel0A:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=8RCVjF8-wm2c15ljX7YA:9 a=CjuIK1q_8ugA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: 45ZubLlHVpKn_XPTJnyPPkZT6H1gtWd8 X-Proofpoint-GUID: 45ZubLlHVpKn_XPTJnyPPkZT6H1gtWd8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 phishscore=0 clxscore=1011 lowpriorityscore=0 adultscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511250106 On 25/11/25 13:59:56, Dikshita Agarwal wrote: > > > On 11/22/2025 12:13 AM, Jorge Ramirez-Ortiz wrote: > > The Venus encoder and decoder video devices currently report the same > > bus_info string ("platform:qcom-venus"). > > > > Assign unique bus_info identifiers by appending ":dec" and ":enc" to the > > parent device name. With this change v4l2-ctl will display two separate > > logical devices > > > > Signed-off-by: Jorge Ramirez-Ortiz > > --- > > drivers/media/platform/qcom/venus/vdec.c | 5 +++++ > > drivers/media/platform/qcom/venus/venc.c | 5 +++++ > > 2 files changed, 10 insertions(+) > > > > diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c > > index 4a6641fdffcf..63f6ae1ff6ac 100644 > > --- a/drivers/media/platform/qcom/venus/vdec.c > > +++ b/drivers/media/platform/qcom/venus/vdec.c > > @@ -433,9 +433,14 @@ vdec_g_selection(struct file *file, void *fh, struct v4l2_selection *s) > > static int > > vdec_querycap(struct file *file, void *fh, struct v4l2_capability *cap) > > { > > + struct venus_inst *inst = to_inst(file); > > + struct venus_core *core = inst->core; > > + > > strscpy(cap->driver, "qcom-venus", sizeof(cap->driver)); > > strscpy(cap->card, "Qualcomm Venus video decoder", sizeof(cap->card)); > > strscpy(cap->bus_info, "platform:qcom-venus", sizeof(cap->bus_info)); > > + snprintf(cap->bus_info, sizeof(cap->bus_info), > > + "platform:%s:dec", dev_name(core->dev)); > > Is there a reason to keep both strscpy() and snprintf() for cap->bus_info? > The second call to snprintf() seems to overwrite the value set by > strscpy(), making the first assignment redundant. Would it be cleaner to > remove the strscpy() line and rely solely on snprintf()? argh, my bad, you are right. will fix. perhaps we should just have instead decoder: strscpy(cap->bus_info,"platform:qcom-venus-dec", sizeof(cap->bus_info)); encoder: strscpy(cap->bus_info, "platform:qcom-venus-enc",sizeof(cap->bus_info)); on the encoder I suppose the additional info provided by the dev_name is not really important to consumers. ?