From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33CE030DD29 for ; Wed, 26 Nov 2025 03:28:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764127682; cv=none; b=hLIpDfe+pp0C9vWth3abTXdDui0TXxyJreDZMLGctiPf9sZ11gg6Xuv0AYMPfX1N5HIZDwgVkoEvF/jelh4xUGP6GfctTzDxAlAzudko9Fy3cZhFnxkUQOrgDOw1QyOcoAAIraHlh21x0kDMhjX3DYMsZKYOX5PJmp2oahYtYQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764127682; c=relaxed/simple; bh=8qfzksOJbbTsCAArgtKRpDmbL7H3emUXbpVOCg00fyc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RBANJaTOdmakvfBnyzTUx4/c/tjQtIsDiAlAFfeP6EFWoDVgSZOkLtyTVZhTA9FS0kDwLMKFsIwh2UGr2aq9dqA8KE5HaLSDn0o0LJCjGLCxy5StMSqpBOrz1DpYuLynDBBs5Y0ulR63ccfCNZ/jP/vzrQCQs6GRAJB9WknKYWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VaD6ScxF; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VaD6ScxF" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-7b8eff36e3bso9692270b3a.2 for ; Tue, 25 Nov 2025 19:28:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764127679; x=1764732479; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=51lFxwZazAf8fla+gakTIRMJxAjLqhU3wJI76M1NFic=; b=VaD6ScxFrp8LqX177cp8V4uvnkz28jm9DTx60wfOLF+6DBTfKAjV1ry5Tiv1X/Ap6v 797K+rURgSnvAO5ah1Qgnl8zihueUy5HHs5HTRYtEGzFS2zMEYf927le/Wx4Eq2Qp26J nQMmVJFLEIX2YwIkgWFas1rmEwfwW+44WXba3hfWt/svnEzDSV9OVEyAcN/ktP3n3zN/ Usy/hNF4uUEm+ehzE1T31XcoEHNADBJlDs0QtfG+vEajflcLF0CCi0VpeNtlr9Y9FsQR il0M4mdviputUnW/qBdBgSNV1NAz60Dz0dXDFtHe2wk8NH7tlcwpk9HpHcUT90djkIp8 5N6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764127679; x=1764732479; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=51lFxwZazAf8fla+gakTIRMJxAjLqhU3wJI76M1NFic=; b=rgYYfkYhdg00GNBpFYKJCDNNi8qdGKfL9oKL9dmh6le4pM1kNiRnY43nCd59o6eVbz 9D0msFg75behjderkmpSiqDvhsnGVj4r2w1X0MN9CDkBFVmskYQA40lRWAx9sBx17oPi vmaUsJoqDnkv8m16y7spZQ+HXrVSLcCnHn93w8+i5MY1UT68SrJg7WE7+0/osiepkbXJ W2KXSfMt9UFQPDxRYwAYZUkVZQdZ2RjqG1NvuzGlxBk1RAh+G7BDkgL/Kie3sz8KAwVS 8PWISOJX3XLQAlKrqCkydzKAIlN94kjIzoO8hZMgjz07llzzuqNdWjagZovv+p61/Hbr CT8g== X-Forwarded-Encrypted: i=1; AJvYcCW+vqTYSSMWz6WjMB1oTZTb4/wM2XXxNxMDQRyPTe9z8eqbFbHGwpgCfAfDaGRWLK06Q4xSPyaij6+Mt+4=@vger.kernel.org X-Gm-Message-State: AOJu0YzxNq5F+DvAR46MJTzBQz/8yu5rP/i6KtFwlNLGqRNuK8r1YqTH kzK64aBdSt1lTzjWb7dwbKHQWzeqrBnI6Mi6SXSVJonf1fBAZwZNgq/1 X-Gm-Gg: ASbGncvGml93hcE43ymNyddIB1kgcmImbUw1+d+QxDiNBvMFrIABtu2xUfdaY6KUO7O ge+E5bMEPxhP3/QnNbQrwloud7pORC0W1zTqXxMWZJ3tvCMCduDCxAGVO4RzX+WgY+ZvcbFhCgU Ii5F9aaKDybVv09SCugsksxBYpzPwBgGb8QP53razmZNWed7F2AjBfkSWQpWjN9YtUNNqeGNEDG rSw/dmqR+duCLu7p0OtzKBfxBVxqdGB5ur/YFkqLWiTIjZF4c2cqMUxENoohLu0UFHXyMM1wv/d LMUjRbQ4SnQ4ydF5Y9xiYif7dVC11z99+T+F26W/O+SCFRSrpTTF/IpFX7UT+RfrHCIy7tueGQn CIOmWr+1v1tQzLPSqULf8QtHSWoBb24x9uplsKKqYU1Wg9UBu65S86nYxP8P9D4hDW6MjySKDQD tgFN0xXSdSy2g= X-Google-Smtp-Source: AGHT+IG9xHzrSQWvZCXHCGOpqvWXyFnbV+8dBSEJrT3vhP/mRsbjw5OciOtuksf2l1kJH+WCP8MtWw== X-Received: by 2002:a05:6a20:3c8d:b0:35f:84c7:4031 with SMTP id adf61e73a8af0-3637e0d3593mr5748425637.55.1764127679511; Tue, 25 Nov 2025 19:27:59 -0800 (PST) Received: from archie.me ([210.87.74.117]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3ed471060sm19640415b3a.15.2025.11.25.19.27.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 19:27:58 -0800 (PST) Received: by archie.me (Postfix, from userid 1000) id CBEA845A3F83; Wed, 26 Nov 2025 10:27:56 +0700 (WIB) Date: Wed, 26 Nov 2025 10:27:56 +0700 From: Bagas Sanjaya To: Bhanu Seshu Kumar Valluri , Vinod Koul , Jonathan Corbet Cc: dmaengine@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, khalid@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com Subject: Re: [PATCH] docs: dmaengine: add explanation for phys field in dma_async_tx_descriptor structure Message-ID: References: <20251113064937.8735-1-bhanuseshukumar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="U9VBp7oVmCj/Mqtc" Content-Disposition: inline In-Reply-To: <20251113064937.8735-1-bhanuseshukumar@gmail.com> --U9VBp7oVmCj/Mqtc Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 13, 2025 at 12:19:37PM +0530, Bhanu Seshu Kumar Valluri wrote: > diff --git a/Documentation/driver-api/dmaengine/provider.rst b/Documentat= ion/driver-api/dmaengine/provider.rst > index 1594598b3..f4ed98f70 100644 > --- a/Documentation/driver-api/dmaengine/provider.rst > +++ b/Documentation/driver-api/dmaengine/provider.rst > @@ -411,7 +411,7 @@ supported. > - This structure can be initialized using the function > ``dma_async_tx_descriptor_init``. > =20 > - - You'll also need to set two fields in this structure: > + - You'll also need to set following fields in this structure: > =20 > - flags: > TODO: Can it be modified by the driver itself, or > @@ -421,6 +421,9 @@ supported. > that is supposed to push the current transaction descriptor to a > pending queue, waiting for issue_pending to be called. > =20 > + - phys: Physical address of the descriptor which is used later by > + the dma engine to read the descriptor and initiate transfer. > + > - In this structure the function pointer callback_result can be > initialized in order for the submitter to be notified that a > transaction has completed. In the earlier code the function pointer The wording LGTM, thanks! Reviewed-by: Bagas Sanjaya --=20 An old man doll... just what I always wanted! - Clara --U9VBp7oVmCj/Mqtc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCaSZztQAKCRD2uYlJVVFO o3iXAP9hXC3MnhskzYfaAyFleh+Po17o9hELn1Mf7RwHDBrknQD+LKtDpNOsLJVe M+AIvBjSO5AFnmkh3L8D5e+INwmlcQA= =XV4N -----END PGP SIGNATURE----- --U9VBp7oVmCj/Mqtc--