From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D86028E579 for ; Wed, 3 Dec 2025 09:02:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764752545; cv=none; b=Fxmx+X11LyVJd9GPMdasjQo5+6h2AS2QmPvWc7mfdJomg7k07nvVOFxc0KPWXb1+MBTVqhfMVJMmU44PcH/XK9fyM4EuOrtxTf9g3Q/LapRvpVeXyG47UPQ9/leW0bJN1y9N3eIJJsRM/3qY6mWmOVIeo0Su12IoaedoExNfMU8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764752545; c=relaxed/simple; bh=20ksbcehD3uHiaZjNXwj0tmynGyqP/AWmNlFCVFk0Qk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=emTDcu5/8oqd7Rq9txyNqEsO49JQ0Oo8BgT5puE4XxiG0uQNbBVUe9X99TMbioET49M+VlUCnNlctmRVrUcIlUnUZfJHkPlqh9DJaR29Cl44nK8jHaxqum2NGjnfjMkl1c0oaf8wd225NnCCxSKUKOyU8A+5nsX+Xy1foimnwso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=A2e7m75F; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="A2e7m75F" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-8b2e530a748so555664885a.0 for ; Wed, 03 Dec 2025 01:02:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1764752543; x=1765357343; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4saF+51MpcMqreRhfl2CsLn54xRQyLgAhIk0DIIYoNw=; b=A2e7m75F0s+RffCNfJYd2M720qeowwz1jsKipHgZS6gpzWuzmopQDkfevXaKA2B3WO Cr8cKfwCCuPNocLeoFx9pAH4zbLEgGRi0absEbO6kYeSG3OziezjtKkUEfuZ50izZApD EcI1HeaqKLtupx853FUU2lJaSbRJ/DA5TKHHBxdTABXRPEQiJqpNJhi7RNKIAWzjw7H9 PoJnQcPSjUe3UQH7LDdPLFSRfAIxi+bAErNdIPTzHj8eEJo/49oTmc4eay0GIsV+U7hL YJrYCp0wOEOVZ7COlBaPwL4NJ/G4rcmVX0tqEpJay5GdNUPQBsrz6an4lGSr809ZUi0t LBag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764752543; x=1765357343; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4saF+51MpcMqreRhfl2CsLn54xRQyLgAhIk0DIIYoNw=; b=QRT+RCjCz5dXF/7JpVtsmga/Tar44GDHaJfo1/cOQngfETwJT1CgMTJ9h6fZJoMLik glaBrGKmpVhjRqQDXQ/Am+7J185aCN3kZl3zGBA6xHsiLLcJIK+J0NFnPS5aVqyyajQg opC3fckIqUAceoYieIWDFO+J4E/vA51amM7IqFM/4u9IyobfDt1dRalvMs9hxEdqMkE7 aRsT6y6ngeauwYdJ0BT496hKqOp96cQhZBjDoWcDo+4ABVSwEDcV3quby0ESQATgYEOd W7oiHFi46Y1/k5xp9rs0BBYqEk4OQ4+l81ZoRZn/JOV5XMoTUdVt+wCe0AiEVNy78fN+ h9gg== X-Forwarded-Encrypted: i=1; AJvYcCVdJzeDuP2hWew1an1ZjsXsGzn1T9xo+vwE8Ke51ofyaC7BqIgj4rGmIgQeqf1nr6mP1cM4ht2QrLigM6M=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6YWz3TaTU5pFv4HXUaaPZkCXlxGiZdBP7Rc35pAgEq3aJmcPO ggpuAOK2GvXp2FgdPGzU+lSQv+Kai6FSw1did6s8U6E2YFVoCAoFLL1sZ5JI+S1aETI= X-Gm-Gg: ASbGncvdj17DwE6jTG4oJCL6v0chbGBr/Wy+AXfeQO44h2B+qsa9LRcquCPruy9pBTr 4mMCm1jr163IOFF6S9l32WqRLDJ8p3EexYI5Zy6EhTJMacaFTafvlKUNuU/sNhcSiPJI/JPcU/s giAGc7+IyuRsffu47fucZdrFljnqDx4uueO/OrzsdIbmVm20WqjCE7wAQaOUoqBQeccm277mE0Y Kvrko6XrTPM42xfpKCQ4gpWdUYD737E0dccMAtiNn/rjXl0TbJMlpA54S6mte8lN8gJ0PJwuen7 CuyXssvLCRTtgUsviJyRcA7APX8s2uQJSUFTrhTIMDtEYKIUqqBYRa1FxFoGyl0yQMSwUCbajGC CTHiWuVTqZr51RjvWyMfD8SSP+UcxHS+XRpLz3lTUtKNosapBcJtTHNe8WH3avjAYfXMot/rrzv ACAPnutE6OtrPxXT+STjiQVs4CXSC35RV4DZ/s2MPyRhe71mSnA4aWO2jXvwbJK13049KMbQ== X-Google-Smtp-Source: AGHT+IGTm2nWUY9JPc6rZPyJWuZPb39lBOWDSCMEk0hxE/la6Ur82Jbp5YL+S/PQyNYLAP6umf5wkQ== X-Received: by 2002:a05:620a:372c:b0:8a7:2373:1c75 with SMTP id af79cd13be357-8b5e6c924f1mr186372385a.49.1764752543119; Wed, 03 Dec 2025 01:02:23 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b52a1b759esm1283219685a.31.2025.12.03.01.02.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 01:02:22 -0800 (PST) Date: Wed, 3 Dec 2025 04:02:21 -0500 From: Gregory Price To: "David Hildenbrand (Red Hat)" Cc: Michal Hocko , Andrew Morton , Aboorva Devarajan , vbabka@suse.cz, surenb@google.com, jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: Re: [PATCH] mm/page_alloc: make percpu_pagelist_high_fraction reads lock-free Message-ID: References: <20251201060009.1420792-1-aboorvad@linux.ibm.com> <20251201094112.07eb1e588b6da2ee70c4641d@linux-foundation.org> <47a8b4d5-f4d2-4772-b1b2-ee96bc21e742@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47a8b4d5-f4d2-4772-b1b2-ee96bc21e742@kernel.org> On Wed, Dec 03, 2025 at 09:51:52AM +0100, David Hildenbrand (Red Hat) wrote: > On 12/3/25 09:42, Michal Hocko wrote: > > > if (!ret) { > > > /* > > > * TODO: fatal migration failures should bail > > > * out > > > */ > > > do_migrate_range(pfn, end_pfn); > > > } > > > ... > > > > > > Maybe it's time to implement the bail out? > > > > That would be great but can we tell transient from permanent migration > > failures? Maybe long term pins could be treated as permanent failure. > > Did we try offline a ZONE_MOVABLE block or a ZONE_NORMAL block? In case of > ZONE_MOABLE, bailing out is not really the right thing to do. > My transient failure (although i'm not sure it was actually transient, i killed it and retried after a few minutes and it succeeded immediately) was on a ZONE_MOVABLE block. Kind of suggested to me there was some bad condition the resolved once I took a second to release the lock and try again. Can't speak for Aboorva's situation. ~Gregory