[PATCH] adfs: Fix incorrect unsigned return type in adfs_f_getnext()

[PATCH] adfs: Fix incorrect unsigned return type in adfs_f_getnext()

[Haotian Zhang]

adfs_f_getnext() stores the return value of __adfs_dir_get() into an
unsigned int. Since __adfs_dir_get() may return negative error codes
such as -ENOENT, these values are converted into large positive numbers.

Change the return variable to type int to correctly preserve and return
negative error codes.

Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
---
 fs/adfs/dir_f.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
index 05e963402e25..81dedb796b56 100644
--- a/fs/adfs/dir_f.c
+++ b/fs/adfs/dir_f.c
@@ -242,7 +242,7 @@ adfs_f_setpos(struct adfs_dir *dir, unsigned int fpos)
 static int
 adfs_f_getnext(struct adfs_dir *dir, struct object_info *obj)
 {
-	unsigned int ret;
+	int ret;
 
 	ret = __adfs_dir_get(dir, dir->pos, obj);
 	if (ret == 0)
-- 
2.50.1.windows.1

Re: [PATCH] adfs: Fix incorrect unsigned return type in adfs_f_getnext()

[Russell King (Oracle)]

On Wed, Dec 03, 2025 at 02:51:20PM +0800, Haotian Zhang wrote:
> adfs_f_getnext() stores the return value of __adfs_dir_get() into an
> unsigned int. Since __adfs_dir_get() may return negative error codes
> such as -ENOENT, these values are converted into large positive numbers.
> 
> Change the return variable to type int to correctly preserve and return
> negative error codes.
> 
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>

The real problem here is the unsigned int -> int conversion, which is
implementation defined in C. int -> unsigned int itself is well
defined.

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!