From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Haotian Zhang <vulab@iscas.ac.cn>,
herve.codina@bootlin.com, gregkh@linuxfoundation.org,
linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: renesas_usbf: Handle devm_pm_runtime_enable() errors
Date: Wed, 26 Nov 2025 13:47:03 +0100 [thread overview]
Message-ID: <aSb2x6Qiru4KLOcy@black.igk.intel.com> (raw)
In-Reply-To: <CAMuHMdUSPSjh4nQ1B6NJdYZw3qW30Tx5zci6vy_9Hy6BS64FWQ@mail.gmail.com>
On Mon, Nov 24, 2025 at 02:15:14PM +0100, Geert Uytterhoeven wrote:
> On Mon, 24 Nov 2025 at 03:24, Haotian Zhang <vulab@iscas.ac.cn> wrote:
> Thanks for your patch!
...
> > - devm_pm_runtime_enable(&pdev->dev);
> > + ret = devm_pm_runtime_enable(&pdev->dev);
> > + if (ret)
> > + return ret;
>
> Perhaps insert a blank line here?
>
> > ret = pm_runtime_resume_and_get(&pdev->dev);
> > if (ret < 0)
> > return ret;
FWIW, if not fixed yet, this driver from this line towards the end of
the function leaks the PM runtime reference count.
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-11-26 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 2:22 [PATCH] usb: gadget: renesas_usbf: Handle devm_pm_runtime_enable() errors Haotian Zhang
2025-11-24 7:43 ` Herve Codina
2025-11-24 13:15 ` Geert Uytterhoeven
2025-11-26 12:47 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSb2x6Qiru4KLOcy@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox