[PATCH] serial: 8250-of: Fix style issues in 8250_of.c

[PATCH] serial: 8250-of: Fix style issues in 8250_of.c

[jempty.liang]

This patch resolves the warning "sizeof *port should be sizeof(*port)"
detected by checkpatch.pl.

Signed-off-by: jempty.liang <imntjempty@163.com>
---
 drivers/tty/serial/8250/8250_of.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_of.c b/drivers/tty/serial/8250/8250_of.c
index d178b6c54ea1..9799356b65f7 100644
--- a/drivers/tty/serial/8250/8250_of.c
+++ b/drivers/tty/serial/8250/8250_of.c
@@ -95,7 +95,7 @@ static int of_platform_serial_setup(struct platform_device *ofdev,
 	u32 spd;
 	int ret;
 
-	memset(port, 0, sizeof *port);
+	memset(port, 0, sizeof(*port));
 
 	pm_runtime_enable(&ofdev->dev);
 	pm_runtime_get_sync(&ofdev->dev);
-- 
2.25.1

Re: [PATCH] serial: 8250-of: Fix style issues in 8250_of.c

[Andy Shevchenko]

On Mon, Nov 17, 2025 at 03:41:17AM +0000, jempty.liang wrote:
> This patch resolves the warning "sizeof *port should be sizeof(*port)"
> detected by checkpatch.pl.

If you are going to submit more patches like this or related to sizeof, it
would be worth to mention that while sizeof is an operator, the coding style
recommends to use parentheses (but I haven't double checked this, feel free
to find it in the Coding Style documentation).

> -	memset(port, 0, sizeof *port);
> +	memset(port, 0, sizeof(*port));

From C perspective the original one is okay.

-- 
With Best Regards,
Andy Shevchenko