From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C304330214C for ; Wed, 26 Nov 2025 14:11:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764166276; cv=none; b=IHYEDsAUiuAj+jQ/BrRDyxaCsTDIg9O9VLb/Kqy8sgaH8E72NdBsu0uJPdNX86FnIEAGuJzCRJP5EcdVeiVQ2r8608RaSIY1X+XZOjsM9NNFZt4aoGlFwyS+Ca1ABh9P9I5l8x7dCS8Ugs5bTlWVg5wXme7vAeQVWikj4alK0zo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764166276; c=relaxed/simple; bh=cAhwqc2QVk/UHj65dHWdk0Jw7qEhmNi62zV+i+/URO0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J2hEmtK66QYQIbl6u3k/f5gxJeyPWmfsXzOyLxmgDaB7xy4hlaPI6AccE4C4o4EAZtf0BQ36wZV+NMy2AdqU2Zt0A9Sdp3nj2PumuVS8DQYqEvbHCCtAVGWtjVv3I/NBuvT5CryqDEGadKO3C3JezVyXgjhvwFi3LN2JCVDQwno= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=qqFkRoFF; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=sErewIAZ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=qqFkRoFF; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=sErewIAZ; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="qqFkRoFF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="sErewIAZ"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="qqFkRoFF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="sErewIAZ" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 920AC5BD21; Wed, 26 Nov 2025 14:11:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1764166272; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9ZolWcKpYKNTSI5G4tfaEenm8+nHT8Wl8rOnJEhk1Tw=; b=qqFkRoFFsSvcseTsYz6Q/4Xml0ft3+yUvusQxiVhrp1Asg+Ein8vW7gJLQw/+IubILQZoA zspwESEo+gGARpX/6Pmof1rpzaMbDM6VguLTnBG7w3Oh40tWa/JxPMyqGiF0XhoaWmPXAQ vMOuVmJzIpQbdaoYdMxex40tDUWJZfc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1764166272; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9ZolWcKpYKNTSI5G4tfaEenm8+nHT8Wl8rOnJEhk1Tw=; b=sErewIAZKJQvA6kmx83SXz//3pDc6qpPZeHFZihrGIANR7hS9DCMiP+OrGwRRECsMmwB+k DWFjJsooLhVr8iBA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=qqFkRoFF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=sErewIAZ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1764166272; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9ZolWcKpYKNTSI5G4tfaEenm8+nHT8Wl8rOnJEhk1Tw=; b=qqFkRoFFsSvcseTsYz6Q/4Xml0ft3+yUvusQxiVhrp1Asg+Ein8vW7gJLQw/+IubILQZoA zspwESEo+gGARpX/6Pmof1rpzaMbDM6VguLTnBG7w3Oh40tWa/JxPMyqGiF0XhoaWmPXAQ vMOuVmJzIpQbdaoYdMxex40tDUWJZfc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1764166272; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9ZolWcKpYKNTSI5G4tfaEenm8+nHT8Wl8rOnJEhk1Tw=; b=sErewIAZKJQvA6kmx83SXz//3pDc6qpPZeHFZihrGIANR7hS9DCMiP+OrGwRRECsMmwB+k DWFjJsooLhVr8iBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F1B953EA63; Wed, 26 Nov 2025 14:11:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id FulIOH8KJ2m+LQAAD6G6ig (envelope-from ); Wed, 26 Nov 2025 14:11:11 +0000 Date: Wed, 26 Nov 2025 15:11:06 +0100 From: Oscar Salvador To: Shameer Kolothum Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, muchun.song@linux.dev, vivek.kasireddy@intel.com, joshua.hahnjy@gmail.com, jgg@nvidia.com, nicolinc@nvidia.com, nathanc@nvidia.com, mochs@nvidia.com Subject: Re: [PATCH v3] mm/hugetlb: Fix incorrect error return from hugetlb_reserve_pages() Message-ID: References: <20251125171350.86441-1-skolothumtho@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251125171350.86441-1-skolothumtho@nvidia.com> X-Spamd-Result: default: False [-2.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[kvack.org,vger.kernel.org,linux.dev,intel.com,gmail.com,nvidia.com]; RCPT_COUNT_SEVEN(0.00)[10]; DBL_BLOCKED_OPENRESOLVER(0.00)[nvidia.com:email,suse.de:email,suse.de:dkim]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Level: X-Spam-Score: -2.01 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 920AC5BD21 X-Rspamd-Action: no action X-Spam-Flag: NO On Tue, Nov 25, 2025 at 05:13:50PM +0000, Shameer Kolothum wrote: > The function hugetlb_reserve_pages() returns the number of pages added > to the reservation map on success and a negative error code on failure > (e.g. -EINVAL, -ENOMEM). However, in some error paths, it may return -1 > directly. > > For example, a failure at: > > if (hugetlb_acct_memory(h, gbl_reserve) < 0) > goto out_put_pages; > > results in returning -1 (since add = -1), which may be misinterpreted > in userspace as -EPERM. > > Fix this by explicitly capturing and propagating the return values from > helper functions, and using -EINVAL for all other failure cases. > > Fixes: 986f5f2b4be3 ("mm/hugetlb: make hugetlb_reserve_pages() return nr of entries updated") > Reviewed-by: Joshua Hahn > Reviewed-by: Jason Gunthorpe > Signed-off-by: Shameer Kolothum Acked-by: Oscar Salvador -- Oscar Salvador SUSE Labs